Avi Drissman | 4a8573c | 2022-09-09 19:35:54 | [diff] [blame] | 1 | // Copyright 2009 The Chromium Authors |
[email protected] | 3641da6c | 2009-07-08 14:59:06 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Daniel Cheng | 7d9e3d5 | 2022-02-26 09:03:24 | [diff] [blame] | 5 | #include "chrome/browser/global_keyboard_shortcuts_mac.h" |
| 6 | |
[email protected] | 92f5adfa | 2010-01-05 09:49:12 | [diff] [blame] | 7 | #include <AppKit/NSEvent.h> |
[email protected] | 1d313b83 | 2009-10-09 01:26:20 | [diff] [blame] | 8 | #include <Carbon/Carbon.h> |
avi | 6846aef | 2015-12-26 01:09:38 | [diff] [blame] | 9 | #include <stddef.h> |
Jayson Adams | 6bc96ee | 2022-01-15 00:03:29 | [diff] [blame] | 10 | |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 11 | #include <initializer_list> |
[email protected] | 1d313b83 | 2009-10-09 01:26:20 | [diff] [blame] | 12 | |
Hans Wennborg | f6ad69c | 2020-06-18 18:02:32 | [diff] [blame] | 13 | #include "base/check_op.h" |
[email protected] | 1a3aba8 | 2010-11-08 23:52:54 | [diff] [blame] | 14 | #include "chrome/app/chrome_command_ids.h" |
[email protected] | 3641da6c | 2009-07-08 14:59:06 | [diff] [blame] | 15 | #include "testing/gtest/include/gtest/gtest.h" |
Scott Violet | b72577d | 2019-01-09 22:18:18 | [diff] [blame] | 16 | #include "ui/base/buildflags.h" |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 17 | #include "ui/events/keycodes/keyboard_code_conversion_mac.h" |
[email protected] | 3641da6c | 2009-07-08 14:59:06 | [diff] [blame] | 18 | |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 19 | namespace { |
| 20 | |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 21 | enum class CommandKeyState : bool { |
| 22 | kUp, |
| 23 | kDown, |
| 24 | }; |
| 25 | enum class ShiftKeyState : bool { |
| 26 | kUp, |
| 27 | kDown, |
| 28 | }; |
| 29 | enum class OptionKeyState : bool { |
| 30 | kUp, |
| 31 | kDown, |
| 32 | }; |
| 33 | enum class ControlKeyState : bool { |
| 34 | kUp, |
| 35 | kDown, |
| 36 | }; |
| 37 | |
| 38 | int CommandForKeys(int vkey_code, |
| 39 | CommandKeyState command, |
| 40 | ShiftKeyState shift = ShiftKeyState::kUp, |
| 41 | OptionKeyState option = OptionKeyState::kUp, |
| 42 | ControlKeyState control = ControlKeyState::kUp) { |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 43 | NSUInteger modifier_flags = 0; |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 44 | if (command == CommandKeyState::kDown) |
Avi Drissman | 8be8111 | 2022-05-11 01:12:42 | [diff] [blame] | 45 | modifier_flags |= NSEventModifierFlagCommand; |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 46 | if (shift == ShiftKeyState::kDown) |
Avi Drissman | 8be8111 | 2022-05-11 01:12:42 | [diff] [blame] | 47 | modifier_flags |= NSEventModifierFlagShift; |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 48 | if (option == OptionKeyState::kDown) |
Avi Drissman | 8be8111 | 2022-05-11 01:12:42 | [diff] [blame] | 49 | modifier_flags |= NSEventModifierFlagOption; |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 50 | if (control == ControlKeyState::kDown) |
Avi Drissman | 8be8111 | 2022-05-11 01:12:42 | [diff] [blame] | 51 | modifier_flags |= NSEventModifierFlagControl; |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 52 | |
Elly Fong-Jones | 03312b6 | 2019-10-11 21:35:49 | [diff] [blame] | 53 | switch (vkey_code) { |
| 54 | case kVK_UpArrow: |
| 55 | case kVK_DownArrow: |
| 56 | case kVK_LeftArrow: |
| 57 | case kVK_RightArrow: |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 58 | // Docs say that this is set for numpad *and* arrow keys. |
| 59 | modifier_flags |= NSEventModifierFlagNumericPad; |
| 60 | [[fallthrough]]; |
| 61 | case kVK_Help: |
| 62 | case kVK_ForwardDelete: |
| 63 | case kVK_Home: |
| 64 | case kVK_End: |
| 65 | case kVK_PageUp: |
| 66 | case kVK_PageDown: |
| 67 | // Docs say that this is set for function keys *and* the cluster of six |
| 68 | // navigation keys in the center of the keyboard *and* arrow keys. |
| 69 | modifier_flags |= NSEventModifierFlagFunction; |
Elly Fong-Jones | 03312b6 | 2019-10-11 21:35:49 | [diff] [blame] | 70 | break; |
| 71 | default: |
| 72 | break; |
| 73 | } |
| 74 | |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 75 | unichar shifted_character; |
| 76 | unichar character; |
| 77 | int result = ui::MacKeyCodeForWindowsKeyCode( |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 78 | ui::KeyboardCodeFromKeyCode(vkey_code), modifier_flags, |
| 79 | &shifted_character, &character); |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 80 | DCHECK_NE(result, -1); |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 81 | |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 82 | NSEvent* event = [NSEvent |
Avi Drissman | 8be8111 | 2022-05-11 01:12:42 | [diff] [blame] | 83 | keyEventWithType:NSEventTypeKeyDown |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 84 | location:NSZeroPoint |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 85 | modifierFlags:modifier_flags |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 86 | timestamp:0.0 |
| 87 | windowNumber:0 |
| 88 | context:nil |
| 89 | characters:[NSString stringWithFormat:@"%C", character] |
| 90 | charactersIgnoringModifiers:[NSString |
| 91 | stringWithFormat:@"%C", shifted_character] |
| 92 | isARepeat:NO |
| 93 | keyCode:vkey_code]; |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 94 | |
erikchen | 41281cd | 2018-06-20 18:15:05 | [diff] [blame] | 95 | return CommandForKeyEvent(event).chrome_command; |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 96 | } |
| 97 | |
| 98 | } // namespace |
| 99 | |
| 100 | TEST(GlobalKeyboardShortcuts, BasicFunctionality) { |
[email protected] | 3641da6c | 2009-07-08 14:59:06 | [diff] [blame] | 101 | // Test that an invalid shortcut translates into an invalid command id. |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 102 | const int kInvalidCommandId = -1; |
| 103 | const int no_key_code = 0; |
| 104 | EXPECT_EQ( |
| 105 | kInvalidCommandId, |
| 106 | CommandForKeys(no_key_code, CommandKeyState::kUp, ShiftKeyState::kUp, |
| 107 | OptionKeyState::kUp, ControlKeyState::kUp)); |
[email protected] | 70be00a | 2009-07-08 23:40:08 | [diff] [blame] | 108 | |
[email protected] | 3641da6c | 2009-07-08 14:59:06 | [diff] [blame] | 109 | // Check that all known keyboard shortcuts return valid results. |
Erik Chen | 8f2f9568 | 2018-06-08 00:44:54 | [diff] [blame] | 110 | for (const auto& shortcut : GetShortcutsNotPresentInMainMenu()) { |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 111 | CommandKeyState command = |
| 112 | shortcut.command_key ? CommandKeyState::kDown : CommandKeyState::kUp; |
| 113 | ShiftKeyState shift = |
| 114 | shortcut.shift_key ? ShiftKeyState::kDown : ShiftKeyState::kUp; |
| 115 | OptionKeyState option = |
| 116 | shortcut.opt_key ? OptionKeyState::kDown : OptionKeyState::kUp; |
| 117 | ControlKeyState control = |
| 118 | shortcut.cntrl_key ? ControlKeyState::kDown : ControlKeyState::kUp; |
| 119 | |
| 120 | int cmd_num = |
| 121 | CommandForKeys(shortcut.vkey_code, command, shift, option, control); |
mblsha | cb9c6b9d | 2016-11-21 17:11:18 | [diff] [blame] | 122 | EXPECT_EQ(cmd_num, shortcut.chrome_command); |
[email protected] | 1d313b83 | 2009-10-09 01:26:20 | [diff] [blame] | 123 | } |
[email protected] | b7b0bcb | 2010-11-17 17:12:24 | [diff] [blame] | 124 | // Test that switching tabs triggers off keycodes and not characters (visible |
| 125 | // with the Italian keyboard layout). |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 126 | EXPECT_EQ( |
| 127 | IDC_SELECT_TAB_0, |
| 128 | CommandForKeys(kVK_ANSI_1, CommandKeyState::kDown, ShiftKeyState::kUp, |
| 129 | OptionKeyState::kUp, ControlKeyState::kUp)); |
[email protected] | b7b0bcb | 2010-11-17 17:12:24 | [diff] [blame] | 130 | } |
| 131 | |
| 132 | TEST(GlobalKeyboardShortcuts, KeypadNumberKeysMatch) { |
| 133 | // Test that the shortcuts that are generated by keypad number keys match the |
| 134 | // equivalent keys. |
| 135 | static const struct { |
| 136 | int keycode; |
| 137 | int keypad_keycode; |
| 138 | } equivalents[] = { |
| 139 | {kVK_ANSI_0, kVK_ANSI_Keypad0}, |
| 140 | {kVK_ANSI_1, kVK_ANSI_Keypad1}, |
| 141 | {kVK_ANSI_2, kVK_ANSI_Keypad2}, |
| 142 | {kVK_ANSI_3, kVK_ANSI_Keypad3}, |
| 143 | {kVK_ANSI_4, kVK_ANSI_Keypad4}, |
| 144 | {kVK_ANSI_5, kVK_ANSI_Keypad5}, |
| 145 | {kVK_ANSI_6, kVK_ANSI_Keypad6}, |
| 146 | {kVK_ANSI_7, kVK_ANSI_Keypad7}, |
| 147 | {kVK_ANSI_8, kVK_ANSI_Keypad8}, |
| 148 | {kVK_ANSI_9, kVK_ANSI_Keypad9}, |
| 149 | }; |
| 150 | |
erikchen | 008ab23a | 2018-08-09 02:06:39 | [diff] [blame] | 151 | // We only consider unshifted keys. A shifted numpad key gives a different |
| 152 | // keyEquivalent than a shifted number key. |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 153 | const ShiftKeyState shift = ShiftKeyState::kUp; |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 154 | for (auto equivalent : equivalents) { |
Jayson Adams | a76e9ec | 2022-01-14 19:12:33 | [diff] [blame] | 155 | for (CommandKeyState command : |
| 156 | {CommandKeyState::kUp, CommandKeyState::kDown}) { |
| 157 | for (OptionKeyState option : |
| 158 | {OptionKeyState::kUp, OptionKeyState::kDown}) { |
| 159 | for (ControlKeyState control : |
| 160 | {ControlKeyState::kUp, ControlKeyState::kDown}) { |
Avi Drissman | 329a222f | 2022-04-06 15:42:16 | [diff] [blame] | 161 | EXPECT_EQ(CommandForKeys(equivalent.keycode, command, shift, option, |
| 162 | control), |
| 163 | CommandForKeys(equivalent.keypad_keycode, command, shift, |
| 164 | option, control)); |
[email protected] | b7b0bcb | 2010-11-17 17:12:24 | [diff] [blame] | 165 | } |
| 166 | } |
| 167 | } |
| 168 | } |
[email protected] | 1d313b83 | 2009-10-09 01:26:20 | [diff] [blame] | 169 | } |