blob: ed2cba53f4c91a396602e06d8bea2ee08053cedb [file] [log] [blame]
[email protected]3641da6c2009-07-08 14:59:061// Copyright (c) 2009 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
Daniel Cheng7d9e3d52022-02-26 09:03:245#include "chrome/browser/global_keyboard_shortcuts_mac.h"
6
[email protected]92f5adfa2010-01-05 09:49:127#include <AppKit/NSEvent.h>
[email protected]1d313b832009-10-09 01:26:208#include <Carbon/Carbon.h>
avi6846aef2015-12-26 01:09:389#include <stddef.h>
Jayson Adams6bc96ee2022-01-15 00:03:2910
Jayson Adamsa76e9ec2022-01-14 19:12:3311#include <initializer_list>
[email protected]1d313b832009-10-09 01:26:2012
Hans Wennborgf6ad69c2020-06-18 18:02:3213#include "base/check_op.h"
[email protected]1a3aba82010-11-08 23:52:5414#include "chrome/app/chrome_command_ids.h"
[email protected]3641da6c2009-07-08 14:59:0615#include "testing/gtest/include/gtest/gtest.h"
Scott Violetb72577d2019-01-09 22:18:1816#include "ui/base/buildflags.h"
erikchen008ab23a2018-08-09 02:06:3917#include "ui/events/keycodes/keyboard_code_conversion_mac.h"
[email protected]3641da6c2009-07-08 14:59:0618
Erik Chen8f2f95682018-06-08 00:44:5419namespace {
20
Jayson Adamsa76e9ec2022-01-14 19:12:3321enum class CommandKeyState : bool {
22 kUp,
23 kDown,
24};
25enum class ShiftKeyState : bool {
26 kUp,
27 kDown,
28};
29enum class OptionKeyState : bool {
30 kUp,
31 kDown,
32};
33enum class ControlKeyState : bool {
34 kUp,
35 kDown,
36};
37
38int CommandForKeys(int vkey_code,
39 CommandKeyState command,
40 ShiftKeyState shift = ShiftKeyState::kUp,
41 OptionKeyState option = OptionKeyState::kUp,
42 ControlKeyState control = ControlKeyState::kUp) {
Erik Chen8f2f95682018-06-08 00:44:5443 NSUInteger modifierFlags = 0;
Jayson Adamsa76e9ec2022-01-14 19:12:3344 if (command == CommandKeyState::kDown)
Erik Chen8f2f95682018-06-08 00:44:5445 modifierFlags |= NSCommandKeyMask;
Jayson Adamsa76e9ec2022-01-14 19:12:3346 if (shift == ShiftKeyState::kDown)
Erik Chen8f2f95682018-06-08 00:44:5447 modifierFlags |= NSShiftKeyMask;
Jayson Adamsa76e9ec2022-01-14 19:12:3348 if (option == OptionKeyState::kDown)
Erik Chen8f2f95682018-06-08 00:44:5449 modifierFlags |= NSAlternateKeyMask;
Jayson Adamsa76e9ec2022-01-14 19:12:3350 if (control == ControlKeyState::kDown)
51 modifierFlags |= NSControlKeyMask;
Erik Chen8f2f95682018-06-08 00:44:5452
Elly Fong-Jones03312b62019-10-11 21:35:4953 switch (vkey_code) {
54 case kVK_UpArrow:
55 case kVK_DownArrow:
56 case kVK_LeftArrow:
57 case kVK_RightArrow:
58 // Docs say this is set whenever a key came from the numpad *or* the arrow
59 // keys.
60 modifierFlags |= NSEventModifierFlagNumericPad;
61 break;
62 default:
63 break;
64 }
65
erikchen008ab23a2018-08-09 02:06:3966 unichar shifted_character;
67 unichar character;
68 int result = ui::MacKeyCodeForWindowsKeyCode(
69 ui::KeyboardCodeFromKeyCode(vkey_code), modifierFlags, &shifted_character,
70 &character);
71 DCHECK_NE(result, -1);
Erik Chen8f2f95682018-06-08 00:44:5472
erikchen008ab23a2018-08-09 02:06:3973 NSEvent* event = [NSEvent
74 keyEventWithType:NSKeyDown
75 location:NSZeroPoint
76 modifierFlags:modifierFlags
77 timestamp:0.0
78 windowNumber:0
79 context:nil
80 characters:[NSString stringWithFormat:@"%C", character]
81 charactersIgnoringModifiers:[NSString
82 stringWithFormat:@"%C", shifted_character]
83 isARepeat:NO
84 keyCode:vkey_code];
Erik Chen8f2f95682018-06-08 00:44:5485
erikchen41281cd2018-06-20 18:15:0586 return CommandForKeyEvent(event).chrome_command;
Erik Chen8f2f95682018-06-08 00:44:5487}
88
89} // namespace
90
91TEST(GlobalKeyboardShortcuts, BasicFunctionality) {
[email protected]3641da6c2009-07-08 14:59:0692 // Test that an invalid shortcut translates into an invalid command id.
Jayson Adamsa76e9ec2022-01-14 19:12:3393 const int kInvalidCommandId = -1;
94 const int no_key_code = 0;
95 EXPECT_EQ(
96 kInvalidCommandId,
97 CommandForKeys(no_key_code, CommandKeyState::kUp, ShiftKeyState::kUp,
98 OptionKeyState::kUp, ControlKeyState::kUp));
[email protected]70be00a2009-07-08 23:40:0899
[email protected]3641da6c2009-07-08 14:59:06100 // Check that all known keyboard shortcuts return valid results.
Erik Chen8f2f95682018-06-08 00:44:54101 for (const auto& shortcut : GetShortcutsNotPresentInMainMenu()) {
Jayson Adamsa76e9ec2022-01-14 19:12:33102 CommandKeyState command =
103 shortcut.command_key ? CommandKeyState::kDown : CommandKeyState::kUp;
104 ShiftKeyState shift =
105 shortcut.shift_key ? ShiftKeyState::kDown : ShiftKeyState::kUp;
106 OptionKeyState option =
107 shortcut.opt_key ? OptionKeyState::kDown : OptionKeyState::kUp;
108 ControlKeyState control =
109 shortcut.cntrl_key ? ControlKeyState::kDown : ControlKeyState::kUp;
110
111 int cmd_num =
112 CommandForKeys(shortcut.vkey_code, command, shift, option, control);
mblshacb9c6b9d2016-11-21 17:11:18113 EXPECT_EQ(cmd_num, shortcut.chrome_command);
[email protected]1d313b832009-10-09 01:26:20114 }
[email protected]b7b0bcb2010-11-17 17:12:24115 // Test that switching tabs triggers off keycodes and not characters (visible
116 // with the Italian keyboard layout).
Jayson Adamsa76e9ec2022-01-14 19:12:33117 EXPECT_EQ(
118 IDC_SELECT_TAB_0,
119 CommandForKeys(kVK_ANSI_1, CommandKeyState::kDown, ShiftKeyState::kUp,
120 OptionKeyState::kUp, ControlKeyState::kUp));
[email protected]b7b0bcb2010-11-17 17:12:24121}
122
123TEST(GlobalKeyboardShortcuts, KeypadNumberKeysMatch) {
124 // Test that the shortcuts that are generated by keypad number keys match the
125 // equivalent keys.
126 static const struct {
127 int keycode;
128 int keypad_keycode;
129 } equivalents[] = {
130 {kVK_ANSI_0, kVK_ANSI_Keypad0},
131 {kVK_ANSI_1, kVK_ANSI_Keypad1},
132 {kVK_ANSI_2, kVK_ANSI_Keypad2},
133 {kVK_ANSI_3, kVK_ANSI_Keypad3},
134 {kVK_ANSI_4, kVK_ANSI_Keypad4},
135 {kVK_ANSI_5, kVK_ANSI_Keypad5},
136 {kVK_ANSI_6, kVK_ANSI_Keypad6},
137 {kVK_ANSI_7, kVK_ANSI_Keypad7},
138 {kVK_ANSI_8, kVK_ANSI_Keypad8},
139 {kVK_ANSI_9, kVK_ANSI_Keypad9},
140 };
141
erikchen008ab23a2018-08-09 02:06:39142 // We only consider unshifted keys. A shifted numpad key gives a different
143 // keyEquivalent than a shifted number key.
Jayson Adamsa76e9ec2022-01-14 19:12:33144 const ShiftKeyState shift = ShiftKeyState::kUp;
Daniel Cheng7d9e3d52022-02-26 09:03:24145 for (unsigned int i = 0; i < std::size(equivalents); ++i) {
Jayson Adamsa76e9ec2022-01-14 19:12:33146 for (CommandKeyState command :
147 {CommandKeyState::kUp, CommandKeyState::kDown}) {
148 for (OptionKeyState option :
149 {OptionKeyState::kUp, OptionKeyState::kDown}) {
150 for (ControlKeyState control :
151 {ControlKeyState::kUp, ControlKeyState::kDown}) {
152 EXPECT_EQ(CommandForKeys(equivalents[i].keycode, command, shift,
153 option, control),
154 CommandForKeys(equivalents[i].keypad_keycode, command,
155 shift, option, control));
[email protected]b7b0bcb2010-11-17 17:12:24156 }
157 }
158 }
159 }
[email protected]1d313b832009-10-09 01:26:20160}