[ruby-core:109644] [Ruby master Feature#13626] Add String#byteslice!
From:
"Eregon (Benoit Daloze)" <noreply@...>
Date:
2022-08-23 13:56:06 UTC
List:
ruby-core #109644
Issue #13626 has been updated by Eregon (Benoit Daloze). I think there is a misunderstand of what `byte*` methods are for. `byte*` methods are for dealing with byte indices and avoid the conversion between byte and character indices (which can be expensive for UTF-8). `byte*` methods are not "methods for BINARY strings". For BINARY strings it's fine/better to use the regular String methods since byte index=character index for BINARY and other fixed-width encodings. ---------------------------------------- Feature #13626: Add String#byteslice! https://bugs.ruby-lang.org/issues/13626#change-98868 * Author: ioquatix (Samuel Williams) * Status: Open * Priority: Normal ---------------------------------------- It's a common pattern in IO buffering, to read a part of a string while leaving the remainder. ~~~ # Consume only part of the read buffer: result = @read_buffer.byteslice(0, size) @read_buffer = @read_buffer.byteslice(size, @read_buffer.bytesize) ~~~ It would be nice if this code could be simplified to: ~~~ result = @read_buffer.byteslice!(size) ~~~ Additionally, this allows a significantly improved implementation by the interpreter. -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:[email protected]?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>