summaryloggraphiclog1graphiclog2commitcommitdifftreerefseditfork
rawpatchinlineside by side (parent: 3b27818)
rawpatchinlineside by side (parent: 3b27818)
| author | Yusuke Endoh <[email protected]> | |
| Wed, 4 Dec 2024 07:33:49 +0000 (4 16:33 +0900) | ||
| committer | Yusuke Endoh <[email protected]> | |
| Wed, 4 Dec 2024 08:12:26 +0000 (4 17:12 +0900) |
The functions dereference `*dead_entry` without a NULL check
| weakmap.c | patchblobblamehistory |
diff --git a/weakmap.c b/weakmap.c
--- a/weakmap.c
+++ b/weakmap.c
wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data)
{
VALUE **dead_entry = (VALUE **)data;
- if (dead_entry != NULL) {
- ruby_sized_xfree(*dead_entry, sizeof(VALUE));
- *dead_entry = NULL;
- }
+ ruby_sized_xfree(*dead_entry, sizeof(VALUE));
+ *dead_entry = NULL;
VALUE *key_ptr = (VALUE *)key;
wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error)
{
VALUE **dead_entry = (VALUE **)data;
- if (dead_entry != NULL) {
- ruby_sized_xfree(*dead_entry, sizeof(VALUE));
- *dead_entry = NULL;
- }
+ ruby_sized_xfree(*dead_entry, sizeof(VALUE));
+ *dead_entry = NULL;
VALUE *key_ptr = (VALUE *)key;