From: Yusuke Endoh <mame@ruby-lang.org>
Date: Wed, 4 Dec 2024 07:33:49 +0000 (+0900)
Subject: Remove meaningless NULL checks
X-Git-Tag: v3_4_0_rc1~161
X-Git-Url: https://repo.or.cz/ruby.git/commitdiff_plain/d2c55e33fb4cf22859ef5c70fe532342d7bb2c62

Remove meaningless NULL checks

The functions dereference `*dead_entry` without a NULL check
---

diff --git a/weakmap.c b/weakmap.c
index 32acf2d6ec..f8a6ae3747 100644
--- a/weakmap.c
+++ b/weakmap.c
@@ -636,10 +636,8 @@ static int
 wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data)
 {
     VALUE **dead_entry = (VALUE **)data;
-    if (dead_entry != NULL) {
-        ruby_sized_xfree(*dead_entry, sizeof(VALUE));
-        *dead_entry = NULL;
-    }
+    ruby_sized_xfree(*dead_entry, sizeof(VALUE));
+    *dead_entry = NULL;
 
     VALUE *key_ptr = (VALUE *)key;
 
@@ -702,10 +700,8 @@ static int
 wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error)
 {
     VALUE **dead_entry = (VALUE **)data;
-    if (dead_entry != NULL) {
-        ruby_sized_xfree(*dead_entry, sizeof(VALUE));
-        *dead_entry = NULL;
-    }
+    ruby_sized_xfree(*dead_entry, sizeof(VALUE));
+    *dead_entry = NULL;
 
     VALUE *key_ptr = (VALUE *)key;