OverflowError: signed integer is greater than maximum

[Ryan J Ollos]

From the logs:

2016-02-15 16:54:12,734 Trac[main] ERROR: Internal Server Error: <RequestWithSession "GET '/timeline?daysback=7&authors=&from=2010-12-122121121121212.1'">, referrer None
Traceback (most recent call last):
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/web/main.py", line 554, in _dispatch_request
    dispatcher.dispatch(req)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/web/main.py", line 247, in dispatch
    resp = chosen_handler.process_request(req)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/timeline/web_ui.py", line 115, in process_request
    precisedate = user_time(req, parse_date, reqfromdate)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/util/datefmt.py", line 793, in user_time
    return func(*args, **kwargs)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/util/datefmt.py", line 518, in parse_date
    dt = _i18n_parse_date(text, tzinfo, locale)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/util/datefmt.py", line 646, in _i18n_parse_date
    month_names, tzinfo)
  File "/var/www/bugs.jquery.com/private/pve/local/lib/python2.7/site-packages/trac/util/datefmt.py", line 702, in _i18n_parse_date_0
    t = tzinfo.localize(datetime(*(values[k] for k in 'yMdhms')))
OverflowError: signed integer is greater than maximum

Related to #12007.

[Jun Omae]

Good catch. parse_date() should catch OverflowError.

>>> parse_date('Jan 2147483647, 2016', locale='en_US')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 477, in parse_date
    date=text, hint=hint), _('Invalid Date'))
trac.core.TracError: "2147483647 Jan, 2016" is an invalid date, or the date format is not known. Try "MMM d, yyyy" instead.
>>> parse_date('Jan 2147483648, 2016', locale='en_US')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 458, in parse_date
    dt = _i18n_parse_date(text, tzinfo, locale)
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 571, in _i18n_parse_date
    month_names, tzinfo)
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 627, in _i18n_parse_date_0
    t = tzinfo.localize(datetime(*(values[k] for k in 'yMdhms')))
OverflowError: signed integer is greater than maximum
>>> parse_date('Jan 9223372036854775808, 2016', locale='en_US')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 458, in parse_date
    dt = _i18n_parse_date(text, tzinfo, locale)
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 571, in _i18n_parse_date
    month_names, tzinfo)
  File "/venv/trac/1.0/lib/python2.5/site-packages/trac/util/datefmt.py", line 627, in _i18n_parse_date_0
    t = tzinfo.localize(datetime(*(values[k] for k in 'yMdhms')))
OverflowError: long int too large to convert to int

[Jun Omae]

Proposed changes in log:jomae.git@t12372 ([c8ade1cba/jomae.git]).

[Ryan J Ollos]

Changes look good. Thanks for fixing!

[Jun Omae]

Thanks for the review! Also, added unit tests for #12007 ([9b9c8a56e/jomae.git]).

[Jun Omae]

Committed in [14594] and merged to trunk in [14595].