diff options
Diffstat (limited to 'spec/ruby/library/csv')
42 files changed, 281 insertions, 407 deletions
diff --git a/spec/ruby/library/csv/basicwriter/close_on_terminate_spec.rb b/spec/ruby/library/csv/basicwriter/close_on_terminate_spec.rb index d3f667c602..599e640624 100644 --- a/spec/ruby/library/csv/basicwriter/close_on_terminate_spec.rb +++ b/spec/ruby/library/csv/basicwriter/close_on_terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::BasicWriter#close_on_terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::BasicWriter#close_on_terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/basicwriter/initialize_spec.rb b/spec/ruby/library/csv/basicwriter/initialize_spec.rb index af86bc177b..2c13c93f2e 100644 --- a/spec/ruby/library/csv/basicwriter/initialize_spec.rb +++ b/spec/ruby/library/csv/basicwriter/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::BasicWriter#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::BasicWriter#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/basicwriter/terminate_spec.rb b/spec/ruby/library/csv/basicwriter/terminate_spec.rb index 5396295a61..8c53db3f0b 100644 --- a/spec/ruby/library/csv/basicwriter/terminate_spec.rb +++ b/spec/ruby/library/csv/basicwriter/terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::BasicWriter#terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::BasicWriter#terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/cell/data_spec.rb b/spec/ruby/library/csv/cell/data_spec.rb index 14f49ace96..aa034b0b62 100644 --- a/spec/ruby/library/csv/cell/data_spec.rb +++ b/spec/ruby/library/csv/cell/data_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Cell#data" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Cell#data" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/cell/initialize_spec.rb b/spec/ruby/library/csv/cell/initialize_spec.rb index ff3ac55470..c9e506676c 100644 --- a/spec/ruby/library/csv/cell/initialize_spec.rb +++ b/spec/ruby/library/csv/cell/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Cell#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Cell#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/foreach_spec.rb b/spec/ruby/library/csv/foreach_spec.rb index c8aa1b8009..36b3cd152f 100644 --- a/spec/ruby/library/csv/foreach_spec.rb +++ b/spec/ruby/library/csv/foreach_spec.rb @@ -1,9 +1,6 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV.foreach" do - it "needs to be reviewed for spec completeness" - end +describe "CSV.foreach" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/generate_line_spec.rb b/spec/ruby/library/csv/generate_line_spec.rb index 0830bbdb63..656365b109 100644 --- a/spec/ruby/library/csv/generate_line_spec.rb +++ b/spec/ruby/library/csv/generate_line_spec.rb @@ -1,33 +1,30 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' +describe "CSV.generate_line" do - describe "CSV.generate_line" do - - it "generates an empty string" do - result = CSV.generate_line([]) - result.should == "\n" - end + it "generates an empty string" do + result = CSV.generate_line([]) + result.should == "\n" + end - it "generates the string 'foo,bar'" do - result = CSV.generate_line(["foo", "bar"]) - result.should == "foo,bar\n" - end + it "generates the string 'foo,bar'" do + result = CSV.generate_line(["foo", "bar"]) + result.should == "foo,bar\n" + end - it "generates the string 'foo;bar'" do - result = CSV.generate_line(["foo", "bar"], col_sep: ?;) - result.should == "foo;bar\n" - end + it "generates the string 'foo;bar'" do + result = CSV.generate_line(["foo", "bar"], col_sep: ?;) + result.should == "foo;bar\n" + end - it "generates the string 'foo,,bar'" do - result = CSV.generate_line(["foo", nil, "bar"]) - result.should == "foo,,bar\n" - end + it "generates the string 'foo,,bar'" do + result = CSV.generate_line(["foo", nil, "bar"]) + result.should == "foo,,bar\n" + end - it "generates the string 'foo;;bar'" do - result = CSV.generate_line(["foo", nil, "bar"], col_sep: ?;) - result.should == "foo;;bar\n" - end + it "generates the string 'foo;;bar'" do + result = CSV.generate_line(["foo", nil, "bar"], col_sep: ?;) + result.should == "foo;;bar\n" end end diff --git a/spec/ruby/library/csv/generate_row_spec.rb b/spec/ruby/library/csv/generate_row_spec.rb index aff5332a9e..79dfc34000 100644 --- a/spec/ruby/library/csv/generate_row_spec.rb +++ b/spec/ruby/library/csv/generate_row_spec.rb @@ -1,9 +1,6 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV.generate_row" do - it "needs to be reviewed for spec completeness" - end +describe "CSV.generate_row" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/generate_spec.rb b/spec/ruby/library/csv/generate_spec.rb index de476d437f..0a1e3d9604 100644 --- a/spec/ruby/library/csv/generate_spec.rb +++ b/spec/ruby/library/csv/generate_spec.rb @@ -1,35 +1,32 @@ require_relative '../../spec_helper' +require 'csv' +require 'tempfile' -ruby_version_is ""..."3.4" do - require 'csv' - require 'tempfile' +describe "CSV.generate" do - describe "CSV.generate" do - - it "returns CSV string" do - csv_str = CSV.generate do |csv| - csv.add_row [1, 2, 3] - csv << [4, 5, 6] - end - csv_str.should == "1,2,3\n4,5,6\n" + it "returns CSV string" do + csv_str = CSV.generate do |csv| + csv.add_row [1, 2, 3] + csv << [4, 5, 6] end + csv_str.should == "1,2,3\n4,5,6\n" + end - it "accepts a col separator" do - csv_str = CSV.generate(col_sep: ";") do |csv| - csv.add_row [1, 2, 3] - csv << [4, 5, 6] - end - csv_str.should == "1;2;3\n4;5;6\n" + it "accepts a col separator" do + csv_str = CSV.generate(col_sep: ";") do |csv| + csv.add_row [1, 2, 3] + csv << [4, 5, 6] end + csv_str.should == "1;2;3\n4;5;6\n" + end - it "appends and returns the argument itself" do - str = "" - csv_str = CSV.generate(str) do |csv| - csv.add_row [1, 2, 3] - csv << [4, 5, 6] - end - csv_str.should equal str - str.should == "1,2,3\n4,5,6\n" + it "appends and returns the argument itself" do + str = "" + csv_str = CSV.generate(str) do |csv| + csv.add_row [1, 2, 3] + csv << [4, 5, 6] end + csv_str.should equal str + str.should == "1,2,3\n4,5,6\n" end end diff --git a/spec/ruby/library/csv/iobuf/close_spec.rb b/spec/ruby/library/csv/iobuf/close_spec.rb index 5711a816ec..e2fda86080 100644 --- a/spec/ruby/library/csv/iobuf/close_spec.rb +++ b/spec/ruby/library/csv/iobuf/close_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOBuf#close" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOBuf#close" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/iobuf/initialize_spec.rb b/spec/ruby/library/csv/iobuf/initialize_spec.rb index 0073bd4481..f08e82548a 100644 --- a/spec/ruby/library/csv/iobuf/initialize_spec.rb +++ b/spec/ruby/library/csv/iobuf/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOBuf#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOBuf#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/iobuf/read_spec.rb b/spec/ruby/library/csv/iobuf/read_spec.rb index e74d8178dd..b45334ee2a 100644 --- a/spec/ruby/library/csv/iobuf/read_spec.rb +++ b/spec/ruby/library/csv/iobuf/read_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOBuf#read" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOBuf#read" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/iobuf/terminate_spec.rb b/spec/ruby/library/csv/iobuf/terminate_spec.rb index e4ab00bc4f..69289e960c 100644 --- a/spec/ruby/library/csv/iobuf/terminate_spec.rb +++ b/spec/ruby/library/csv/iobuf/terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOBuf#terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOBuf#terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/ioreader/close_on_terminate_spec.rb b/spec/ruby/library/csv/ioreader/close_on_terminate_spec.rb index 25026091aa..4887ade1a1 100644 --- a/spec/ruby/library/csv/ioreader/close_on_terminate_spec.rb +++ b/spec/ruby/library/csv/ioreader/close_on_terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOReader#close_on_terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOReader#close_on_terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/ioreader/get_row_spec.rb b/spec/ruby/library/csv/ioreader/get_row_spec.rb index c2258738d1..5fd2178b1b 100644 --- a/spec/ruby/library/csv/ioreader/get_row_spec.rb +++ b/spec/ruby/library/csv/ioreader/get_row_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOReader#get_row" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOReader#get_row" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/ioreader/initialize_spec.rb b/spec/ruby/library/csv/ioreader/initialize_spec.rb index 4f3a75cc8e..4e8c0964df 100644 --- a/spec/ruby/library/csv/ioreader/initialize_spec.rb +++ b/spec/ruby/library/csv/ioreader/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOReader#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOReader#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/ioreader/terminate_spec.rb b/spec/ruby/library/csv/ioreader/terminate_spec.rb index 2403d02a9f..676cd03a0f 100644 --- a/spec/ruby/library/csv/ioreader/terminate_spec.rb +++ b/spec/ruby/library/csv/ioreader/terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::IOReader#terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::IOReader#terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/liberal_parsing_spec.rb b/spec/ruby/library/csv/liberal_parsing_spec.rb index d344229d5b..9878658027 100644 --- a/spec/ruby/library/csv/liberal_parsing_spec.rb +++ b/spec/ruby/library/csv/liberal_parsing_spec.rb @@ -1,22 +1,19 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV#liberal_parsing?" do - it "returns true if illegal input is handled" do - csv = CSV.new("", liberal_parsing: true) - csv.should.liberal_parsing? - end +describe "CSV#liberal_parsing?" do + it "returns true if illegal input is handled" do + csv = CSV.new("", liberal_parsing: true) + csv.should.liberal_parsing? + end - it "returns false if illegal input is not handled" do - csv = CSV.new("", liberal_parsing: false) - csv.should_not.liberal_parsing? - end + it "returns false if illegal input is not handled" do + csv = CSV.new("", liberal_parsing: false) + csv.should_not.liberal_parsing? + end - it "returns false by default" do - csv = CSV.new("") - csv.should_not.liberal_parsing? - end + it "returns false by default" do + csv = CSV.new("") + csv.should_not.liberal_parsing? end end diff --git a/spec/ruby/library/csv/open_spec.rb b/spec/ruby/library/csv/open_spec.rb index 4b5f934e52..2d310cda3e 100644 --- a/spec/ruby/library/csv/open_spec.rb +++ b/spec/ruby/library/csv/open_spec.rb @@ -1,9 +1,6 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV.open" do - it "needs to be reviewed for spec completeness" - end +describe "CSV.open" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/parse_spec.rb b/spec/ruby/library/csv/parse_spec.rb index 921ee0648d..ef5d4ea3ca 100644 --- a/spec/ruby/library/csv/parse_spec.rb +++ b/spec/ruby/library/csv/parse_spec.rb @@ -1,96 +1,93 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV.parse" do - - it "parses '' into []" do - result = CSV.parse '' - result.should be_kind_of(Array) - result.should == [] - end - - it "parses '\n' into [[]]" do - result = CSV.parse "\n" - result.should == [[]] - end - - it "parses 'foo' into [['foo']]" do - result = CSV.parse 'foo' - result.should == [['foo']] - end - - it "parses 'foo,bar,baz' into [['foo','bar','baz']]" do - result = CSV.parse 'foo,bar,baz' - result.should == [['foo','bar','baz']] - end - - it "parses 'foo,baz' into [[foo,nil,baz]]" do - result = CSV.parse 'foo,,baz' - result.should == [['foo',nil,'baz']] - end - - it "parses '\nfoo' into [[],['foo']]" do - result = CSV.parse "\nfoo" - result.should == [[],['foo']] - end - - it "parses 'foo\n' into [['foo']]" do - result = CSV.parse "foo\n" - result.should == [['foo']] - end - - it "parses 'foo\nbar' into [['foo'],['bar']]" do - result = CSV.parse "foo\nbar" - result.should == [['foo'],['bar']] - end - - it "parses 'foo,bar\nbaz,quz' into [['foo','bar'],['baz','quz']]" do - result = CSV.parse "foo,bar\nbaz,quz" - result.should == [['foo','bar'],['baz','quz']] - end - - it "parses 'foo,bar'\nbaz' into [['foo','bar'],['baz']]" do - result = CSV.parse "foo,bar\nbaz" - result.should == [['foo','bar'],['baz']] - end - - it "parses 'foo\nbar,baz' into [['foo'],['bar','baz']]" do - result = CSV.parse "foo\nbar,baz" - result.should == [['foo'],['bar','baz']] - end - - it "parses '\n\nbar' into [[],[],'bar']]" do - result = CSV.parse "\n\nbar" - result.should == [[],[],['bar']] - end - - it "parses 'foo' into [['foo']] with a separator of ;" do - result = CSV.parse "foo", col_sep: ?; - result.should == [['foo']] - end - - it "parses 'foo;bar' into [['foo','bar']] with a separator of ;" do - result = CSV.parse "foo;bar", col_sep: ?; - result.should == [['foo','bar']] - end - - it "parses 'foo;bar\nbaz;quz' into [['foo','bar'],['baz','quz']] with a separator of ;" do - result = CSV.parse "foo;bar\nbaz;quz", col_sep: ?; - result.should == [['foo','bar'],['baz','quz']] - end - - it "raises CSV::MalformedCSVError exception if input is illegal" do - -> { - CSV.parse('"quoted" field') - }.should raise_error(CSV::MalformedCSVError) - end - - it "handles illegal input with the liberal_parsing option" do - illegal_input = '"Johnson, Dwayne",Dwayne "The Rock" Johnson' - result = CSV.parse(illegal_input, liberal_parsing: true) - result.should == [["Johnson, Dwayne", 'Dwayne "The Rock" Johnson']] - end +describe "CSV.parse" do + + it "parses '' into []" do + result = CSV.parse '' + result.should be_kind_of(Array) + result.should == [] + end + + it "parses '\n' into [[]]" do + result = CSV.parse "\n" + result.should == [[]] + end + + it "parses 'foo' into [['foo']]" do + result = CSV.parse 'foo' + result.should == [['foo']] + end + + it "parses 'foo,bar,baz' into [['foo','bar','baz']]" do + result = CSV.parse 'foo,bar,baz' + result.should == [['foo','bar','baz']] + end + + it "parses 'foo,baz' into [[foo,nil,baz]]" do + result = CSV.parse 'foo,,baz' + result.should == [['foo',nil,'baz']] + end + + it "parses '\nfoo' into [[],['foo']]" do + result = CSV.parse "\nfoo" + result.should == [[],['foo']] + end + + it "parses 'foo\n' into [['foo']]" do + result = CSV.parse "foo\n" + result.should == [['foo']] + end + + it "parses 'foo\nbar' into [['foo'],['bar']]" do + result = CSV.parse "foo\nbar" + result.should == [['foo'],['bar']] + end + + it "parses 'foo,bar\nbaz,quz' into [['foo','bar'],['baz','quz']]" do + result = CSV.parse "foo,bar\nbaz,quz" + result.should == [['foo','bar'],['baz','quz']] + end + + it "parses 'foo,bar'\nbaz' into [['foo','bar'],['baz']]" do + result = CSV.parse "foo,bar\nbaz" + result.should == [['foo','bar'],['baz']] + end + + it "parses 'foo\nbar,baz' into [['foo'],['bar','baz']]" do + result = CSV.parse "foo\nbar,baz" + result.should == [['foo'],['bar','baz']] + end + + it "parses '\n\nbar' into [[],[],'bar']]" do + result = CSV.parse "\n\nbar" + result.should == [[],[],['bar']] + end + + it "parses 'foo' into [['foo']] with a separator of ;" do + result = CSV.parse "foo", col_sep: ?; + result.should == [['foo']] + end + + it "parses 'foo;bar' into [['foo','bar']] with a separator of ;" do + result = CSV.parse "foo;bar", col_sep: ?; + result.should == [['foo','bar']] + end + + it "parses 'foo;bar\nbaz;quz' into [['foo','bar'],['baz','quz']] with a separator of ;" do + result = CSV.parse "foo;bar\nbaz;quz", col_sep: ?; + result.should == [['foo','bar'],['baz','quz']] + end + + it "raises CSV::MalformedCSVError exception if input is illegal" do + -> { + CSV.parse('"quoted" field') + }.should raise_error(CSV::MalformedCSVError) + end + + it "handles illegal input with the liberal_parsing option" do + illegal_input = '"Johnson, Dwayne",Dwayne "The Rock" Johnson' + result = CSV.parse(illegal_input, liberal_parsing: true) + result.should == [["Johnson, Dwayne", 'Dwayne "The Rock" Johnson']] end end diff --git a/spec/ruby/library/csv/read_spec.rb b/spec/ruby/library/csv/read_spec.rb index e455a40f73..2e6bb65d56 100644 --- a/spec/ruby/library/csv/read_spec.rb +++ b/spec/ruby/library/csv/read_spec.rb @@ -1,9 +1,6 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV.read" do - it "needs to be reviewed for spec completeness" - end +describe "CSV.read" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/readlines_spec.rb b/spec/ruby/library/csv/readlines_spec.rb index 9ca0859252..14dea34381 100644 --- a/spec/ruby/library/csv/readlines_spec.rb +++ b/spec/ruby/library/csv/readlines_spec.rb @@ -1,38 +1,35 @@ require_relative '../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' +describe "CSV.readlines" do + it "needs to be reviewed for spec completeness" +end - describe "CSV.readlines" do - it "needs to be reviewed for spec completeness" +describe "CSV#readlines" do + it "returns an Array of Array containing each element in a one-line CSV file" do + file = CSV.new "a, b, c" + file.readlines.should == [["a", " b", " c"]] end - describe "CSV#readlines" do - it "returns an Array of Array containing each element in a one-line CSV file" do - file = CSV.new "a, b, c" - file.readlines.should == [["a", " b", " c"]] - end - - it "returns an Array of Arrays containing each element in a multi-line CSV file" do - file = CSV.new "a, b, c\nd, e, f" - file.readlines.should == [["a", " b", " c"], ["d", " e", " f"]] - end + it "returns an Array of Arrays containing each element in a multi-line CSV file" do + file = CSV.new "a, b, c\nd, e, f" + file.readlines.should == [["a", " b", " c"], ["d", " e", " f"]] + end - it "returns nil for a missing value" do - file = CSV.new "a,, b, c" - file.readlines.should == [["a", nil, " b", " c"]] - end + it "returns nil for a missing value" do + file = CSV.new "a,, b, c" + file.readlines.should == [["a", nil, " b", " c"]] + end - it "raises CSV::MalformedCSVError exception if input is illegal" do - csv = CSV.new('"quoted" field') - -> { csv.readlines }.should raise_error(CSV::MalformedCSVError) - end + it "raises CSV::MalformedCSVError exception if input is illegal" do + csv = CSV.new('"quoted" field') + -> { csv.readlines }.should raise_error(CSV::MalformedCSVError) + end - it "handles illegal input with the liberal_parsing option" do - illegal_input = '"Johnson, Dwayne",Dwayne "The Rock" Johnson' - csv = CSV.new(illegal_input, liberal_parsing: true) - result = csv.readlines - result.should == [["Johnson, Dwayne", 'Dwayne "The Rock" Johnson']] - end + it "handles illegal input with the liberal_parsing option" do + illegal_input = '"Johnson, Dwayne",Dwayne "The Rock" Johnson' + csv = CSV.new(illegal_input, liberal_parsing: true) + result = csv.readlines + result.should == [["Johnson, Dwayne", 'Dwayne "The Rock" Johnson']] end end diff --git a/spec/ruby/library/csv/streambuf/add_buf_spec.rb b/spec/ruby/library/csv/streambuf/add_buf_spec.rb index 42a9eb68be..58c530c500 100644 --- a/spec/ruby/library/csv/streambuf/add_buf_spec.rb +++ b/spec/ruby/library/csv/streambuf/add_buf_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#add_buf" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#add_buf" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/buf_size_spec.rb b/spec/ruby/library/csv/streambuf/buf_size_spec.rb index 9a9d34bdef..1793c8b65e 100644 --- a/spec/ruby/library/csv/streambuf/buf_size_spec.rb +++ b/spec/ruby/library/csv/streambuf/buf_size_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#buf_size" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#buf_size" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/drop_spec.rb b/spec/ruby/library/csv/streambuf/drop_spec.rb index befe0da2f8..448f0a2196 100644 --- a/spec/ruby/library/csv/streambuf/drop_spec.rb +++ b/spec/ruby/library/csv/streambuf/drop_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#drop" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#drop" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/element_reference_spec.rb b/spec/ruby/library/csv/streambuf/element_reference_spec.rb index 5ff42beeee..5a75901830 100644 --- a/spec/ruby/library/csv/streambuf/element_reference_spec.rb +++ b/spec/ruby/library/csv/streambuf/element_reference_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#[]" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#[]" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/get_spec.rb b/spec/ruby/library/csv/streambuf/get_spec.rb index 0aa5e72e8f..2255e55e91 100644 --- a/spec/ruby/library/csv/streambuf/get_spec.rb +++ b/spec/ruby/library/csv/streambuf/get_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#get" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#get" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/idx_is_eos_spec.rb b/spec/ruby/library/csv/streambuf/idx_is_eos_spec.rb index f38cb7d8f8..563b8b2d4a 100644 --- a/spec/ruby/library/csv/streambuf/idx_is_eos_spec.rb +++ b/spec/ruby/library/csv/streambuf/idx_is_eos_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#idx_is_eos?" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#idx_is_eos?" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/initialize_spec.rb b/spec/ruby/library/csv/streambuf/initialize_spec.rb index 3655b02e25..1273c98094 100644 --- a/spec/ruby/library/csv/streambuf/initialize_spec.rb +++ b/spec/ruby/library/csv/streambuf/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/is_eos_spec.rb b/spec/ruby/library/csv/streambuf/is_eos_spec.rb index 9891536fea..a0a3c1e0b0 100644 --- a/spec/ruby/library/csv/streambuf/is_eos_spec.rb +++ b/spec/ruby/library/csv/streambuf/is_eos_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#is_eos?" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#is_eos?" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/read_spec.rb b/spec/ruby/library/csv/streambuf/read_spec.rb index 7a82d0d13d..cf98c53409 100644 --- a/spec/ruby/library/csv/streambuf/read_spec.rb +++ b/spec/ruby/library/csv/streambuf/read_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#read" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#read" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/rel_buf_spec.rb b/spec/ruby/library/csv/streambuf/rel_buf_spec.rb index 2994f5c950..548e347200 100644 --- a/spec/ruby/library/csv/streambuf/rel_buf_spec.rb +++ b/spec/ruby/library/csv/streambuf/rel_buf_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#rel_buf" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#rel_buf" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/streambuf/terminate_spec.rb b/spec/ruby/library/csv/streambuf/terminate_spec.rb index e720d83703..247b33184a 100644 --- a/spec/ruby/library/csv/streambuf/terminate_spec.rb +++ b/spec/ruby/library/csv/streambuf/terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StreamBuf#terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StreamBuf#terminate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/stringreader/get_row_spec.rb b/spec/ruby/library/csv/stringreader/get_row_spec.rb index b4a13cf38a..5cc3447061 100644 --- a/spec/ruby/library/csv/stringreader/get_row_spec.rb +++ b/spec/ruby/library/csv/stringreader/get_row_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StringReader#get_row" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StringReader#get_row" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/stringreader/initialize_spec.rb b/spec/ruby/library/csv/stringreader/initialize_spec.rb index 2c71d8a8b8..4e3634847e 100644 --- a/spec/ruby/library/csv/stringreader/initialize_spec.rb +++ b/spec/ruby/library/csv/stringreader/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::StringReader#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::StringReader#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/add_row_spec.rb b/spec/ruby/library/csv/writer/add_row_spec.rb index 27af76a637..2f074b45db 100644 --- a/spec/ruby/library/csv/writer/add_row_spec.rb +++ b/spec/ruby/library/csv/writer/add_row_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer#add_row" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer#add_row" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/append_spec.rb b/spec/ruby/library/csv/writer/append_spec.rb index 1c968e2b97..4e1f6728c2 100644 --- a/spec/ruby/library/csv/writer/append_spec.rb +++ b/spec/ruby/library/csv/writer/append_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer#<<" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer#<<" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/close_spec.rb b/spec/ruby/library/csv/writer/close_spec.rb index 65292dc4d0..1a87094bb7 100644 --- a/spec/ruby/library/csv/writer/close_spec.rb +++ b/spec/ruby/library/csv/writer/close_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer#close" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer#close" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/create_spec.rb b/spec/ruby/library/csv/writer/create_spec.rb index 0af9f44ff4..a4514d5578 100644 --- a/spec/ruby/library/csv/writer/create_spec.rb +++ b/spec/ruby/library/csv/writer/create_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer.create" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer.create" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/generate_spec.rb b/spec/ruby/library/csv/writer/generate_spec.rb index 8200ae566d..6ea9161777 100644 --- a/spec/ruby/library/csv/writer/generate_spec.rb +++ b/spec/ruby/library/csv/writer/generate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer.generate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer.generate" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/initialize_spec.rb b/spec/ruby/library/csv/writer/initialize_spec.rb index 574f39978a..6bba8f8d0a 100644 --- a/spec/ruby/library/csv/writer/initialize_spec.rb +++ b/spec/ruby/library/csv/writer/initialize_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer#initialize" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer#initialize" do + it "needs to be reviewed for spec completeness" end diff --git a/spec/ruby/library/csv/writer/terminate_spec.rb b/spec/ruby/library/csv/writer/terminate_spec.rb index 56b78e1088..77136dd018 100644 --- a/spec/ruby/library/csv/writer/terminate_spec.rb +++ b/spec/ruby/library/csv/writer/terminate_spec.rb @@ -1,9 +1,6 @@ require_relative '../../../spec_helper' +require 'csv' -ruby_version_is ""..."3.4" do - require 'csv' - - describe "CSV::Writer#terminate" do - it "needs to be reviewed for spec completeness" - end +describe "CSV::Writer#terminate" do + it "needs to be reviewed for spec completeness" end |