diff options
author | Stan Lo <[email protected]> | 2024-04-02 21:41:40 +0100 |
---|---|---|
committer | git <[email protected]> | 2024-04-12 13:55:35 +0000 |
commit | 0924ff2d390084922fbcebada20b968fa3e8238c (patch) | |
tree | 312413d4a145a8bac53ee358d34351225af61b65 /test | |
parent | abd05c848f437405e10410ded2a3d666e1b9bba5 (diff) |
[ruby/prism] Fix parser translation's heredoc whitespace calculation
Given this example:
```rb
<<~HEREDOC
#{x}
HEREDOC
```
Both the parser gem and Prism's translation layer would generate the following AST:
```
s(:dstr,
s(:begin,
s(:int, 1)),
s(:str, " a\n"))
```
However, the parser gem inserts a empty string node into this node's location, like:
```
<Parser::Source::Map::Heredoc:0x0000000104ce73b8
@expression=#<Parser::Source::Range (string) 0...10>,
@heredoc_body=#<Parser::Source::Range (string) 11...20>,
@heredoc_end=#<Parser::Source::Range (string) 20...27>,
@node=s(:dstr,
s(:str, ""),
s(:begin,
s(:int, 1)),
s(:str, " a\n"))>
```
This is required to calculate the correct whitespace for the heredoc body.
We need to adjust the translation layer to account for this.
With this fix, we also won't need to ignore the tilde heredoc fixture anymore.
https://github.com/ruby/prism/commit/e7372e3ba5
Diffstat (limited to 'test')
-rw-r--r-- | test/prism/parser_test.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/prism/parser_test.rb b/test/prism/parser_test.rb index d60def5a47..79b65cf75b 100644 --- a/test/prism/parser_test.rb +++ b/test/prism/parser_test.rb @@ -59,7 +59,6 @@ module Prism "regex_char_width.txt", "spanning_heredoc.txt", "spanning_heredoc_newlines.txt", - "tilde_heredocs.txt", "unescaping.txt" ] @@ -76,6 +75,7 @@ module Prism "indented_file_end.txt", "methods.txt", "strings.txt", + "tilde_heredocs.txt", "xstring_with_backslash.txt" ] |