diff options
| author | schneems <[email protected]> | 2022-11-25 16:26:43 -0600 |
|---|---|---|
| committer | Nobuyoshi Nakada <[email protected]> | 2022-11-28 20:55:41 +0900 |
| commit | f64ba0fadd97adbd7cb8171fc8aa010b829a7185 (patch) | |
| tree | bbec9f541b81939dbdbe1da7575fc2a6adb0c121 /spec/syntax_suggest/unit/api_spec.rb | |
| parent | 4d51a0b495262073a8c1c0c9d7f276c4e6260688 (diff) | |
[ruby/syntax_suggest] Do not output "Syntax OK" when there's an error
Due to a problem with ripper we do not recognize `break` as invalid code. It's confusing that "Syntax OK" is output in that case.
When there's no syntax error, the algorithm should not say anything. The exception is in the CLI and that's for compatibility with `ruby -wc`
```
$ cat /tmp/break.rb
break
⛄️ 3.1.2 🚀 /Users/rschneeman/Documents/projects/syntax_suggest (schneems/no-syntax-not-okay-break)
$ ruby -wc /tmp/break.rb
Syntax OK
```
> Note that this is invalid, running this code will raise a Syntax error.
```
$ exe/syntax_suggest /tmp/break.rb
Syntax OK
```
Close https://github.com/ruby/syntax_suggest/pull/157
https://github.com/ruby/syntax_suggest/commit/d7bd8f03a2
Diffstat (limited to 'spec/syntax_suggest/unit/api_spec.rb')
| -rw-r--r-- | spec/syntax_suggest/unit/api_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/syntax_suggest/unit/api_spec.rb b/spec/syntax_suggest/unit/api_spec.rb index 21df86bb3e..006e26fd22 100644 --- a/spec/syntax_suggest/unit/api_spec.rb +++ b/spec/syntax_suggest/unit/api_spec.rb @@ -25,7 +25,7 @@ module SyntaxSuggest io: io ) - expect(io.string.strip).to eq("Syntax OK") + expect(io.string.strip).to eq("") end it "raises original error with warning if a non-syntax error is passed" do |