Update to ruby/spec@54c391e

author: Benoit Daloze <[email protected]> 2024-11-06 21:57:34 +0100
committer: Benoit Daloze <[email protected]> 2024-11-06 21:58:28 +0100
commit: fdc82cca83bbbfe88f90d2888e139a6dde481101 (patch)
tree: 99165cce6af5eaca59316c06fed33f958c85e16a /spec/ruby/core/string
parent: 9bc63e7ba066b31314bbd66def4932b398eaf4c9 (diff)
2 files changed, 165 insertions, 1 deletions
diff --git a/spec/ruby/core/string/byteslice_spec.rb b/spec/ruby/core/string/byteslice_spec.rb
index 5b1027f4a5..9fe504aeb1 100644
--- a/spec/ruby/core/string/byteslice_spec.rb
+++ b/spec/ruby/core/string/byteslice_spec.rb
@@ -17,7 +17,7 @@ describe "String#byteslice with Range" do
   it_behaves_like :string_slice_range, :byteslice
 end
 
-describe "String#byteslice on on non ASCII strings" do
+describe "String#byteslice on non ASCII strings" do
   it "returns byteslice of unicode strings" do
     "\u3042".byteslice(1).should == "\x81".dup.force_encoding("UTF-8")
     "\u3042".byteslice(1, 2).should == "\x81\x82".dup.force_encoding("UTF-8")
diff --git a/spec/ruby/core/string/bytesplice_spec.rb b/spec/ruby/core/string/bytesplice_spec.rb
index 967edcba29..5cb3b2c158 100644
--- a/spec/ruby/core/string/bytesplice_spec.rb
+++ b/spec/ruby/core/string/bytesplice_spec.rb
@@ -58,6 +58,79 @@ describe "String#bytesplice" do
       -> { s.bytesplice(2, 1, "xxx") }.should raise_error(FrozenError, "can't modify frozen String: \"hello\"")
     end
   end
+
+  ruby_version_is "3.3" do
+    it "raises IndexError when str_index is less than -bytesize" do
+      -> { "hello".bytesplice(2, 1, "HELLO", -6, 0) }.should raise_error(IndexError, "index -6 out of string")
+    end
+
+    it "raises IndexError when str_index is greater than bytesize" do
+      -> { "hello".bytesplice(2, 1, "HELLO", 6, 0) }.should raise_error(IndexError, "index 6 out of string")
+    end
+
+    it "raises IndexError for negative str length" do
+      -> { "abc".bytesplice(0, 1, "", 0, -2) }.should raise_error(IndexError, "negative length -2")
+    end
+
+    it "replaces with integer str indices" do
+      "hello".bytesplice(1, 2, "HELLO", -5, 0).should == "hlo"
+      "hello".bytesplice(1, 2, "HELLO", 0, 0).should == "hlo"
+      "hello".bytesplice(1, 2, "HELLO", 0, 1).should == "hHlo"
+      "hello".bytesplice(1, 2, "HELLO", 0, 5).should == "hHELLOlo"
+      "hello".bytesplice(1, 2, "HELLO", 0, 6).should == "hHELLOlo"
+    end
+
+    it "raises RangeError when str range left boundary is less than -bytesize" do
+      -> { "hello".bytesplice(0..1, "HELLO", -6...-6) }.should raise_error(RangeError, "-6...-6 out of range")
+    end
+
+    it "replaces with str ranges" do
+      "hello".bytesplice(1..2, "HELLO", -5...-5).should == "hlo"
+      "hello".bytesplice(1..2, "HELLO", 0...0).should == "hlo"
+      "hello".bytesplice(1..2, "HELLO", 0..0).should == "hHlo"
+      "hello".bytesplice(1..2, "HELLO", 0...1).should == "hHlo"
+      "hello".bytesplice(1..2, "HELLO", 0..1).should == "hHElo"
+      "hello".bytesplice(1..2, "HELLO", 0..-1).should == "hHELLOlo"
+      "hello".bytesplice(1..2, "HELLO", 0...5).should == "hHELLOlo"
+      "hello".bytesplice(1..2, "HELLO", 0...6).should == "hHELLOlo"
+    end
+
+    it "raises ArgumentError when integer str index is provided without str length argument" do
+      -> { "hello".bytesplice(0, 1, "xxx", 0) }.should raise_error(ArgumentError, "wrong number of arguments (given 4, expected 2, 3, or 5)")
+    end
+
+    it "replaces on an empty string with str index/length" do
+      "".bytesplice(0, 0, "", 0, 0).should == ""
+      "".bytesplice(0, 0, "xxx", 0, 1).should == "x"
+    end
+
+    it "mutates self with substring and str index/length" do
+      s = "hello"
+      s.bytesplice(2, 1, "xxx", 1, 2).should.equal?(s)
+      s.should.eql?("hexxlo")
+    end
+
+    it "raises when string is frozen and str index/length" do
+      s = "hello".freeze
+      -> { s.bytesplice(2, 1, "xxx", 0, 1) }.should raise_error(FrozenError, "can't modify frozen String: \"hello\"")
+    end
+
+    it "replaces on an empty string with str range" do
+      "".bytesplice(0..0, "", 0..0).should == ""
+      "".bytesplice(0..0, "xyz", 0..1).should == "xy"
+    end
+
+    it "mutates self with substring and str range" do
+      s = "hello"
+      s.bytesplice(2..2, "xyz", 1..2).should.equal?(s)
+      s.should.eql?("heyzlo")
+    end
+
+    it "raises when string is frozen and str range" do
+      s = "hello".freeze
+      -> { s.bytesplice(2..2, "yzx", 0..1) }.should raise_error(FrozenError, "can't modify frozen String: \"hello\"")
+    end
+  end
 end
 
 describe "String#bytesplice with multibyte characters" do
@@ -131,4 +204,95 @@ describe "String#bytesplice with multibyte characters" do
       result.encoding.should == Encoding::UTF_8
     end
   end
+
+  ruby_version_is "3.3" do
+    it "raises IndexError when str_index is out of byte size boundary" do
+      -> { "こんにちは".bytesplice(3, 3, "こんにちは", -16, 0) }.should raise_error(IndexError, "index -16 out of string")
+    end
+
+    it "raises IndexError when str_index is not on a codepoint boundary" do
+      -> { "こんにちは".bytesplice(3, 3, "こんにちは", 1, 0) }.should raise_error(IndexError, "offset 1 does not land on character boundary")
+    end
+
+    it "raises IndexError when str_length is not matching the codepoint boundary" do
+      -> { "こんにちは".bytesplice(3, 3, "こんにちは", 0, 1) }.should raise_error(IndexError, "offset 1 does not land on character boundary")
+      -> { "こんにちは".bytesplice(3, 3, "こんにちは", 0, 2) }.should raise_error(IndexError, "offset 2 does not land on character boundary")
+    end
+
+    it "replaces with integer str indices" do
+      "こんにちは".bytesplice(3, 3, "こんにちは", -15, 0).should == "こにちは"
+      "こんにちは".bytesplice(3, 3, "こんにちは", 0, 0).should == "こにちは"
+      "こんにちは".bytesplice(3, 3, "こんにちは", 0, 3).should == "ここにちは"
+      "こんにちは".bytesplice(3, 3, "はは", 3, 3).should == "こはにちは"
+      "こんにちは".bytesplice(3, 3, "こんにちは", 15, 0).should == "こにちは"
+    end
+
+    it "replaces with str range" do
+      "こんにちは".bytesplice(0..2, "こんにちは", -15...-16).should == "んにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 0...0).should == "んにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 3..5).should == "んんにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 3...6).should == "んんにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 3..8).should == "んにんにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 0..-1).should == "こんにちはんにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 0...15).should == "こんにちはんにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 0...18).should == "こんにちはんにちは"
+    end
+
+    it "treats negative length for str range as 0" do
+      "こんにちは".bytesplice(0..2, "こんにちは", 0...-100).should == "んにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", 3...-100).should == "んにちは"
+      "こんにちは".bytesplice(0..2, "こんにちは", -15...-100).should == "んにちは"
+    end
+
+    it "raises when ranges not match codepoint boundaries in str" do
+      -> { "こんにちは".bytesplice(3...3, "こ", 0..0) }.should raise_error(IndexError, "offset 1 does not land on character boundary")
+      -> { "こんにちは".bytesplice(3...3, "こ", 0..1) }.should raise_error(IndexError, "offset 2 does not land on character boundary")
+      # Begin is incorrect
+      -> { "こんにちは".bytesplice(3...3, "こんにちは", -4..-1) }.should raise_error(IndexError, "offset 11 does not land on character boundary")
+      -> { "こんにちは".bytesplice(3...3, "こんにちは", -5..-1) }.should raise_error(IndexError, "offset 10 does not land on character boundary")
+      # End is incorrect
+      -> { "こんにちは".bytesplice(3...3, "こんにちは", -3..-2) }.should raise_error(IndexError, "offset 14 does not land on character boundary")
+      -> { "こんにちは".bytesplice(3...3, "こんにちは", -3..-3) }.should raise_error(IndexError, "offset 13 does not land on character boundary")
+    end
+
+    it "deals with a different encoded argument with str index/length" do
+      s = "こんにちは"
+      s.encoding.should == Encoding::UTF_8
+      sub = "goodbye"
+      sub.force_encoding(Encoding::US_ASCII)
+
+      result = s.bytesplice(3, 3, sub, 0, 3)
+      result.should == "こgooにちは"
+      result.encoding.should == Encoding::UTF_8
+
+      s = "hello"
+      s.force_encoding(Encoding::US_ASCII)
+      sub = "こんにちは"
+      sub.encoding.should == Encoding::UTF_8
+
+      result = s.bytesplice(1, 2, sub, 3, 3)
+      result.should == "hんlo"
+      result.encoding.should == Encoding::UTF_8
+    end
+
+    it "deals with a different encoded argument with str range" do
+      s = "こんにちは"
+      s.encoding.should == Encoding::UTF_8
+      sub = "goodbye"
+      sub.force_encoding(Encoding::US_ASCII)
+
+      result = s.bytesplice(3..5, sub, 0..2)
+      result.should == "こgooにちは"
+      result.encoding.should == Encoding::UTF_8
+
+      s = "hello"
+      s.force_encoding(Encoding::US_ASCII)
+      sub = "こんにちは"
+      sub.encoding.should == Encoding::UTF_8
+
+      result = s.bytesplice(1..2, sub, 3..5)
+      result.should == "hんlo"
+      result.encoding.should == Encoding::UTF_8
+    end
+  end
 end
author	Benoit Daloze <[email protected]>	2024-11-06 21:57:34 +0100
committer	Benoit Daloze <[email protected]>	2024-11-06 21:58:28 +0100
commit	fdc82cca83bbbfe88f90d2888e139a6dde481101 (patch)
tree	99165cce6af5eaca59316c06fed33f958c85e16a /spec/ruby/core/string
parent	9bc63e7ba066b31314bbd66def4932b398eaf4c9 (diff)