diff options
| author | Nobuyoshi Nakada <[email protected]> | 2024-11-06 13:31:38 +0900 |
|---|---|---|
| committer | Nobuyoshi Nakada <[email protected]> | 2024-11-06 13:31:38 +0900 |
| commit | d71be7274bd2623bb521be72c245c08fc38d6ae4 (patch) | |
| tree | 9b149e6c4bb5f1f974fc129081866f643d0153b1 | |
| parent | 18c3e2d9f1f1d5fc90d95bfa118982aaebc75928 (diff) | |
[Bug #20873] Consider `-FIXNUM_MIN` overflow
`-FIXNUM_MIN` is usually greater than `FIXNUM_MAX` on platforms using
two's complement representation.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/12011
| -rw-r--r-- | sprintf.c | 2 | ||||
| -rw-r--r-- | test/ruby/test_sprintf.rb | 4 |
2 files changed, 5 insertions, 1 deletions
@@ -808,7 +808,7 @@ rb_str_format(int argc, const VALUE *argv, VALUE fmt) if (FIXNUM_P(num)) { if ((SIGNED_VALUE)num < 0) { long n = -FIX2LONG(num); - num = LONG2FIX(n); + num = LONG2NUM(n); sign = -1; } } diff --git a/test/ruby/test_sprintf.rb b/test/ruby/test_sprintf.rb index 498f93aec4..3bd3bc793c 100644 --- a/test/ruby/test_sprintf.rb +++ b/test/ruby/test_sprintf.rb @@ -227,6 +227,10 @@ class TestSprintf < Test::Unit::TestCase bug11766 = '[ruby-core:71806] [Bug #11766]' assert_equal("x"*10+" 1.0", sprintf("x"*10+"%8.1f", 1r), bug11766) + + require 'rbconfig/sizeof' + fmin, fmax = RbConfig::LIMITS.values_at("FIXNUM_MIN", "FIXNUM_MAX") + assert_match(/\A-\d+\.\d+\z/, sprintf("%f", Rational(fmin, fmax))) end def test_rational_precision |