diff options
| author | Ellen Marie Dash <[email protected]> | 2021-08-13 15:59:46 -0400 |
|---|---|---|
| committer | Hiroshi SHIBATA <[email protected]> | 2021-09-22 10:13:49 +0900 |
| commit | cd2e6318f6502018d398cb9706a286ef5b202bf4 (patch) | |
| tree | 0d2859b54c86f9bfe040d7d6d5bd0a319f55f14c | |
| parent | eaeb5bf0bcf42d43b3118e0586508a5d78cfa5c7 (diff) | |
[rubygems/rubygems] Only check if descriptions *start with* FIXME/TODO
It doesn't make much sense to just forbid certain words in descriptions.
https://github.com/rubygems/rubygems/commit/7890c98415
| -rw-r--r-- | lib/rubygems/specification_policy.rb | 2 | ||||
| -rw-r--r-- | test/rubygems/test_gem_specification.rb | 14 |
2 files changed, 15 insertions, 1 deletions
diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb index 1f1f73b11f..c30ec707d9 100644 --- a/lib/rubygems/specification_policy.rb +++ b/lib/rubygems/specification_policy.rb @@ -381,7 +381,7 @@ http://spdx.org/licenses or '#{Gem::Licenses::NONSTANDARD}' for a nonstandard li end LAZY = '"FIxxxXME" or "TOxxxDO"'.gsub(/xxx/, '') - LAZY_PATTERN = /FI XME|TO DO/x.freeze + LAZY_PATTERN = /^FI XME|^TO DO/x.freeze HOMEPAGE_URI_PATTERN = /\A[a-z][a-z\d+.-]*:/i.freeze def validate_lazy_metadata diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb index 88afa3faa0..782ae0380f 100644 --- a/test/rubygems/test_gem_specification.rb +++ b/test/rubygems/test_gem_specification.rb @@ -2781,6 +2781,20 @@ duplicate dependency on c (>= 1.2.3, development), (~> 1.2) use: end assert_equal %("#{f}" or "#{t}" is not a description), e.message + + # Adding #{f} anywhere after the start of the description should be fine. + @a1.description = "(some description) #{f}" + + assert_nothing_raised do + @a1.validate + end + + # Adding #{t} anywhere after the start of the description should be fine. + @a1.description = "(some description) #{t}" + + assert_nothing_raised do + @a1.validate + end end end |