diff options
| author | Peter Zhu <[email protected]> | 2023-03-14 23:18:11 -0400 |
|---|---|---|
| committer | Peter Zhu <[email protected]> | 2023-03-14 23:18:11 -0400 |
| commit | 3dc8cde70078ccb38f5f4b0818ad5eecded01bd5 (patch) | |
| tree | c75cefa316ff3a2af04bea8f7a16fa0d1ee1bc53 | |
| parent | 70ba3102129dbaf6c943d1ed042103e0238842f4 (diff) | |
Fix crash during compaction
[Bug #19529]
The fix for [Bug #19529] in commit 548086b contained a bug that crashes
on the following script:
```
wm = ObjectSpace::WeakMap.new
obj = Object.new
100.times do
wm[Object.new] = obj
GC.start
end
GC.compact
```
| -rw-r--r-- | test/ruby/test_weakmap.rb | 10 | ||||
| -rw-r--r-- | weakmap.c | 2 |
2 files changed, 11 insertions, 1 deletions
diff --git a/test/ruby/test_weakmap.rb b/test/ruby/test_weakmap.rb index d84eb8241e..9bbe2d6b81 100644 --- a/test/ruby/test_weakmap.rb +++ b/test/ruby/test_weakmap.rb @@ -183,5 +183,15 @@ class TestWeakMap < Test::Unit::TestCase GC.compact @wm[i] = obj end + + assert_separately(%w(--disable-gems), <<-'end;') + wm = ObjectSpace::WeakMap.new + obj = Object.new + 100.times do + wm[Object.new] = obj + GC.start + end + GC.compact + end; end end @@ -17,7 +17,7 @@ wmap_replace_ref(st_data_t *key, st_data_t *value, st_data_t _argp, int existing { *key = rb_gc_location((VALUE)*key); - VALUE *values = (VALUE *)value; + VALUE *values = (VALUE *)*value; VALUE size = values[0]; for (VALUE index = 1; index <= size; index++) { |