diff options
| author | Jean Boussier <[email protected]> | 2023-04-18 12:36:57 +0200 |
|---|---|---|
| committer | Jean Boussier <[email protected]> | 2023-05-03 10:43:46 +0200 |
| commit | 04ee666aab071cb6fd9a8b356b22d73250ca6b9b (patch) | |
| tree | d8eda2531edc0f78ad26a27ad1844edd5acd3139 | |
| parent | 409a13e9ea018bbfa9dfc71c3427eff2dc4c4bd2 (diff) | |
Make the maximum shapes variation warning non-verbose
[Feature #19538]
Since that category is not enabled by default, making it a
verbose warning is redundant. Enabling performance warning should
work with the default verbosity level.
Notes
Notes:
Merged: https://github.com/ruby/ruby/pull/7733
| -rw-r--r-- | shape.c | 2 | ||||
| -rw-r--r-- | test/ruby/test_object.rb | 2 |
2 files changed, 2 insertions, 2 deletions
@@ -403,7 +403,7 @@ rb_shape_get_next(rb_shape_t* shape, VALUE obj, ID id) RCLASS_EXT(klass)->variation_count++; if (rb_warning_category_enabled_p(RB_WARN_CATEGORY_PERFORMANCE)) { if (RCLASS_EXT(klass)->variation_count >= SHAPE_MAX_VARIATIONS) { - rb_category_warning( + rb_category_warn( RB_WARN_CATEGORY_PERFORMANCE, "Maximum shapes variations (%d) reached by %"PRIsVALUE", instance variables accesses will be slower.", SHAPE_MAX_VARIATIONS, diff --git a/test/ruby/test_object.rb b/test/ruby/test_object.rb index a34fc7813a..3c5b6424ba 100644 --- a/test/ruby/test_object.rb +++ b/test/ruby/test_object.rb @@ -424,7 +424,7 @@ class TestObject < Test::Unit::TestCase def test_max_shape_variation_with_performance_warnings assert_in_out_err([], <<-INPUT, %w(), /Maximum shapes variations \(8\) reached by Foo, instance variables accesses will be slower\.$/) - $VERBOSE = true + $VERBOSE = false Warning[:performance] = true class Foo; end |