Issue 128360043: [dev.power64] code review 128360043: liblink: recognize add instruction as adjusting SP

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 128360043: [dev.power64] code review 128360043: liblink: recognize add instruction as adjusting SP

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
gobot, minux

CC:
minux, golang-codereviews

Visibility:
Public.

Description

liblink: recognize add instruction as adjusting SP

Patch Set 1 #

Patch Set 2 : diff -r 541b884670bf867a67a99b58fe34dbbe169881a3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 541b884670bf867a67a99b58fe34dbbe169881a3 https://code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/liblink/list9.c	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/liblink/obj9.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello minux (cc: [email protected]), I'd like you to review this change to the dev.power64 branch ...

11 years, 4 months ago (2014-08-15 21:20:18 UTC) #1

minux

*** Submitted as https://code.google.com/p/go/source/detail?r=be0c14f62257 *** [dev.power64] liblink: recognize add instruction as adjusting SP LGTM=minux R=minux ...

11 years, 4 months ago (2014-08-19 02:25:27 UTC) #3

gobot

11 years, 3 months ago (2014-09-14 03:22:35 UTC) #4

This CL appears to have broken the windows-amd64 builder.
See http://build.golang.org/log/9bbcd9b8556f22430159a28bf0680ab7c827583d

Expand All Messages | Collapse All Messages