Modified activity_exifmenu.xml #80

Closed

good wants to merge 1 commit from good/Imagepipe:modify_color into master

good commented

2025-02-19 13:32:56 +01:00

First-time contributor

Hello,
I just discovered an issue with the color. The text "Only tags ..." has insufficient color contrast, making it difficult to read. Therefore, it should be changed to black.

Before：

After：

Hello, I just discovered an issue with the color. The text "Only tags ..." has insufficient color contrast, making it difficult to read. Therefore, it should be changed to black. Before： ![Before.png](/attachments/0339e806-cd3e-476f-b1ef-5dc29affb985) After： ![After.png](/attachments/353b066c-cc62-48e7-a4b6-d4acc7b47ac7)

Before.png

97 KiB

After.png

97 KiB

good added 1 commit

2025-02-19 13:32:57 +01:00

Modified activity_exifmenu.xml bdbc7328c1

Starfish commented

2025-02-19 17:15:32 +01:00

Owner

I have fixed it: 10569ca4e5

However, instead of hard-coding the color, it is better to stick to the color scheme defined in values/colors.xml for better consistency.

For this reason, I will not merge it, but thanks for pointing at this issue!

I have fixed it: https://codeberg.org/Starfish/Imagepipe/commit/10569ca4e5b50a6d58b1f603abcc12b44d676c00 However, instead of hard-coding the color, it is better to stick to the color scheme defined in values/colors.xml for better consistency. For this reason, I will not merge it, but thanks for pointing at this issue!