Avi Drissman | 8ba1bad | 2022-09-13 19:22:36 | [diff] [blame] | 1 | // Copyright 2012 The Chromium Authors |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
brettw | f00b9b4 | 2016-02-01 22:11:38 | [diff] [blame] | 5 | #include "components/prefs/overlay_user_pref_store.h" |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 6 | |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 7 | #include <memory> |
Peter Kasting | b2777ce | 2021-07-20 18:28:54 | [diff] [blame] | 8 | #include <ostream> |
Roland Bock | 24a7c86 | 2022-09-26 07:29:48 | [diff] [blame] | 9 | #include <string> |
Helmut Januschka | 3ae9000 | 2024-05-02 18:42:28 | [diff] [blame] | 10 | #include <string_view> |
danakj | 0c8d4aa | 2015-11-25 05:29:58 | [diff] [blame] | 11 | #include <utility> |
| 12 | |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 13 | #include "base/memory/ptr_util.h" |
Keishi Hattori | 0e45c02 | 2021-11-27 09:25:52 | [diff] [blame] | 14 | #include "base/memory/raw_ptr.h" |
David Sanders | 88b2443 | 2022-02-28 01:10:02 | [diff] [blame] | 15 | #include "base/observer_list.h" |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 16 | #include "base/values.h" |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 17 | #include "components/prefs/in_memory_pref_store.h" |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 18 | |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 19 | // Allows us to monitor two pref stores and tell updates from them apart. It |
| 20 | // essentially mimics a Callback for the Observer interface (e.g. it allows |
| 21 | // binding additional arguments). |
| 22 | class OverlayUserPrefStore::ObserverAdapter : public PrefStore::Observer { |
| 23 | public: |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 24 | ObserverAdapter(bool ephemeral, OverlayUserPrefStore* parent) |
| 25 | : ephemeral_user_pref_store_(ephemeral), parent_(parent) {} |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 26 | |
| 27 | // Methods of PrefStore::Observer. |
Jan Keitel | 0523c5e3 | 2024-06-28 13:58:52 | [diff] [blame] | 28 | void OnPrefValueChanged(std::string_view key) override { |
Jan Keitel | 07b772b | 2024-06-28 14:34:30 | [diff] [blame] | 29 | parent_->OnPrefValueChanged(ephemeral_user_pref_store_, key); |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 30 | } |
| 31 | void OnInitializationCompleted(bool succeeded) override { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 32 | parent_->OnInitializationCompleted(ephemeral_user_pref_store_, succeeded); |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 33 | } |
| 34 | |
| 35 | private: |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 36 | // Is the update for the ephemeral? |
| 37 | const bool ephemeral_user_pref_store_; |
Keishi Hattori | 0e45c02 | 2021-11-27 09:25:52 | [diff] [blame] | 38 | const raw_ptr<OverlayUserPrefStore> parent_; |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 39 | }; |
| 40 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 41 | OverlayUserPrefStore::OverlayUserPrefStore(PersistentPrefStore* persistent) |
| 42 | : OverlayUserPrefStore(new InMemoryPrefStore(), persistent) {} |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 43 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 44 | OverlayUserPrefStore::OverlayUserPrefStore(PersistentPrefStore* ephemeral, |
| 45 | PersistentPrefStore* persistent) |
| 46 | : ephemeral_pref_store_observer_( |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame] | 47 | std::make_unique<OverlayUserPrefStore::ObserverAdapter>(true, this)), |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 48 | persistent_pref_store_observer_( |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame] | 49 | std::make_unique<OverlayUserPrefStore::ObserverAdapter>(false, this)), |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 50 | ephemeral_user_pref_store_(ephemeral), |
| 51 | persistent_user_pref_store_(persistent) { |
| 52 | DCHECK(ephemeral->IsInitializationComplete()); |
| 53 | ephemeral_user_pref_store_->AddObserver(ephemeral_pref_store_observer_.get()); |
| 54 | persistent_user_pref_store_->AddObserver( |
| 55 | persistent_pref_store_observer_.get()); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 56 | } |
| 57 | |
Jan Keitel | 6288ad6b | 2024-07-26 09:00:14 | [diff] [blame] | 58 | bool OverlayUserPrefStore::IsSetInOverlay(std::string_view key) const { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 59 | return ephemeral_user_pref_store_->GetValue(key, nullptr); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 60 | } |
| 61 | |
| 62 | void OverlayUserPrefStore::AddObserver(PrefStore::Observer* observer) { |
| 63 | observers_.AddObserver(observer); |
| 64 | } |
| 65 | |
| 66 | void OverlayUserPrefStore::RemoveObserver(PrefStore::Observer* observer) { |
| 67 | observers_.RemoveObserver(observer); |
| 68 | } |
| 69 | |
[email protected] | 14e0ec6 | 2013-08-26 22:01:39 | [diff] [blame] | 70 | bool OverlayUserPrefStore::HasObservers() const { |
Mitsuru Oshima | 28f9b681 | 2021-01-20 19:33:07 | [diff] [blame] | 71 | return !observers_.empty(); |
[email protected] | d3b05ea | 2012-01-24 22:57:05 | [diff] [blame] | 72 | } |
| 73 | |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 74 | bool OverlayUserPrefStore::IsInitializationComplete() const { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 75 | return persistent_user_pref_store_->IsInitializationComplete() && |
| 76 | ephemeral_user_pref_store_->IsInitializationComplete(); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 77 | } |
| 78 | |
Helmut Januschka | 3ae9000 | 2024-05-02 18:42:28 | [diff] [blame] | 79 | bool OverlayUserPrefStore::GetValue(std::string_view key, |
[email protected] | a43a667b | 2013-06-14 17:56:08 | [diff] [blame] | 80 | const base::Value** result) const { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 81 | // If the |key| shall NOT be stored in the ephemeral store, there must not |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 82 | // be an entry. |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 83 | DCHECK(!ShallBeStoredInPersistent(key) || |
| 84 | !ephemeral_user_pref_store_->GetValue(key, nullptr)); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 85 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 86 | if (ephemeral_user_pref_store_->GetValue(key, result)) |
[email protected] | 892f1d6 | 2012-11-08 18:24:34 | [diff] [blame] | 87 | return true; |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 88 | return persistent_user_pref_store_->GetValue(key, result); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 89 | } |
| 90 | |
Matt Menke | 38ac93c | 2022-08-17 03:12:59 | [diff] [blame] | 91 | base::Value::Dict OverlayUserPrefStore::GetValues() const { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 92 | auto values = ephemeral_user_pref_store_->GetValues(); |
| 93 | auto persistent_values = persistent_user_pref_store_->GetValues(); |
| 94 | |
| 95 | // Output |values| are read from |ephemeral_user_pref_store_| (in-memory |
| 96 | // store). Then the values of preferences in |persistent_names_set_| are |
| 97 | // overwritten by the content of |persistent_user_pref_store_| (the persistent |
| 98 | // store). |
| 99 | for (const auto& key : persistent_names_set_) { |
Arthur Sonzogni | c571efb | 2024-01-26 20:26:18 | [diff] [blame] | 100 | std::optional<base::Value> out_value = |
Matt Menke | 38ac93c | 2022-08-17 03:12:59 | [diff] [blame] | 101 | persistent_values.ExtractByDottedPath(key); |
Song Fangzhen | 6176788 | 2021-07-16 04:59:40 | [diff] [blame] | 102 | if (out_value.has_value()) { |
Matt Menke | 38ac93c | 2022-08-17 03:12:59 | [diff] [blame] | 103 | values.SetByDottedPath(key, std::move(*out_value)); |
tibell | e23659b4 | 2017-02-23 01:44:13 | [diff] [blame] | 104 | } |
| 105 | } |
| 106 | return values; |
| 107 | } |
| 108 | |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 109 | bool OverlayUserPrefStore::GetMutableValue(std::string_view key, |
[email protected] | a43a667b | 2013-06-14 17:56:08 | [diff] [blame] | 110 | base::Value** result) { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 111 | if (ShallBeStoredInPersistent(key)) |
| 112 | return persistent_user_pref_store_->GetMutableValue(key, result); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 113 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 114 | if (ephemeral_user_pref_store_->GetMutableValue(key, result)) |
[email protected] | 892f1d6 | 2012-11-08 18:24:34 | [diff] [blame] | 115 | return true; |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 116 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 117 | // Try to create copy of persistent if the ephemeral does not contain a value. |
| 118 | base::Value* persistent_value = nullptr; |
| 119 | if (!persistent_user_pref_store_->GetMutableValue(key, &persistent_value)) |
[email protected] | 892f1d6 | 2012-11-08 18:24:34 | [diff] [blame] | 120 | return false; |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 121 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 122 | ephemeral_user_pref_store_->SetValue( |
Roland Bock | e01119d | 2022-09-29 01:21:41 | [diff] [blame] | 123 | key, persistent_value->Clone(), |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 124 | WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS); |
Vladislav Kuzkokov | 8ee75fbc | 2019-01-14 14:14:04 | [diff] [blame] | 125 | ephemeral_user_pref_store_->GetMutableValue(key, result); |
[email protected] | 892f1d6 | 2012-11-08 18:24:34 | [diff] [blame] | 126 | return true; |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 127 | } |
| 128 | |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 129 | void OverlayUserPrefStore::SetValue(std::string_view key, |
Roland Bock | e01119d | 2022-09-29 01:21:41 | [diff] [blame] | 130 | base::Value value, |
avi | 9ef8bb0 | 2015-12-24 05:29:36 | [diff] [blame] | 131 | uint32_t flags) { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 132 | if (ShallBeStoredInPersistent(key)) { |
| 133 | persistent_user_pref_store_->SetValue(key, std::move(value), flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 134 | return; |
| 135 | } |
| 136 | |
Alison Gale | b8be952 | 2024-04-16 00:00:31 | [diff] [blame] | 137 | // TODO(crbug.com/40584094): If we always store in in-memory storage |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 138 | // and conditionally also stored in persistent one, we wouldn't have to do a |
| 139 | // complex merge in GetValues(). |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 140 | ephemeral_user_pref_store_->SetValue(key, std::move(value), flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 141 | } |
| 142 | |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 143 | void OverlayUserPrefStore::SetValueSilently(std::string_view key, |
Roland Bock | e01119d | 2022-09-29 01:21:41 | [diff] [blame] | 144 | base::Value value, |
avi | 9ef8bb0 | 2015-12-24 05:29:36 | [diff] [blame] | 145 | uint32_t flags) { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 146 | if (ShallBeStoredInPersistent(key)) { |
| 147 | persistent_user_pref_store_->SetValueSilently(key, std::move(value), flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 148 | return; |
| 149 | } |
| 150 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 151 | ephemeral_user_pref_store_->SetValueSilently(key, std::move(value), flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 152 | } |
| 153 | |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 154 | void OverlayUserPrefStore::RemoveValue(std::string_view key, uint32_t flags) { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 155 | if (ShallBeStoredInPersistent(key)) { |
| 156 | persistent_user_pref_store_->RemoveValue(key, flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 157 | return; |
| 158 | } |
| 159 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 160 | ephemeral_user_pref_store_->RemoveValue(key, flags); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 161 | } |
| 162 | |
Anatoliy Potapchuk | 5d9d8de | 2020-04-21 02:09:26 | [diff] [blame] | 163 | void OverlayUserPrefStore::RemoveValuesByPrefixSilently( |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 164 | std::string_view prefix) { |
Anatoliy Potapchuk | 5d9d8de | 2020-04-21 02:09:26 | [diff] [blame] | 165 | NOTIMPLEMENTED(); |
| 166 | } |
| 167 | |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 168 | bool OverlayUserPrefStore::ReadOnly() const { |
| 169 | return false; |
| 170 | } |
| 171 | |
[email protected] | 59c1071 | 2012-03-13 02:10:34 | [diff] [blame] | 172 | PersistentPrefStore::PrefReadError OverlayUserPrefStore::GetReadError() const { |
| 173 | return PersistentPrefStore::PREF_READ_ERROR_NONE; |
| 174 | } |
| 175 | |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 176 | PersistentPrefStore::PrefReadError OverlayUserPrefStore::ReadPrefs() { |
| 177 | // We do not read intentionally. |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 178 | OnInitializationCompleted(/* ephemeral */ false, true); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 179 | return PersistentPrefStore::PREF_READ_ERROR_NONE; |
| 180 | } |
| 181 | |
| 182 | void OverlayUserPrefStore::ReadPrefsAsync( |
| 183 | ReadErrorDelegate* error_delegate_raw) { |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 184 | std::unique_ptr<ReadErrorDelegate> error_delegate(error_delegate_raw); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 185 | // We do not read intentionally. |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 186 | OnInitializationCompleted(/* ephemeral */ false, true); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 187 | } |
| 188 | |
Gabriel Charette | 788eaf6 | 2018-08-07 20:11:46 | [diff] [blame] | 189 | void OverlayUserPrefStore::CommitPendingWrite( |
| 190 | base::OnceClosure reply_callback, |
| 191 | base::OnceClosure synchronous_done_callback) { |
| 192 | persistent_user_pref_store_->CommitPendingWrite( |
| 193 | std::move(reply_callback), std::move(synchronous_done_callback)); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 194 | // We do not write our content intentionally. |
| 195 | } |
| 196 | |
benwells | 2673059 | 2015-05-28 13:08:08 | [diff] [blame] | 197 | void OverlayUserPrefStore::SchedulePendingLossyWrites() { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 198 | persistent_user_pref_store_->SchedulePendingLossyWrites(); |
benwells | 2673059 | 2015-05-28 13:08:08 | [diff] [blame] | 199 | } |
| 200 | |
Jan Keitel | 331cd169 | 2024-06-28 14:30:53 | [diff] [blame] | 201 | void OverlayUserPrefStore::ReportValueChanged(std::string_view key, |
avi | 9ef8bb0 | 2015-12-24 05:29:36 | [diff] [blame] | 202 | uint32_t flags) { |
ericwilligers | 42b92c1 | 2016-10-24 20:21:13 | [diff] [blame] | 203 | for (PrefStore::Observer& observer : observers_) |
| 204 | observer.OnPrefValueChanged(key); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 205 | } |
| 206 | |
Jan Keitel | 6288ad6b | 2024-07-26 09:00:14 | [diff] [blame] | 207 | void OverlayUserPrefStore::RegisterPersistentPref(std::string_view key) { |
Johan Tibell | 6566c8ac | 2017-05-11 03:22:17 | [diff] [blame] | 208 | DCHECK(!key.empty()) << "Key is empty"; |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 209 | DCHECK(persistent_names_set_.find(key) == persistent_names_set_.end()) |
| 210 | << "Key already registered: " << key; |
Jan Keitel | 6288ad6b | 2024-07-26 09:00:14 | [diff] [blame] | 211 | persistent_names_set_.insert(std::string(key)); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 212 | } |
| 213 | |
proberge | 45e34728 | 2017-08-16 21:24:05 | [diff] [blame] | 214 | void OverlayUserPrefStore::OnStoreDeletionFromDisk() { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 215 | persistent_user_pref_store_->OnStoreDeletionFromDisk(); |
proberge | 45e34728 | 2017-08-16 21:24:05 | [diff] [blame] | 216 | } |
| 217 | |
[email protected] | 2dea5c0 | 2012-04-25 07:01:07 | [diff] [blame] | 218 | OverlayUserPrefStore::~OverlayUserPrefStore() { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 219 | ephemeral_user_pref_store_->RemoveObserver( |
| 220 | ephemeral_pref_store_observer_.get()); |
| 221 | persistent_user_pref_store_->RemoveObserver( |
| 222 | persistent_pref_store_observer_.get()); |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 223 | } |
| 224 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 225 | void OverlayUserPrefStore::OnPrefValueChanged(bool ephemeral, |
Jan Keitel | 07b772b | 2024-06-28 14:34:30 | [diff] [blame] | 226 | std::string_view key) { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 227 | if (ephemeral) { |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 228 | ReportValueChanged(key, DEFAULT_PREF_WRITE_FLAGS); |
| 229 | } else { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 230 | if (!ephemeral_user_pref_store_->GetValue(key, nullptr)) |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 231 | ReportValueChanged(key, DEFAULT_PREF_WRITE_FLAGS); |
| 232 | } |
| 233 | } |
| 234 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 235 | void OverlayUserPrefStore::OnInitializationCompleted(bool ephemeral, |
Johan Tibell | 0595f76 | 2017-05-25 23:54:50 | [diff] [blame] | 236 | bool succeeded) { |
| 237 | if (!IsInitializationComplete()) |
| 238 | return; |
| 239 | for (PrefStore::Observer& observer : observers_) |
| 240 | observer.OnInitializationCompleted(succeeded); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 241 | } |
| 242 | |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 243 | bool OverlayUserPrefStore::ShallBeStoredInPersistent( |
Helmut Januschka | 3ae9000 | 2024-05-02 18:42:28 | [diff] [blame] | 244 | std::string_view key) const { |
Ramin Halavati | f623bafe9 | 2018-07-17 12:12:58 | [diff] [blame] | 245 | return persistent_names_set_.find(key) != persistent_names_set_.end(); |
[email protected] | 39565dd | 2011-11-14 12:09:27 | [diff] [blame] | 246 | } |
Ankush Singh | a77ee839 | 2024-05-15 08:20:41 | [diff] [blame] | 247 | |
| 248 | bool OverlayUserPrefStore::HasReadErrorDelegate() const { |
| 249 | return persistent_user_pref_store_->HasReadErrorDelegate(); |
| 250 | } |