zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 1 | // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 5 | #include "base/macros.h" |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 6 | #include "build/build_config.h" |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 7 | #include "chrome/browser/ui/browser.h" |
Joe Downing | a7235f9 | 2018-05-30 22:40:52 | [diff] [blame] | 8 | #include "chrome/browser/ui/fullscreen_keyboard_browsertest_base.h" |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 9 | #include "chrome/test/base/in_process_browser_test.h" |
Peter Kasting | 919ce65 | 2020-05-07 10:22:36 | [diff] [blame^] | 10 | #include "content/public/test/browser_test.h" |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 11 | #include "ui/events/keycodes/keyboard_codes.h" |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 12 | |
| 13 | #if defined(OS_MACOSX) |
| 14 | #include "base/mac/mac_util.h" |
| 15 | #endif |
| 16 | |
Joe Downing | a7235f9 | 2018-05-30 22:40:52 | [diff] [blame] | 17 | using BrowserCommandControllerInteractiveTest = |
| 18 | FullscreenKeyboardBrowserTestBase; |
Tatiana Gornak | e8c2d511 | 2018-06-13 13:32:51 | [diff] [blame] | 19 | #if defined(OS_MACOSX) |
| 20 | // Flaky http://crbug.com/852285 |
| 21 | #define MAYBE_ShortcutsShouldTakeEffectInWindowMode \ |
| 22 | DISABLED_ShortcutsShouldTakeEffectInWindowMode |
| 23 | #else |
| 24 | #define MAYBE_ShortcutsShouldTakeEffectInWindowMode \ |
| 25 | ShortcutsShouldTakeEffectInWindowMode |
| 26 | #endif |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 27 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerInteractiveTest, |
Tatiana Gornak | e8c2d511 | 2018-06-13 13:32:51 | [diff] [blame] | 28 | MAYBE_ShortcutsShouldTakeEffectInWindowMode) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 29 | ASSERT_EQ(1, GetTabCount()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 30 | ASSERT_NO_FATAL_FAILURE(SendShortcut(ui::VKEY_T)); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 31 | ASSERT_EQ(2, GetTabCount()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 32 | ASSERT_NO_FATAL_FAILURE(SendShortcut(ui::VKEY_T)); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 33 | ASSERT_EQ(3, GetTabCount()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 34 | ASSERT_NO_FATAL_FAILURE(SendShortcut(ui::VKEY_W)); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 35 | ASSERT_EQ(2, GetTabCount()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 36 | ASSERT_NO_FATAL_FAILURE(SendShortcut(ui::VKEY_W)); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 37 | ASSERT_EQ(1, GetTabCount()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 38 | ASSERT_NO_FATAL_FAILURE(SendFullscreenShortcutAndWait()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 39 | ASSERT_TRUE(IsInBrowserFullscreen()); |
| 40 | ASSERT_FALSE(IsActiveTabFullscreen()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 41 | } |
| 42 | |
| 43 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerInteractiveTest, |
| 44 | UnpreservedShortcutsShouldBePreventable) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 45 | ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 46 | |
| 47 | // The browser print function should be blocked by the web page. |
| 48 | ASSERT_NO_FATAL_FAILURE(SendShortcut(ui::VKEY_P)); |
| 49 | // The system print function should be blocked by the web page. |
| 50 | ASSERT_NO_FATAL_FAILURE(SendShiftShortcut(ui::VKEY_P)); |
| 51 | ASSERT_NO_FATAL_FAILURE(FinishTestAndVerifyResult()); |
| 52 | } |
| 53 | |
| 54 | #if defined(OS_MACOSX) |
| 55 | // TODO(zijiehe): Figure out why this test crashes on Mac OSX. The suspicious |
| 56 | // command is "SendFullscreenShortcutAndWait()". See, http://crbug.com/738949. |
| 57 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen \ |
| 58 | DISABLED_KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen |
| 59 | #else |
| 60 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen \ |
| 61 | KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen |
| 62 | #endif |
| 63 | IN_PROC_BROWSER_TEST_F( |
| 64 | BrowserCommandControllerInteractiveTest, |
| 65 | MAYBE_KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 66 | ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 67 | |
| 68 | ASSERT_NO_FATAL_FAILURE(SendFullscreenShortcutAndWait()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 69 | ASSERT_FALSE(IsActiveTabFullscreen()); |
| 70 | ASSERT_TRUE(IsInBrowserFullscreen()); |
| 71 | ASSERT_NO_FATAL_FAILURE(SendShortcutsAndExpectPrevented()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 72 | // Current page should not exit browser fullscreen mode. |
| 73 | ASSERT_NO_FATAL_FAILURE(SendEscape()); |
| 74 | |
| 75 | ASSERT_NO_FATAL_FAILURE(FinishTestAndVerifyResult()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 76 | |
| 77 | ASSERT_NO_FATAL_FAILURE(SendFullscreenShortcutAndWait()); |
| 78 | ASSERT_FALSE(IsActiveTabFullscreen()); |
| 79 | ASSERT_FALSE(IsInBrowserFullscreen()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 80 | } |
| 81 | |
Elly Fong-Jones | ef8284d | 2019-11-04 18:50:44 | [diff] [blame] | 82 | #if defined(OS_MACOSX) |
| 83 | // https://crbug.com/850594 |
| 84 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc \ |
| 85 | DISABLED_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc |
| 86 | #else |
| 87 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc \ |
| 88 | KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc |
| 89 | #endif |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 90 | IN_PROC_BROWSER_TEST_F( |
| 91 | BrowserCommandControllerInteractiveTest, |
Elly Fong-Jones | ef8284d | 2019-11-04 18:50:44 | [diff] [blame] | 92 | MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 93 | ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 94 | |
| 95 | ASSERT_NO_FATAL_FAILURE(SendJsFullscreenShortcutAndWait()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 96 | ASSERT_NO_FATAL_FAILURE(SendShortcutsAndExpectPrevented()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 97 | // Current page should exit HTML fullscreen mode. |
| 98 | ASSERT_NO_FATAL_FAILURE(SendEscapeAndWaitForExitingFullscreen()); |
| 99 | |
| 100 | ASSERT_NO_FATAL_FAILURE(FinishTestAndVerifyResult()); |
| 101 | } |
| 102 | |
Robert Liao | 31d0798 | 2018-03-22 12:50:40 | [diff] [blame] | 103 | #if defined(OS_MACOSX) |
| 104 | // Triggers a DCHECK in MacViews: http://crbug.com/823478 |
| 105 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 106 | DISABLED_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 |
Robert Liao | 31d0798 | 2018-03-22 12:50:40 | [diff] [blame] | 107 | #else |
| 108 | #define MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 109 | KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 |
Robert Liao | 31d0798 | 2018-03-22 12:50:40 | [diff] [blame] | 110 | #endif |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 111 | IN_PROC_BROWSER_TEST_F( |
| 112 | BrowserCommandControllerInteractiveTest, |
Robert Liao | 31d0798 | 2018-03-22 12:50:40 | [diff] [blame] | 113 | MAYBE_KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 114 | ASSERT_NO_FATAL_FAILURE(StartFullscreenLockPage()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 115 | |
| 116 | ASSERT_NO_FATAL_FAILURE(SendJsFullscreenShortcutAndWait()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 117 | ASSERT_NO_FATAL_FAILURE(SendShortcutsAndExpectPrevented()); |
Avi Drissman | 438827be | 2019-06-06 18:46:11 | [diff] [blame] | 118 | |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 119 | // Current page should exit browser fullscreen mode. |
| 120 | ASSERT_NO_FATAL_FAILURE(SendFullscreenShortcutAndWait()); |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 121 | ASSERT_FALSE(IsActiveTabFullscreen()); |
| 122 | ASSERT_FALSE(IsInBrowserFullscreen()); |
zijiehe | bb317b9 | 2017-07-15 00:01:40 | [diff] [blame] | 123 | |
| 124 | ASSERT_NO_FATAL_FAILURE(FinishTestAndVerifyResult()); |
| 125 | } |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 126 | |
| 127 | #if defined(OS_MACOSX) |
| 128 | // TODO(zijiehe): Figure out why this test crashes on Mac OSX. The suspicious |
| 129 | // command is "SendFullscreenShortcutAndWait()". See, http://crbug.com/738949. |
| 130 | #define MAYBE_ShortcutsShouldTakeEffectInBrowserFullscreen \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 131 | DISABLED_ShortcutsShouldTakeEffectInBrowserFullscreen |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 132 | #else |
| 133 | #define MAYBE_ShortcutsShouldTakeEffectInBrowserFullscreen \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 134 | ShortcutsShouldTakeEffectInBrowserFullscreen |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 135 | #endif |
| 136 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerInteractiveTest, |
| 137 | MAYBE_ShortcutsShouldTakeEffectInBrowserFullscreen) { |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 138 | ASSERT_NO_FATAL_FAILURE(SendShortcutsAndExpectNotPrevented(false)); |
| 139 | } |
| 140 | |
| 141 | #if !defined(OS_MACOSX) |
| 142 | // HTML fullscreen is automatically exited after some commands are executed, |
| 143 | // such as Ctrl + T (new tab). But some commands won't have this effect, such as |
| 144 | // Ctrl + N (new window). |
| 145 | // On Mac OSX, AppKit implementation is used for HTML fullscreen mode. Entering |
| 146 | // and exiting AppKit fullscreen mode triggers an animation. A |
| 147 | // FullscreenChangeObserver is needed to ensure the animation is finished. But |
| 148 | // the FullscreenChangeObserver won't finish if the command actually won't cause |
| 149 | // the page to exit fullscreen mode. So we need to maintain a list of exiting / |
| 150 | // non-exiting commands, which is not the goal of this test. |
Zijie He | 19852bf5 | 2017-08-19 06:56:10 | [diff] [blame] | 151 | |
Zijie He | 729922fb | 2017-08-29 23:59:32 | [diff] [blame] | 152 | #if defined(OS_CHROMEOS) |
| 153 | // This test is flaky on ChromeOS, see http://crbug.com/754878. |
Zijie He | 19852bf5 | 2017-08-19 06:56:10 | [diff] [blame] | 154 | #define MAYBE_ShortcutsShouldTakeEffectInJsFullscreen \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 155 | DISABLED_ShortcutsShouldTakeEffectInJsFullscreen |
Zijie He | 19852bf5 | 2017-08-19 06:56:10 | [diff] [blame] | 156 | #else |
| 157 | #define MAYBE_ShortcutsShouldTakeEffectInJsFullscreen \ |
Aran Gilman | d217b5b | 2019-04-11 17:45:43 | [diff] [blame] | 158 | ShortcutsShouldTakeEffectInJsFullscreen |
Zijie He | 19852bf5 | 2017-08-19 06:56:10 | [diff] [blame] | 159 | #endif |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 160 | IN_PROC_BROWSER_TEST_F(BrowserCommandControllerInteractiveTest, |
Zijie He | 19852bf5 | 2017-08-19 06:56:10 | [diff] [blame] | 161 | MAYBE_ShortcutsShouldTakeEffectInJsFullscreen) { |
John Abd-El-Malek | 2305cdc | 2018-02-14 20:26:28 | [diff] [blame] | 162 | // This test is flaky. See http://crbug.com/759704. |
| 163 | // TODO(zijiehe): Find out the root cause. |
Zijie He | 729922fb | 2017-08-29 23:59:32 | [diff] [blame] | 164 | #if defined(OS_LINUX) |
John Abd-El-Malek | 2305cdc | 2018-02-14 20:26:28 | [diff] [blame] | 165 | return; |
Zijie He | 729922fb | 2017-08-29 23:59:32 | [diff] [blame] | 166 | #endif |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 167 | ASSERT_NO_FATAL_FAILURE(SendShortcutsAndExpectNotPrevented(true)); |
| 168 | } |
Zijie He | 850df0e | 2017-08-18 23:24:24 | [diff] [blame] | 169 | |
Hzj_jie | 24cdbc10 | 2017-08-11 20:02:24 | [diff] [blame] | 170 | #endif |