[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 1 | // Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 5 | #include "components/prefs/pref_change_registrar.h" |
| 6 | |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 7 | #include <memory> |
| 8 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 9 | #include "base/bind.h" |
| 10 | #include "base/bind_helpers.h" |
brettw | f00b9b4 | 2016-02-01 22:11:38 | [diff] [blame] | 11 | #include "components/prefs/pref_observer.h" |
| 12 | #include "components/prefs/pref_registry_simple.h" |
| 13 | #include "components/prefs/testing_pref_service.h" |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 14 | #include "testing/gmock/include/gmock/gmock.h" |
| 15 | #include "testing/gtest/include/gtest/gtest.h" |
| 16 | |
| 17 | using testing::Mock; |
| 18 | using testing::Eq; |
| 19 | |
[email protected] | 7e3ec42c | 2012-12-16 05:13:21 | [diff] [blame] | 20 | namespace base { |
[email protected] | f2d1f61 | 2010-12-09 15:10:17 | [diff] [blame] | 21 | namespace { |
| 22 | |
[email protected] | 5bfdcfd | 2012-11-22 22:08:24 | [diff] [blame] | 23 | const char kHomePage[] = "homepage"; |
| 24 | const char kHomePageIsNewTabPage[] = "homepage_is_newtabpage"; |
| 25 | const char kApplicationLocale[] = "intl.app_locale"; |
| 26 | |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 27 | // A mock provider that allows us to capture pref observer changes. |
[email protected] | 5b19952 | 2012-12-22 17:24:44 | [diff] [blame] | 28 | class MockPrefService : public TestingPrefServiceSimple { |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 29 | public: |
| 30 | MockPrefService() {} |
[email protected] | ceac997 | 2011-01-13 01:51:14 | [diff] [blame] | 31 | virtual ~MockPrefService() {} |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 32 | |
georgesak | 7da6e9d | 2014-12-03 01:10:29 | [diff] [blame] | 33 | MOCK_METHOD2(AddPrefObserver, void(const std::string&, PrefObserver*)); |
| 34 | MOCK_METHOD2(RemovePrefObserver, void(const std::string&, PrefObserver*)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 35 | }; |
| 36 | |
[email protected] | f2d1f61 | 2010-12-09 15:10:17 | [diff] [blame] | 37 | } // namespace |
| 38 | |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 39 | class PrefChangeRegistrarTest : public testing::Test { |
| 40 | public: |
| 41 | PrefChangeRegistrarTest() {} |
dcheng | 8aef3761 | 2014-12-23 02:56:47 | [diff] [blame] | 42 | ~PrefChangeRegistrarTest() override {} |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 43 | |
| 44 | protected: |
dcheng | 8aef3761 | 2014-12-23 02:56:47 | [diff] [blame] | 45 | void SetUp() override; |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 46 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 47 | base::Closure observer() const { |
| 48 | return base::Bind(&base::DoNothing); |
| 49 | } |
| 50 | |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 51 | MockPrefService* service() const { return service_.get(); } |
| 52 | |
| 53 | private: |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 54 | std::unique_ptr<MockPrefService> service_; |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 55 | }; |
| 56 | |
| 57 | void PrefChangeRegistrarTest::SetUp() { |
| 58 | service_.reset(new MockPrefService()); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 59 | } |
| 60 | |
| 61 | TEST_F(PrefChangeRegistrarTest, AddAndRemove) { |
| 62 | PrefChangeRegistrar registrar; |
| 63 | registrar.Init(service()); |
| 64 | |
| 65 | // Test adding. |
| 66 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 67 | AddPrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 68 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 69 | AddPrefObserver(Eq(std::string("test.pref.2")), ®istrar)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 70 | registrar.Add("test.pref.1", observer()); |
| 71 | registrar.Add("test.pref.2", observer()); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 72 | EXPECT_FALSE(registrar.IsEmpty()); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 73 | |
| 74 | // Test removing. |
| 75 | Mock::VerifyAndClearExpectations(service()); |
| 76 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 77 | RemovePrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 78 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 79 | RemovePrefObserver(Eq(std::string("test.pref.2")), ®istrar)); |
| 80 | registrar.Remove("test.pref.1"); |
| 81 | registrar.Remove("test.pref.2"); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 82 | EXPECT_TRUE(registrar.IsEmpty()); |
| 83 | |
| 84 | // Explicitly check the expectations now to make sure that the Removes |
| 85 | // worked (rather than the registrar destructor doing the work). |
| 86 | Mock::VerifyAndClearExpectations(service()); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 87 | } |
| 88 | |
| 89 | TEST_F(PrefChangeRegistrarTest, AutoRemove) { |
| 90 | PrefChangeRegistrar registrar; |
| 91 | registrar.Init(service()); |
| 92 | |
| 93 | // Setup of auto-remove. |
| 94 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 95 | AddPrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 96 | registrar.Add("test.pref.1", observer()); |
| 97 | Mock::VerifyAndClearExpectations(service()); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 98 | EXPECT_FALSE(registrar.IsEmpty()); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 99 | |
| 100 | // Test auto-removing. |
| 101 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 102 | RemovePrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 492d214 | 2010-09-10 13:55:18 | [diff] [blame] | 103 | } |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 104 | |
| 105 | TEST_F(PrefChangeRegistrarTest, RemoveAll) { |
| 106 | PrefChangeRegistrar registrar; |
| 107 | registrar.Init(service()); |
| 108 | |
| 109 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 110 | AddPrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 111 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 112 | AddPrefObserver(Eq(std::string("test.pref.2")), ®istrar)); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 113 | registrar.Add("test.pref.1", observer()); |
| 114 | registrar.Add("test.pref.2", observer()); |
| 115 | Mock::VerifyAndClearExpectations(service()); |
| 116 | |
| 117 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 118 | RemovePrefObserver(Eq(std::string("test.pref.1")), ®istrar)); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 119 | EXPECT_CALL(*service(), |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 120 | RemovePrefObserver(Eq(std::string("test.pref.2")), ®istrar)); |
[email protected] | 2fb7dc98 | 2010-09-29 12:24:28 | [diff] [blame] | 121 | registrar.RemoveAll(); |
| 122 | EXPECT_TRUE(registrar.IsEmpty()); |
| 123 | |
| 124 | // Explicitly check the expectations now to make sure that the RemoveAll |
| 125 | // worked (rather than the registrar destructor doing the work). |
| 126 | Mock::VerifyAndClearExpectations(service()); |
| 127 | } |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 128 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 129 | class ObserveSetOfPreferencesTest : public testing::Test { |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 130 | public: |
| 131 | virtual void SetUp() { |
[email protected] | 5b19952 | 2012-12-22 17:24:44 | [diff] [blame] | 132 | pref_service_.reset(new TestingPrefServiceSimple); |
[email protected] | b1de2c7 | 2013-02-06 02:45:47 | [diff] [blame] | 133 | PrefRegistrySimple* registry = pref_service_->registry(); |
| 134 | registry->RegisterStringPref(kHomePage, "http://google.com"); |
| 135 | registry->RegisterBooleanPref(kHomePageIsNewTabPage, false); |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 136 | registry->RegisterStringPref(kApplicationLocale, std::string()); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 137 | } |
| 138 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 139 | PrefChangeRegistrar* CreatePrefChangeRegistrar() { |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 140 | PrefChangeRegistrar* pref_set = new PrefChangeRegistrar(); |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 141 | base::Closure callback = base::Bind(&base::DoNothing); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 142 | pref_set->Init(pref_service_.get()); |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 143 | pref_set->Add(kHomePage, callback); |
| 144 | pref_set->Add(kHomePageIsNewTabPage, callback); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 145 | return pref_set; |
| 146 | } |
| 147 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 148 | MOCK_METHOD1(OnPreferenceChanged, void(const std::string&)); |
[email protected] | 54ffd94a | 2012-11-12 15:29:20 | [diff] [blame] | 149 | |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 150 | std::unique_ptr<TestingPrefServiceSimple> pref_service_; |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 151 | }; |
| 152 | |
| 153 | TEST_F(ObserveSetOfPreferencesTest, IsObserved) { |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 154 | std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar()); |
[email protected] | 5bfdcfd | 2012-11-22 22:08:24 | [diff] [blame] | 155 | EXPECT_TRUE(pref_set->IsObserved(kHomePage)); |
| 156 | EXPECT_TRUE(pref_set->IsObserved(kHomePageIsNewTabPage)); |
| 157 | EXPECT_FALSE(pref_set->IsObserved(kApplicationLocale)); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 158 | } |
| 159 | |
| 160 | TEST_F(ObserveSetOfPreferencesTest, IsManaged) { |
dcheng | 5f043bc | 2016-04-22 19:09:06 | [diff] [blame] | 161 | std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar()); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 162 | EXPECT_FALSE(pref_set->IsManaged()); |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 163 | pref_service_->SetManagedPref(kHomePage, |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 164 | std::make_unique<Value>("http://crbug.com")); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 165 | EXPECT_TRUE(pref_set->IsManaged()); |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 166 | pref_service_->SetManagedPref(kHomePageIsNewTabPage, |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 167 | std::make_unique<Value>(true)); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 168 | EXPECT_TRUE(pref_set->IsManaged()); |
[email protected] | 5bfdcfd | 2012-11-22 22:08:24 | [diff] [blame] | 169 | pref_service_->RemoveManagedPref(kHomePage); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 170 | EXPECT_TRUE(pref_set->IsManaged()); |
[email protected] | 5bfdcfd | 2012-11-22 22:08:24 | [diff] [blame] | 171 | pref_service_->RemoveManagedPref(kHomePageIsNewTabPage); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 172 | EXPECT_FALSE(pref_set->IsManaged()); |
| 173 | } |
| 174 | |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 175 | TEST_F(ObserveSetOfPreferencesTest, Observe) { |
| 176 | using testing::_; |
| 177 | using testing::Mock; |
| 178 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 179 | PrefChangeRegistrar pref_set; |
| 180 | PrefChangeRegistrar::NamedChangeCallback callback = base::Bind( |
| 181 | &ObserveSetOfPreferencesTest::OnPreferenceChanged, |
| 182 | base::Unretained(this)); |
| 183 | pref_set.Init(pref_service_.get()); |
| 184 | pref_set.Add(kHomePage, callback); |
| 185 | pref_set.Add(kHomePageIsNewTabPage, callback); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 186 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 187 | EXPECT_CALL(*this, OnPreferenceChanged(kHomePage)); |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 188 | pref_service_->SetUserPref(kHomePage, |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 189 | std::make_unique<Value>("http://crbug.com")); |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 190 | Mock::VerifyAndClearExpectations(this); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 191 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 192 | EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage)); |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 193 | pref_service_->SetUserPref(kHomePageIsNewTabPage, |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 194 | std::make_unique<Value>(true)); |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 195 | Mock::VerifyAndClearExpectations(this); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 196 | |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 197 | EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0); |
vabr | 8684c9a | 2017-03-29 13:14:57 | [diff] [blame] | 198 | pref_service_->SetUserPref(kApplicationLocale, |
Jinho Bang | 84b58bd | 2018-01-01 21:44:48 | [diff] [blame^] | 199 | std::make_unique<Value>("en_US.utf8")); |
[email protected] | 96a5c34 | 2012-12-04 18:14:02 | [diff] [blame] | 200 | Mock::VerifyAndClearExpectations(this); |
[email protected] | cb7cec1 | 2012-10-15 23:54:59 | [diff] [blame] | 201 | } |
[email protected] | 7e3ec42c | 2012-12-16 05:13:21 | [diff] [blame] | 202 | |
| 203 | } // namespace base |