blob: 0c6df1b38025d6e4865ac4560c61322b6eff2ca1 [file] [log] [blame] [view]
brettw40e953e2017-02-08 17:49:281# Code Reviews
2
3Code reviews are a central part of developing high-quality code for Chromium.
4All changes must be reviewed.
5
Daniel Cheng6bffde02020-06-12 19:10:456The general patch, upload, and land process is covered in more detail in the
7[contributing code](contributing.md) page.
brettw40e953e2017-02-08 17:49:288
9# Code review policies
10
11Ideally the reviewer is someone who is familiar with the area of code you are
brettw2019b9e2017-02-09 06:40:2012touching. Any committer can review code, but an owner must provide a review
13for each directory you are touching. If you have doubts, look at the git blame
14for the file and the `OWNERS` files (see below).
brettw40e953e2017-02-08 17:49:2815
Michael Giuffridaaf367052018-03-22 20:22:3416To indicate a positive review, the reviewer provides a "Code-Review +1" in
17Gerrit, also known as an LGTM ("Looks Good To Me"). A score of "-1" indicates
18the change should not be submitted as-is.
brettw40e953e2017-02-08 17:49:2819
Michael Giuffridaaf367052018-03-22 20:22:3420If you have multiple reviewers, provide a message indicating what you expect
21from each reviewer. Otherwise people might assume their input is not required
22or waste time with redundant reviews.
brettw2019b9e2017-02-09 06:40:2023
Annie Sullivand04212e72017-10-19 21:11:3224Please also read [Respectful Changes](cl_respect.md) and
25[Respectful Code Reviews](cr_respect.md).
26
brettw2019b9e2017-02-09 06:40:2027#### Expectations for all reviewers
brettw40e953e2017-02-08 17:49:2828
29 * Aim to provide some kind of actionable response within 24 hours of receipt
Michael Giuffridaaf367052018-03-22 20:22:3430 (not counting weekends and holidays). This doesn't mean you have to do a
31 complete review, but you should be able to give some initial feedback,
32 request more time, or suggest another reviewer.
brettw40e953e2017-02-08 17:49:2833
Michael Giuffridaaf367052018-03-22 20:22:34