brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 1 | # Code Reviews |
| 2 | |
| 3 | Code reviews are a central part of developing high-quality code for Chromium. |
| 4 | All changes must be reviewed. |
| 5 | |
Daniel Cheng | 6bffde0 | 2020-06-12 19:10:45 | [diff] [blame^] | 6 | The general patch, upload, and land process is covered in more detail in the |
| 7 | [contributing code](contributing.md) page. |
brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 8 | |
| 9 | # Code review policies |
| 10 | |
| 11 | Ideally the reviewer is someone who is familiar with the area of code you are |
brettw | 2019b9e | 2017-02-09 06:40:20 | [diff] [blame] | 12 | touching. Any committer can review code, but an owner must provide a review |
| 13 | for each directory you are touching. If you have doubts, look at the git blame |
| 14 | for the file and the `OWNERS` files (see below). |
brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 15 | |
Michael Giuffrida | af36705 | 2018-03-22 20:22:34 | [diff] [blame] | 16 | To indicate a positive review, the reviewer provides a "Code-Review +1" in |
| 17 | Gerrit, also known as an LGTM ("Looks Good To Me"). A score of "-1" indicates |
| 18 | the change should not be submitted as-is. |
brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 19 | |
Michael Giuffrida | af36705 | 2018-03-22 20:22:34 | [diff] [blame] | 20 | If you have multiple reviewers, provide a message indicating what you expect |
| 21 | from each reviewer. Otherwise people might assume their input is not required |
| 22 | or waste time with redundant reviews. |
brettw | 2019b9e | 2017-02-09 06:40:20 | [diff] [blame] | 23 | |
Annie Sullivan | d04212e7 | 2017-10-19 21:11:32 | [diff] [blame] | 24 | Please also read [Respectful Changes](cl_respect.md) and |
| 25 | [Respectful Code Reviews](cr_respect.md). |
| 26 | |
brettw | 2019b9e | 2017-02-09 06:40:20 | [diff] [blame] | 27 | #### Expectations for all reviewers |
brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 28 | |
| 29 | * Aim to provide some kind of actionable response within 24 hours of receipt |
Michael Giuffrida | af36705 | 2018-03-22 20:22:34 | [diff] [blame] | 30 | (not counting weekends and holidays). This doesn't mean you have to do a |
| 31 | complete review, but you should be able to give some initial feedback, |
| 32 | request more time, or suggest another reviewer. |
brettw | 40e953e | 2017-02-08 17:49:28 | [diff] [blame] | 33 | |
Michael Giuffrida | af36705 | 2018-03-22 20:22:34 | [diff] [
|