blob: 3b13b69c55a2534c482080061ee93f262aa28a2c [file] [log] [blame]
dnicoara9372a7912014-12-11 01:29:061// Copyright 2014 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
Joone Hurd3ae8732018-04-17 18:05:095#include "ui/display/manager/configure_displays_task.h"
dnicoara9372a7912014-12-11 01:29:066
Gil Dekel788edb62020-11-25 23:41:287#include <cstddef>
Gil Dekelc8b8c4ed2022-05-04 20:30:388#include <string>
Gil Dekel788edb62020-11-25 23:41:289
dnicoara9372a7912014-12-11 01:29:0610#include "base/auto_reset.h"
11#include "base/bind.h"
Gil Dekel36b941dd2021-01-23 00:37:2312#include "base/containers/flat_set.h"
Brett Wilsonb02c0a22017-09-25 22:34:4213#include "base/containers/queue.h"
Hans Wennborg3930cf32020-06-17 16:29:5214#include "base/logging.h"
Daniele Castagna4f0689b2019-10-30 01:16:4715#include "base/metrics/histogram_functions.h"
Gil Dekel788edb62020-11-25 23:41:2816#include "base/metrics/histogram_macros.h"
Gil Dekelc8b8c4ed2022-05-04 20:30:3817#include "base/metrics/sparse_histogram.h"
Gil Dekel788edb62020-11-25 23:41:2818#include "base/numerics/safe_conversions.h"
Mitsuru Oshima96ff4542022-05-02 17:31:3219#include "ui/display/manager/display_manager_util.h"
Mark Yacoubd18a2922020-07-07 01:14:1520#include "ui/display/types/display_configuration_params.h"
Gil Dekelbbc40352021-01-05 18:33:5621#include "ui/display/types/display_constants.h"
Gil Dekel36b941dd2021-01-23 00:37:2322#include "ui/display/types/display_mode.h"
dnicoara9372a7912014-12-11 01:29:0623#include "ui/display/types/display_snapshot.h"
24#include "ui/display/types/native_display_delegate.h"
25
kylechar7a067ec2017-01-07 01:16:2826namespace display {
dnicoara9372a7912014-12-11 01:29:0627
28namespace {
29
Gil Dekelc8b8c4ed2022-05-04 20:30:3830// The epsilon by which a refresh rate value may drift. For example:
31// 239.76Hz --> 240Hz. This value was chosen with the consideration of the
32// refresh rate value drifts presented in the "Video Formats—Video ID Code and
33// Aspect Ratios" table on p.40 of the CTA-861-G standard.
34constexpr float kRefreshRateEpsilon = 0.5f;
35
Gil Dekel788edb62020-11-25 23:41:2836// Because we do not offer hardware mirroring, the maximal number of external
37// displays that can be configured is limited by the number of available CRTCs,
38// which is usually three. Since the lifetime of the UMA using this value is one
39// year (exp. Nov. 2021), five buckets are more than enough for
40// its histogram (between 0 to 4 external monitors).
41constexpr int kMaxDisplaysCount = 5;
42
Gil Dekelc8b8c4ed2022-05-04 20:30:3843// Consolidates the UMA name prefix creation to one location, since it is used
44// in many different call-sites.
45const std::string GetUmaNamePrefixForRequest(
46 const DisplayConfigureRequest& request) {
47 return request.display->type() == DISPLAY_CONNECTION_TYPE_INTERNAL
48 ? std::string("ConfigureDisplays.Internal.Modeset.")
49 : std::string("ConfigureDisplays.External.Modeset.");
50}
51
Gil Dekel66a97bc2022-04-29 04:21:5052// Find the next best mode that is smaller than |request->mode|. The next best
53// mode is found by comparing resolutions, and if those are similar, comparing
54// refresh rates. If no mode is found, return nullptr.
55const DisplayMode* FindNextMode(const DisplayConfigureRequest& request) {
56 DCHECK(request.mode);
Gil Dekelbbc40352021-01-05 18:33:5657
Gil Dekel66a97bc2022-04-29 04:21:5058 // Internal displays are restricted to their native mode. We do not
59 // attempt to downgrade their modes upon failure.
60 if (request.display->type() == DISPLAY_CONNECTION_TYPE_INTERNAL)
dnicoaraa89c2082015-01-05 16:49:0661 return nullptr;
62
Gil Dekel66a97bc2022-04-29 04:21:5063 if (request.display->modes().size() <= 1)
64 return nullptr;
65
dnicoara9372a7912014-12-11 01:29:0666 const DisplayMode* best_mode = nullptr;
Gil Dekel66a97bc2022-04-29 04:21:5067 for (const auto& mode : request.display->modes()) {
68 if (*mode < *request.mode && (!best_mode || *mode > *best_mode))
dbasehore01e90042016-05-27 06:16:5169 best_mode = mode.get();
dnicoara9372a7912014-12-11 01:29:0670 }
71
72 return best_mode;
73}
74
Gil Dekelbbc40352021-01-05 18:33:5675void LogIfInvalidRequestForInternalDisplay(
76 const DisplayConfigureRequest& request) {
77 if (request.display->type() != DISPLAY_CONNECTION_TYPE_INTERNAL)
78 return;
79
80 if (request.mode == nullptr)
81 return;
82
83 if (request.mode == request.display->native_mode())
84 return;
85
86 LOG(ERROR) << "A mode other than the preferred mode was requested for the "
87 "internal display: preferred="
88 << request.display->native_mode()->ToString()
89 << " vs. requested=" << request.mode->ToString()
90 << ". Current mode="
91 << (request.display->current_mode()
92 ? request.display->current_mode()->ToString()
93 : "nullptr (disabled)")
94 << ".";
95}
96
Daniele Castagna4f0689b2019-10-30 01:16:4797// Samples used to define buckets used by DisplayResolution enum.
98// The enum is used to record screen resolution statistics.
99const int32_t kDisplayResolutionSamples[] = {1024, 1280, 1440, 1920,
100 2560, 3840, 5120, 7680};
101
Gil Dekelc8b8c4ed2022-05-04 20:30:38102void UpdateResolutionUma(const DisplayConfigureRequest& request,
103 const std::string& uma_name) {
104 // Display is powered off.
105 if (!request.mode)
106 return;
Daniele Castagna4f0689b2019-10-30 01:16:47107
Gil Dekelc8b8c4ed2022-05-04 20:30:38108 // First, compute the index of the enum DisplayResolution.
109 // The index has to match the definition of the enum in enums.xml.
110 const uint32_t samples_list_size = std::size(kDisplayResolutionSamples);
111 const gfx::Size size = request.mode->size();
Daniele Castagna4f0689b2019-10-30 01:16:47112 uint32_t width_idx = 0;
113 uint32_t height_idx = 0;
Gil Dekelc8b8c4ed2022-05-04 20:30:38114 for (; width_idx < samples_list_size; width_idx++) {
Daniele Castagna4f0689b2019-10-30 01:16:47115 if (size.width() <= kDisplayResolutionSamples[width_idx])
116 break;
117 }
Gil Dekelc8b8c4ed2022-05-04 20:30:38118 for (; height_idx < samples_list_size; height_idx++) {
Daniele Castagna4f0689b2019-10-30 01:16:47119 if (size.height() <= kDisplayResolutionSamples[height_idx])
120 break;
121 }
122
Gil Dekelc8b8c4ed2022-05-04 20:30:38123 int display_resolution_index = 0;
124 if (width_idx == samples_list_size || height_idx == samples_list_size) {
125 // Check if we are in the overflow bucket.
126 display_resolution_index = samples_list_size * samples_list_size + 1;
127 } else {
128 // Compute the index of DisplayResolution, starting from 1, since 0 is used
129 // when powering off the display.
130 display_resolution_index = width_idx * samples_list_size + height_idx + 1;
131 }
132
133 base::UmaHistogramExactLinear(uma_name, display_resolution_index,
134 samples_list_size * samples_list_size + 2);
Daniele Castagna4f0689b2019-10-30 01:16:47135}
136
Gil Dekelc8b8c4ed2022-05-04 20:30:38137// A list of common refresh rates that are used to help fit approximate refresh
138// rate values into one of the common refresh rate bins.
139constexpr float kCommonDisplayRefreshRates[] = {
140 24.0, 25.0, 30.0, 45.0, 48.0, 50.0, 60.0, 75.0,
141 90.0, 100.0, 120.0, 144.0, 165.0, 200.0, 240.0};
Gil Dekel20dc5302020-12-01 20:03:41142
Gil Dekelc8b8c4ed2022-05-04 20:30:38143void UpdateRefreshRateUma(const DisplayConfigureRequest& request,
144 const std::string& uma_name) {
145 // Display is powered off.
146 if (!request.mode)
147 return;
Gil Dekel20dc5302020-12-01 20:03:41148
Gil Dekelc8b8c4ed2022-05-04 20:30:38149 base::HistogramBase* histogram = base::SparseHistogram::FactoryGet(
150 uma_name, base::HistogramBase::kUmaTargetedHistogramFlag);
151
152 // Check if the refresh value is within an epsilon from one of the common
153 // refresh rate values.
154 for (size_t i = 0; i < std::size(kCommonDisplayRefreshRates); ++i) {
155 const bool is_within_epsilon =
156 std::abs(request.mode->refresh_rate() - kCommonDisplayRefreshRates[i]) <
157 kRefreshRateEpsilon;
158 if (is_within_epsilon) {
159 histogram->Add(kCommonDisplayRefreshRates[i]);
160 return;
161 }
162 }
163
164 // Since this is not a common refresh rate value, report it as is.
165 histogram->Add(request.mode->refresh_rate());
Gil Dekel20dc5302020-12-01 20:03:41166}
167
Gil Dekel36b941dd2021-01-23 00:37:23168void UpdateAttemptSucceededUma(
169 const std::vector<DisplayConfigureRequest>& requests,
170 bool display_success) {
171 for (const auto& request : requests) {
Gil Dekelc8b8c4ed2022-05-04 20:30:38172 const std::string uma_name_prefix = GetUmaNamePrefixForRequest(request);
173 base::UmaHistogramBoolean(uma_name_prefix + "AttemptSucceeded",
174 display_success);
Gil Dekel36b941dd2021-01-23 00:37:23175
176 VLOG(2) << "Configured status=" << display_success
177 << " display=" << request.display->display_id()
178 << " origin=" << request.origin.ToString()
179 << " mode=" << (request.mode ? request.mode->ToString() : "null");
180 }
Gil Dekel20dc5302020-12-01 20:03:41181}
182
Gil Dekel36b941dd2021-01-23 00:37:23183void UpdateFinalStatusUma(
184 const std::vector<RequestAndStatusList>& requests_and_statuses) {
Gil Dekel20dc5302020-12-01 20:03:41185 int mst_external_displays = 0;
Gil Dekel36b941dd2021-01-23 00:37:23186 size_t total_external_displays = requests_and_statuses.size();
187 for (auto& request_and_status : requests_and_statuses) {
Gil Dekel472925e2022-05-16 18:55:27188 const DisplayConfigureRequest* request = request_and_status.first;
Gil Dekel36b941dd2021-01-23 00:37:23189
Gil Dekel20dc5302020-12-01 20:03:41190 // Is this display SST (single-stream vs. MST multi-stream).
Gil Dekel472925e2022-05-16 18:55:27191 const bool sst_display = request->display->base_connector_id() &&
192 request->display->path_topology().empty();
Gil Dekel20dc5302020-12-01 20:03:41193 if (!sst_display)
194 mst_external_displays++;
195
Gil Dekel472925e2022-05-16 18:55:27196 if (request->display->type() == DISPLAY_CONNECTION_TYPE_INTERNAL)
Gil Dekel20dc5302020-12-01 20:03:41197 total_external_displays--;
198
Gil Dekel472925e2022-05-16 18:55:27199 const std::string uma_name_prefix = GetUmaNamePrefixForRequest(*request);
Gil Dekelc8b8c4ed2022-05-04 20:30:38200 if (request_and_status.second) {
Gil Dekel472925e2022-05-16 18:55:27201 UpdateResolutionUma(*request, uma_name_prefix + "Success.Resolution");
202 UpdateRefreshRateUma(*request, uma_name_prefix + "Success.RefreshRate");
Gil Dekelc8b8c4ed2022-05-04 20:30:38203 }
204 base::UmaHistogramBoolean(uma_name_prefix + "FinalStatus",
205 request_and_status.second);
Gil Dekel20dc5302020-12-01 20:03:41206 }
207
208 base::UmaHistogramExactLinear(
209 "ConfigureDisplays.Modeset.TotalExternalDisplaysCount",
210 base::checked_cast<int>(total_external_displays), kMaxDisplaysCount);
211
212 base::UmaHistogramExactLinear(
213 "ConfigureDisplays.Modeset.MstExternalDisplaysCount",
214 mst_external_displays, kMaxDisplaysCount);
215
216 if (total_external_displays > 0) {
217 const int mst_displays_percentage =
218 100.0 * mst_external_displays / total_external_displays;
219 UMA_HISTOGRAM_PERCENTAGE(
220 "ConfigureDisplays.Modeset.MstExternalDisplaysPercentage",
221 mst_displays_percentage);
222 }
223}
224
dnicoara9372a7912014-12-11 01:29:06225} // namespace
226
227DisplayConfigureRequest::DisplayConfigureRequest(DisplaySnapshot* display,
228 const DisplayMode* mode,
229 const gfx::Point& origin)
kylechar731f85f92016-12-01 20:50:46230 : display(display), mode(mode), origin(origin) {}
dnicoara9372a7912014-12-11 01:29:06231
232ConfigureDisplaysTask::ConfigureDisplaysTask(
233 NativeDisplayDelegate* delegate,
234 const std::vector<DisplayConfigureRequest>& requests,
Sylvain Defresne23395c7a2019-10-02 10:07:45235 ResponseCallback callback)
dnicoara9372a7912014-12-11 01:29:06236 : delegate_(delegate),
237 requests_(requests),
Sylvain Defresne23395c7a2019-10-02 10:07:45238 callback_(std::move(callback)),
Jeremy Roman47d432e2019-08-20 14:24:00239 task_status_(SUCCESS) {
afakhry4e92e8c2017-04-20 17:04:59240 delegate_->AddObserver(this);
dnicoara9372a7912014-12-11 01:29:06241}
242
Gil Dekel472925e2022-05-16 18:55:27243ConfigureDisplaysTask::RequestToOriginalMode::RequestToOriginalMode(
244 DisplayConfigureRequest* request,
245 const DisplayMode* original_mode)
246 : request(request), original_mode(original_mode) {}
247
afakhry4e92e8c2017-04-20 17:04:59248ConfigureDisplaysTask::~ConfigureDisplaysTask() {
249 delegate_->RemoveObserver(this);
250}
dnicoara9372a7912014-12-11 01:29:06251
252void ConfigureDisplaysTask::Run() {
Gil Dekel3369eec2020-10-06 19:53:10253 DCHECK(!requests_.empty());
dnicoara9372a7912014-12-11 01:29:06254
Gil Dekelc8b8c4ed2022-05-04 20:30:38255 const bool is_first_attempt = pending_display_group_requests_.empty();
Gil Dekel3369eec2020-10-06 19:53:10256 std::vector<display::DisplayConfigurationParams> config_requests;
257 for (const auto& request : requests_) {
Gil Dekelbbc40352021-01-05 18:33:56258 LogIfInvalidRequestForInternalDisplay(request);
259
Gil Dekel3369eec2020-10-06 19:53:10260 config_requests.emplace_back(request.display->display_id(), request.origin,
261 request.mode);
Daniele Castagna4f0689b2019-10-30 01:16:47262
Gil Dekelc8b8c4ed2022-05-04 20:30:38263 if (is_first_attempt) {
264 const std::string uma_name_prefix = GetUmaNamePrefixForRequest(request);
265 UpdateResolutionUma(request,
266 uma_name_prefix + "OriginalRequest.Resolution");
267 }
dnicoara9372a7912014-12-11 01:29:06268 }
269
Gil Dekel36b941dd2021-01-23 00:37:23270 const auto& on_configured =
Gil Dekelc8b8c4ed2022-05-04 20:30:38271 is_first_attempt ? &ConfigureDisplaysTask::OnFirstAttemptConfigured
272 : &ConfigureDisplaysTask::OnRetryConfigured;
Gil Dekel36b941dd2021-01-23 00:37:23273
274 delegate_->Configure(
275 config_requests,
276 base::BindOnce(on_configured, weak_ptr_factory_.GetWeakPtr()));
dnicoara9372a7912014-12-11 01:29:06277}
278
afakhry4e92e8c2017-04-20 17:04:59279void ConfigureDisplaysTask::OnConfigurationChanged() {}
280
281void ConfigureDisplaysTask::OnDisplaySnapshotsInvalidated() {
afakhry4e92e8c2017-04-20 17:04:59282 // From now on, don't access |requests_[index]->display|; they're invalid.
283 task_status_ = ERROR;
284 weak_ptr_factory_.InvalidateWeakPtrs();
Gil Dekel3369eec2020-10-06 19:53:10285 std::move(callback_).Run(task_status_);
afakhry4e92e8c2017-04-20 17:04:59286}
287
Gil Dekel36b941dd2021-01-23 00:37:23288void ConfigureDisplaysTask::OnFirstAttemptConfigured(bool config_success) {
289 UpdateAttemptSucceededUma(requests_, config_success);
Daniele Castagna4f0689b2019-10-30 01:16:47290
Gil Dekel36b941dd2021-01-23 00:37:23291 if (!config_success) {
Gil Dekel472925e2022-05-16 18:55:27292 // Partition |requests_| into smaller groups via
293 // |pending_display_group_requests_|, update the task's state, and initiate
294 // the retry logic. The next time |delegate_|->Configure() terminates
295 // OnRetryConfigured() will be executed instead.
Gil Dekel36b941dd2021-01-23 00:37:23296 PartitionRequests();
297 DCHECK(!pending_display_group_requests_.empty());
Gil Dekel472925e2022-05-16 18:55:27298 // Prep the first group
299 for (const auto& pair : pending_display_group_requests_.front())
300 pair.request->mode = pair.original_mode;
Gil Dekel42f7aba2021-01-08 18:59:55301 task_status_ = PARTIAL_SUCCESS;
302 Run();
303 return;
dnicoara9372a7912014-12-11 01:29:06304 }
305
Gil Dekel36b941dd2021-01-23 00:37:23306 // This code execute only when the first modeset attempt fully succeeds.
307 // Update the displays' status and report success.
Gil Dekel472925e2022-05-16 18:55:27308 for (const DisplayConfigureRequest& request : requests_) {
Gil Dekel36b941dd2021-01-23 00:37:23309 request.display->set_current_mode(request.mode);
310 request.display->set_origin(request.origin);
Gil Dekel472925e2022-05-16 18:55:27311 final_requests_status_.emplace_back(std::make_pair(&request, true));
Gil Dekel36b941dd2021-01-23 00:37:23312 }
Gil Dekel788edb62020-11-25 23:41:28313
Gil Dekel36b941dd2021-01-23 00:37:23314 UpdateFinalStatusUma(final_requests_status_);
Gil Dekel3369eec2020-10-06 19:53:10315 std::move(callback_).Run(task_status_);
dnicoara9372a7912014-12-11 01:29:06316}
317
Gil Dekel36b941dd2021-01-23 00:37:23318void ConfigureDisplaysTask::OnRetryConfigured(bool config_success) {
319 UpdateAttemptSucceededUma(requests_, config_success);
320
321 if (!config_success) {
322 // If one of the largest display request can be downgraded, try again.
323 // Otherwise this configuration task is a failure.
Gil Dekel472925e2022-05-16 18:55:27324 if (DowngradeDisplayRequestGroup()) {
Gil Dekel36b941dd2021-01-23 00:37:23325 Run();
326 return;
327 } else {
Gil Dekel472925e2022-05-16 18:55:27328 // Disable all displays in the current group, since we failed to find an
329 // alternative mode. Note that we skip modeset if the latest (or a
330 // single) pending group fails. There is no point in disabling displays
331 // that are already disabled from previous attempts and failed to change
332 // mode.
333 for (const auto& pair : pending_display_group_requests_.front())
334 pair.request->mode = nullptr;
Gil Dekel36b941dd2021-01-23 00:37:23335 task_status_ = ERROR;
336 }
337 }
338
339 // This code executes only when this display group request fully succeeds or
340 // fails to modeset. Update the final status of this group.
Gil Dekel472925e2022-05-16 18:55:27341 for (const auto& pair : pending_display_group_requests_.front()) {
342 const DisplayConfigureRequest* request = pair.request;
Gil Dekel36b941dd2021-01-23 00:37:23343 final_requests_status_.emplace_back(
344 std::make_pair(request, config_success));
345 if (config_success) {
Gil Dekel472925e2022-05-16 18:55:27346 request->display->set_current_mode(request->mode);
347 request->display->set_origin(request->origin);
Gil Dekel36b941dd2021-01-23 00:37:23348 }
349 }
350
351 // Subsequent modeset attempts will be done on the next pending display group,
352 // if one exists.
353 pending_display_group_requests_.pop();
Gil Dekel36b941dd2021-01-23 00:37:23354 if (!pending_display_group_requests_.empty()) {
Gil Dekel472925e2022-05-16 18:55:27355 // Prep the next group
356 for (const auto& pair : pending_display_group_requests_.front())
357 pair.request->mode = pair.original_mode;
Gil Dekel36b941dd2021-01-23 00:37:23358 Run();
359 return;
360 }
361
362 // No more display groups to retry.
363 UpdateFinalStatusUma(final_requests_status_);
364 std::move(callback_).Run(task_status_);
365}
366
367void ConfigureDisplaysTask::PartitionRequests() {
368 pending_display_group_requests_ = PartitionedRequestsQueue();
Gil Dekel36b941dd2021-01-23 00:37:23369
Mark Yacoub100f2df2022-04-19 18:01:14370 base::flat_set<uint64_t> handled_connectors;
Gil Dekel36b941dd2021-01-23 00:37:23371 for (size_t i = 0; i < requests_.size(); ++i) {
372 uint64_t connector_id = requests_[i].display->base_connector_id();
373 if (handled_connectors.find(connector_id) != handled_connectors.end())
374 continue;
375
Gil Dekel472925e2022-05-16 18:55:27376 std::vector<ConfigureDisplaysTask::RequestToOriginalMode> request_group;
Gil Dekel36b941dd2021-01-23 00:37:23377 for (size_t j = i; j < requests_.size(); ++j) {
Gil Dekel472925e2022-05-16 18:55:27378 if (connector_id == requests_[j].display->base_connector_id()) {
379 // Disable all requests in preparation increment connector retries after
380 // mapping them to their original request.
381 request_group.emplace_back(&requests_[j], requests_[j].mode);
382 requests_[j].mode = nullptr;
383 }
Gil Dekel36b941dd2021-01-23 00:37:23384 }
385
Gil Dekel36b941dd2021-01-23 00:37:23386 handled_connectors.insert(connector_id);
Mark Yacoub100f2df2022-04-19 18:01:14387 pending_display_group_requests_.push(request_group);
Gil Dekel36b941dd2021-01-23 00:37:23388 }
389}
390
Gil Dekel472925e2022-05-16 18:55:27391bool ConfigureDisplaysTask::DowngradeDisplayRequestGroup() {
Gil Dekel36b941dd2021-01-23 00:37:23392 auto cmp = [](DisplayConfigureRequest* lhs, DisplayConfigureRequest* rhs) {
393 return *lhs->mode < *rhs->mode;
394 };
395 std::priority_queue<DisplayConfigureRequest*,
396 std::vector<DisplayConfigureRequest*>, decltype(cmp)>
397 sorted_requests(cmp);
398
Gil Dekel472925e2022-05-16 18:55:27399 for (const auto& pair : pending_display_group_requests_.front()) {
400 if (pair.request->display->type() == DISPLAY_CONNECTION_TYPE_INTERNAL)
Gil Dekel36b941dd2021-01-23 00:37:23401 continue;
402
Gil Dekel472925e2022-05-16 18:55:27403 if (!pair.request->mode)
Gil Dekel36b941dd2021-01-23 00:37:23404 continue;
405
Gil Dekel472925e2022-05-16 18:55:27406 sorted_requests.push(pair.request);
Gil Dekel36b941dd2021-01-23 00:37:23407 }
408
409 // Fail if there are no viable candidates to downgrade
410 if (sorted_requests.empty())
411 return false;
412
413 while (!sorted_requests.empty()) {
414 DisplayConfigureRequest* next_request = sorted_requests.top();
415 sorted_requests.pop();
416
Gil Dekel66a97bc2022-04-29 04:21:50417 const DisplayMode* next_mode = FindNextMode(*next_request);
Gil Dekel36b941dd2021-01-23 00:37:23418 if (next_mode) {
419 next_request->mode = next_mode;
420 return true;
421 }
422 }
423
424 return false;
425}
426
kylechar7a067ec2017-01-07 01:16:28427} // namespace display