[email protected] | 1ee7f89 | 2014-03-04 06:04:25 | [diff] [blame] | 1 | # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 | # Use of this source code is governed by a BSD-style license that can be |
| 3 | # found in the LICENSE file. |
| 4 | |
| 5 | """Chromium presubmit script for src/extensions/browser. |
| 6 | |
| 7 | See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
tfarina | 78bb92f4 | 2015-01-31 00:20:48 | [diff] [blame] | 8 | for more details on the presubmit API built into depot_tools. |
[email protected] | 1ee7f89 | 2014-03-04 06:04:25 | [diff] [blame] | 9 | """ |
| 10 | |
rockot | 39a7fbf | 2015-11-13 17:29:26 | [diff] [blame^] | 11 | import sys |
| 12 | |
| 13 | def _CreateHistogramValueChecker(input_api, output_api, path): |
| 14 | original_sys_path = sys.path |
| 15 | |
| 16 | try: |
| 17 | sys.path.append(input_api.os_path.join( |
| 18 | input_api.PresubmitLocalPath(), '..', '..', 'tools', |
| 19 | 'strict_enum_value_checker')) |
| 20 | from strict_enum_value_checker import StrictEnumValueChecker |
| 21 | finally: |
| 22 | sys.path = original_sys_path |
| 23 | |
| 24 | return StrictEnumValueChecker(input_api, output_api, |
| 25 | start_marker='enum HistogramValue {', end_marker=' // Last entry:', |
| 26 | path=path) |
| 27 | |
| 28 | |
| 29 | def _RunHistogramValueCheckers(input_api, output_api): |
| 30 | results = [] |
| 31 | histogram_paths = ('extensions/browser/extension_event_histogram_value.h', |
| 32 | 'extensions/browser/extension_function_histogram_value.h') |
| 33 | for path in histogram_paths: |
| 34 | results += _CreateHistogramValueChecker(input_api, output_api, path).Run() |
| 35 | return results |
| 36 | |
| 37 | |
[email protected] | 1ee7f89 | 2014-03-04 06:04:25 | [diff] [blame] | 38 | def CheckChangeOnUpload(input_api, output_api): |
| 39 | results = [] |
rockot | 39a7fbf | 2015-11-13 17:29:26 | [diff] [blame^] | 40 | results += _RunHistogramValueCheckers(input_api, output_api) |
[email protected] | 1ee7f89 | 2014-03-04 06:04:25 | [diff] [blame] | 41 | results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) |
| 42 | return results |
rockot | 39a7fbf | 2015-11-13 17:29:26 | [diff] [blame^] | 43 | |