Open
Bug 1991346
Opened 19 days ago
Updated 7 days ago
Replace in-tree consumer of non-standard Iterator() with Object.{values,entries} in DOMi
Categories
(SeaMonkey :: General, defect)
Tracking
(seamonkey2.53? affected)
ASSIGNED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.22)
Attachments
(1 file)
|
1.20 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
DOMi uses non-standard Iterator function which is no longer supported, it should be replaced by Object.entries method.
Also see bug 1293008 and bug 1290637
[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: DOMi prefs page doesn't work properly
Testing completed (on m-c, etc.): 2.53.23pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9516776 -
Flags: review?(frgrahl)
Attachment #9516776 -
Flags: approval-comm-release?
|
||
Updated•7 days ago
|
status-seamonkey2.53:
--- → affected
tracking-seamonkey2.53:
--- → ?
Whiteboard: SM2.53.22
Version: Trunk → SeaMonkey 2.53
|
|
||
Comment 2•7 days ago
|
||
Comment on attachment 9516776 [details] [diff] [review]
1991346-domi-iterator-25323.patch
lgtm r/a+ I think can be taken to 2.53.22 final.
DOMi has been removed from central so 2.53 only.
Attachment #9516776 -
Flags: review?(frgrahl)
Attachment #9516776 -
Flags: review+
Attachment #9516776 -
Flags: approval-comm-release?
Attachment #9516776 -
Flags: approval-comm-release+
You need to log in
before you can comment on or make changes to this bug.
Description
•