Closed Bug 1990369 Opened 27 days ago Closed 25 days ago

Enable the Google Lens/visual search context menu item by default in 145

Categories

(Firefox :: Search, enhancement, P1)

Product:
Firefox
Component:
Search
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
145 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- ?
firefox145 --- verified

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1990369 - Enable the Google Lens/visual search context menu item by default in 145.
48 bytes, text/x-phabricator-request
Details | Review

Gayatri says the Google Lens context menu item should be enabled by default in 145.

This simply changes the default value of the feature-gate pref from false to
true. It does not remove it for two reasons: (1) There's an enterprise policy
that depends on it (bug 1983249 D264608), and (2) it's a setPref for the
feature-gate Nimbus variable (see next point).

This also does not remove the corresponding visualSearchEnabled Nimbus
variable [1] because I think it's wise to keep it around in case of emergency
where we need to disable this feature ASAP. We should remove the variable some
number of releases from now. I'll file a bug for that if this revision is
approved.

[1] https://searchfox.org/firefox-main/rev/ad97131360471d36dfd9cf85695dde35914843bc/toolkit/components/nimbus/FeatureManifest.yaml#144-150

Pushed by dwillcoxon@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/306e46fd2215 https://hg.mozilla.org/integration/autoland/rev/d969106c888c Enable the Google Lens/visual search context menu item by default in 145. r=Standard8,fluent-reviewers,flod
Flags: qe-verify+
Flags: in-testsuite+

https://hg.mozilla.org/mozilla-central/rev/d969106c888c

Status: ASSIGNED → RESOLVED
Closed: 25 days ago
status-firefox145: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
QA Whiteboard: [search] [qa-triage-done-c145/b144] [qa-ver-needed-c145/b144]
QA Contact: dlucaci

Verified as fixed with Firefox 145.0a1 (20251002211313) on macOS 14, Windows 10 and Ubuntu 22.

Status: RESOLVED → VERIFIED
QA Whiteboard: [search] [qa-triage-done-c145/b144] [qa-ver-needed-c145/b144] → [search] [qa-triage-done-c145/b144] [qa-ver-done-c145/b144]
status-firefox145: fixed → verified
Flags: qe-verify+

(Enabling a feature should be marked as an enhancement bug type)

Drew, could you please request an addition to our release notes? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Type: task → enhancement
Flags: needinfo?(adw)

Release Note Request (optional, but appreciated)
[Why is this notable]: It adds a new "Search Image with Google Lens" menu item to Firefox's context menu.
[Affects Firefox for Android]: No
[Suggested wording]: Right-clicking an image now shows a "Search Image with Google Lens" menu item if Google is your default engine. Most common image formats are supported.
[Links (documentation, blog post, etc)]: I don't think there's any

relnote-firefox: --- → ?
Flags: needinfo?(adw)

Note added to 145 nightly release notes thanks.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: