Closed
Bug 1980758
Opened 2 months ago
Closed 2 months ago
Don't show visual search context menu item on unsupported image types
Categories
(Firefox :: Search, task, P2)
Firefox
Search
Tracking
()
RESOLVED
FIXED
143 Branch
Tracking | Status | |
---|---|---|
firefox143 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Regressed 1 open bug)
Details
(Whiteboard: [sng])
Attachments
(1 file)
Google Lens seems not to support SVG on its GET endpoint. Trying with one results in a "Something went wrong" page even though the GET returns a 302 with a valid redirect URL, just like successful requests. I don't know what other common formats might be unsupported.
We should probably just hardcode a check for SVG and not show the menu item. Long term we might want the ability to specify supported image types for visual search URLs in the search config, as a way of generalizing it.
Alternatively we could convert unsupported types to jpeg on the client and then use the POST endpoint, but that's out of scope right now.
Updated•2 months ago
|
Assignee | ||
Comment 1•2 months ago
•
|
||
Example pages with embedded SVG:
- https://searchfox.org/mozilla-central/source/browser/branding/official/content/about-logo.svg
- https://www.svgrepo.com/svg/4733/samples
Wikipedia and other Wikimedia sites seem to use PNG previews for "embedded" SVGs.
Assignee | ||
Updated•2 months ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
Pushed by dwillcoxon@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/69a0abe37524
https://hg.mozilla.org/integration/autoland/rev/310e29c2be8a
Don't show visual search context menu item on unsupported image types. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox143:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
Updated•2 months ago
|
QA Whiteboard: [search] [qa-triage-done-c143/b142]
You need to log in
before you can comment on or make changes to this bug.
Description
•