Introduce the conccept of "rollouts" to our custom Stylelint plugin
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(firefox144 fixed)
Tracking | Status | |
---|---|---|
firefox144 | --- | fixed |
People
(Reporter: hjones, Assigned: jooliver)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp][acorntractors])
Attachments
(1 file)
In order to get our custom design tokens rules enabled without needing to fix all of the existing violations we should introduce the concept of "rollouts," which we've already implemented for our custom eslint plugin. Because Stylelint is configured differently the rollouts implementation will likely be even simpler. It will likely take the form of just disabling the rule for any files (or maybe folders?) with preexisting violations. There's another POC commit for what this looks like here. I used the following script to generate the list of invalid filenames (you'll need to replace /Users/hjones/Projects/firefox/
with your path to the project):
./mach lint -l stylelint \
| grep "error" -B 1 \
| awk 'NR==1 || /^\/.*\.css$/ {print}' \
| sort -u \
| sed 's|/Users/hjones/Projects/firefox/||'
Having rollouts in place should enable us to turn on new rules and start enforcing them for any new code that gets added and in any files that don't already have violations. We will likely need to do this work alongside whatever custom design tokens Stylelint rule we implement first.
Updated•3 months ago
|
Assignee | ||
Updated•2 months ago
|
Comment 1•2 months ago
|
||
Adds a configuration file to support temporarily disabling new stylelint rules for existing files.
Backed out for causing linting failures.
Comment 6•2 months ago
|
||
bugherder |
Updated•2 months ago
|
Description
•