Clean up SeaMonkey 2.53 l10n files and sync them with central as far as possible.
Categories
(SeaMonkey :: General, enhancement)
Tracking
(seamonkey2.53? affected)
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.22)
Attachments
(4 files)
|
774.03 KB,
application/x-zip-compressed
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details |
|
260 bytes,
text/plain
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details |
|
399.53 KB,
application/x-zip-compressed
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details |
|
25.96 KB,
application/x-zip-compressed
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
|
Details |
Pontoon now reformats our central l10n files in https://gitlab.com/seamonkey-project/seamonkey-central-l10n regularly after pushes. For 2.53 we need to manually merge the changes back. The 2.53 files still use the old formatting style in most cases and have other problems like tabs, trailing spaces and Windows CRLF line endings. Lets clean this up and sync as far as possible. Our central l10n files also have a few problems but as a first step see that we can get 2.53 in shape.
|
Assignee | |
Updated•6 months ago
|
|
|
Assignee | |
Comment 1•6 months ago
|
||
1st one cr lf changes
find . -type f -print0 | xargs -0 dos2unix
|
|
Assignee | |
Comment 2•6 months ago
•
|
||
Second one reformat with l10n-fix --continue
This is more or less the same formatting Pontoon uses. I needed to remove some changes in inc files and correct leading non breaking spaces which were formatted as "\ " causing a merge arror.
Technically unreviewable so just shooting for a quick lookover and ra+
|
|
Assignee | |
Comment 3•6 months ago
|
||
Third one manual alignment with central. I usually didn't take access keys changes here. 90% comment fixes and blank line removals.
All languages merged manually to see if technical errors crept in.
I added a leading \u0020 to the variable pop3ServerSaid per comment. Not sure if this is really needed but shouldn't matter.
|
|
Assignee | |
Comment 4•6 months ago
|
||
Last one access key sync with central.
Not sure if we want this one in whole or partially. I ommited obvious bad changes to keys but some of these might be ok. We should either sync these to 2.53 or the current 2.53 ones to central later. Given that 2.53 is currently the production branch might be best to overwrite central access key changes one time and ask localizers to check.
Currently it is a mess which should be corrected one way or the other.
Comment on attachment 9485022 [details]
crlf.zip
[Triage Comment]
Let's have 2.53 as our point of truth, just formatted so it is easy to transplant to central
Comment on attachment 9485026 [details]
Links to the reformat patches
[Triage Comment]
Let's have 2.53 as our point of truth, just formatted so it is easy to transplant to central
Comment on attachment 9485028 [details]
manual.zip
[Triage Comment]
Let's have 2.53 as our point of truth, just formatted so it is easy to transplant to central
Comment on attachment 9485030 [details]
keys.zip
[Triage Comment]
Let's have 2.53 as our point of truth, just formatted so it is easy to transplant to central
Description
•