Closed Bug 1867614 Opened 2 years ago Closed 1 years ago

fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error

Categories

(Toolkit :: UI Widgets, defect, P3)

Product:
Toolkit
Component:
UI Widgets
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox120 --- unaffected
firefox121 --- unaffected
firefox122 --- wontfix
firefox125 --- wontfix
firefox126 --- wontfix
firefox127 --- fixed

People

(Reporter: hjones, Assigned: jsudiaman)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [recomp])

Attachments

(1 file)

Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r?kcochrane
48 bytes, text/x-phabricator-request
Details | Review

This seems to trace back to Bug 1859829 which added a dependency on helpers.mjs which uses ChromeUtils to import different ESModules: https://searchfox.org/mozilla-central/rev/12ea2c521cdd071a6d25b0894f31f8f23b18b76a/browser/components/firefoxview/helpers.mjs#7-11

Off the top of my head I'm not sure what the ideal fix would be. We can add some more unfortunate window.IS_STORYBOOK checks or mock out the relevant parts of ChromeUtils in preview.mjs similar to what we do with window.MozXULElement, but this feels like something we'll keep running into so maybe it's worth finding a better long term solution.

Set release status flags based on info from the regressing bug 1859829

:jsudiaman, since you are the author of the regressor, bug 1859829, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

status-firefox120: --- → unaffected
status-firefox121: --- → unaffected
status-firefox122: --- → affected
status-firefox-esr115: --- → unaffected
Flags: needinfo?(jsudiaman)

Removing NI as this is a Storybook issue, will let the recomp team triage.

Flags: needinfo?(jsudiaman)

The escapeRegExp helper that is requiring the helpers import doesn't actually depend on any of the ChromeUtils stuff, it's also duplicated in a few other places.

Severity: -- → S4
Priority: -- → P3
Whiteboard: [fidefe-reusable-components] → [recomp]
Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED
Pushed by jsudiaman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7a0c04666660 fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley

https://hg.mozilla.org/mozilla-central/rev/7a0c04666660

Status: ASSIGNED → RESOLVED
Closed: 1 years ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch