Closed Bug 1583898 Opened 6 years ago Closed 1 month ago

[Inactive CSS] Display a warning when 'overflow-*' properties are used in contexts where they don't apply

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox145 fixed)

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: miker, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [importance-27.8%])

Attachments

(1 file)

Main file:
devtools/server/actors/utils/inactive-property-helper.js

invalidProperties: [
"overflow",
"overflow-block",
"overflow-inline",
"overflow-style",
"overflow-x",
"overflow-y",
"place-content",
]

inactive-css-only-block-flex-grid = <strong>{ $property }</strong> has no effect on this element since it only applies to block, flex and grid containers.

inactive-css-only-block-flex-grid-fix = Try adding <strong>display:block</strong>, <strong>display:flex</strong> or <strong>display:grid</strong>. { learn-more }

Severity: normal → S3
Summary: [Inactive CSS] Display a warning when 'overflow' is used on non-SVG and non-text elements → [Inactive CSS] Display a warning when 'overflow-*' properties are used in contexts where they don't apply
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

Note that place-content is actually not part of this. It also applies to multicol containers, while the overflow-* properties only apply to block, flex, and grid containers. I've just fixed the related spec. text.

Sebastian

Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/21ece75925d4 https://hg.mozilla.org/integration/autoland/rev/d86351c82e31 [devtools] Handle ignored properties in non-block, non-flex, non-grid containers in inactive CSS. r=devtools-reviewers,fluent-reviewers,flod,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
QA Whiteboard: [qa-triage-done-c146/b145]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: