<tree id="sitesTree"> can be replaced with a listbox.

I can take this one, there's still a revision of bug 1421737 where I rewrote this using a listbox...

Great! :-)

Comment on attachment 8965642 [details] Bug 1446368 - Remove the XUL tree from siteDataRemoveSelected. https://reviewboard.mozilla.org/r/234506/#review240132 ::: browser/components/preferences/siteDataRemoveSelected.xul:49 (Diff revision 1) > <separator /> > > <vbox flex="1"> > <label>&siteTree3.label;</label> > <separator class="thin"/> > - <tree id="sitesTree" flex="1" seltype="single" hidecolumnpicker="true"> > + <listbox id="removalList"></listbox> nit: close with /> ::: browser/themes/shared/incontentprefs/siteDataSettings.css (Diff revision 1) > #removing-label { > font-weight: bold; > } > - > -#sitesTree { > - height: 15em; This seems to work fine on OS X, just make sure that the dialog height is still fine on all platforms, especially with many entries.

So, uhm, on Windows with this patch applied, with too many elements in the list, my browser panics at "Resolving style on unstyled element". I'm not sure how to get a better trace on Windows for this right now. Emilio, you might want to look into that panic. I'm happy to help.

FTR, str: 13:53 <johannh> import the patch locally 13:54 <johannh> go to about:preferences#privacy 13:54 <johannh> go to cookies and site data and click manage data 13:54 <johannh> select, well, more than 10? sites and delete (though there needs to be at least one site left that is not deleted) I can't get to it without a patch for bug 1442183 though. Any chance you have one, even if it's a hacky one to let me debug this?

(In reply to Emilio Cobos Álvarez [:emilio] from comment #7) > FTR, str: > > 13:53 <johannh> import the patch locally > 13:54 <johannh> go to about:preferences#privacy > 13:54 <johannh> go to cookies and site data and click manage data > 13:54 <johannh> select, well, more than 10? sites and delete (though there > needs to be at least one site left that is not deleted) > > I can't get to it without a patch for bug 1442183 though. Any chance you > have one, even if it's a hacky one to let me debug this? Oh, sorry, I meant select and remove each one individually and then click "Save Changes", and I can even reproduce for just more than one (e.g. two) sites.

Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47284c0bd982 Remove the XUL tree from siteDataRemoveSelected. r=Paolo