[#108552] [Ruby master Bug#18782] Race conditions in autoload when loading the same feature with multiple threads. — "ioquatix (Samuel Williams)" <noreply@...>
Issue #18782 has been reported by ioquatix (Samuel Williams).
11 messages
2022/05/14
[ruby-core:108706] [Ruby master Bug#14246] Inconsistent C source code indentation
From:
"ioquatix (Samuel Williams)" <noreply@...>
Date:
2022-05-26 02:58:16 UTC
List:
ruby-core #108706
Issue #14246 has been updated by ioquatix (Samuel Williams). https://github.com/ruby/ruby/pull/5946 experiment with `clang-format`. ---------------------------------------- Bug #14246: Inconsistent C source code indentation https://bugs.ruby-lang.org/issues/14246#change-97756 * Author: shyouhei (Shyouhei Urabe) * Status: Closed * Priority: Normal * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN ---------------------------------------- I would like to focus on following 238 C source codes in our repository. ``` % git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | wc -l 238 ``` Here, in these 238 files, 10 files are indented using spaces only. ``` % git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \ xargs grep --files-without-match $'^\t' | xargs grep --files-with-match '^ ' | wc -l 10 ``` On the other hand 66 files are indented using tabs. ``` % git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \ xargs grep --files-with-match $'^\t' | xargs grep --files-without-match '^ ' | wc -l 66 ``` Other 61 files do not indent. We should not bother them. ``` % git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \ xargs grep --files-without-match $'^\t' | xargs grep --files-without-match '^ ' | wc -l 61 ``` So far so good. But what about remaining 101 files? The answer is obvious; these files MIX indents. ``` % git ls-files | grep '\.\(c\|h\|def\)$' | grep -v 'ext|spec|test' | \ xargs grep --files-with-match $'^\t' | xargs grep --files-with-match '^ ' | wc -l 101 ``` This is totally wrong. No matter should we use spaces or tabs for indentations, it must be consistent. -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:[email protected]?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>