summaryloggraphiclog1graphiclog2commitcommitdifftreerefseditfork
rawpatchinlineside by side (parent: 4755d28)
rawpatchinlineside by side (parent: 4755d28)
| author | Peter Zhu <[email protected]> | |
| Wed, 23 Oct 2024 16:53:32 +0000 (23 12:53 -0400) | ||
| committer | Peter Zhu <[email protected]> | |
| Thu, 24 Oct 2024 13:45:29 +0000 (24 09:45 -0400) |
wmap_cmp will always return true for dead entries since dead entries have
a Qundef value. When the keys have a hash collision, this may cause the
wrong entry to be returned.
This commit changes wmap_cmp to compare by weakmap_entry pointers when
the entry is dead.
a Qundef value. When the keys have a hash collision, this may cause the
wrong entry to be returned.
This commit changes wmap_cmp to compare by weakmap_entry pointers when
the entry is dead.
| weakmap.c | patchblobblamehistory |
diff --git a/weakmap.c b/weakmap.c
--- a/weakmap.c
+++ b/weakmap.c
static int
wmap_cmp(st_data_t x, st_data_t y)
{
- return *(VALUE *)x != *(VALUE *)y;
+ VALUE x_obj = *(VALUE *)x;
+ VALUE y_obj = *(VALUE *)y;
+
+ if (!wmap_live_p(x_obj) && !wmap_live_p(y_obj)) {
+ return x != y;
+ }
+ else {
+ return x_obj != y_obj;
+ }
}
static st_index_t