Re: Port Image_Color and Image_Canvas to PHP8

From: Date: Fri, 29 Nov 2024 23:19:59 +0000
Subject: Re: Port Image_Color and Image_Canvas to PHP8
References: 1 2 3 4 5 6 7  Groups: php.pear.general 
Request: Send a blank email to [email protected] to get a copy of this message 
Hello,

In the meantime, I opened the PR to port Image_Canvas to PHP 8 (https://github.com/pear/Image_Canvas/pull/7). It's not ready since we need the tag in Image_Color but it works.

I know that people are busy but if we could finish this (tag in Image_Color, merge the aforementioned PR and a tag in Image_Canvas), it would really help the project I'm working on.

Thanks in advance,
Mathieu

Le 26/11/2024 à 23:07, Mathieu Dubois a écrit :


Hello,

Thanks to Daniel O'Connor (@CloCkWeRX) for merging this. It seems that people from all over the world are working on this !

Unless you have other suggestions of improvement, could you create a new tag ? As was done in HTML_Template_IT, you can add me as a maintainer (please use [email protected] as email).

Mathieu

Le 25/11/2024 à 23:44, Mathieu Dubois a écrit :


Hello,

Following the progress from yesterday, I opened 2 PRs for Image_Color:

  * #3 <https://github.com/pear/Image_Color/pull/3> adds GitHub

    actions for the current code.

  * #4 <https://github.com/pear/Image_Color/pull/4> ports the code to

    PHP 8.4 (the branch is based on the branch from the previous PR
    so it's best to first merge #3).


See the details on GitHub.

With that, I think one can create a new version of the Image_Color package (1.0.7). This will be used to port Image_Canvas to PHP 8.

Thanks in advance,
Mathieu

Le 24/11/2024 à 22:28, Mathieu Dubois a écrit :


Hi Chuck,

Thanks for merging the CI PRs (for the interested reader, this is https://github.com/pear/Image_Color/pull/2 and https://github.com/pear/Image_Canvas/pull/6). I will open the new PR to port to PHP 8 ASAP. With a good CI, it will ease the job.

Mathieu

Le 24/11/2024 à 17:36, Chuck Burgess a écrit :

Sorry for the delay, looking at these this morning...
CRB
/about.me/ashnazg <http://about.me/ashnazg>/


On Fri, Nov 15, 2024 at 1:30 AM Mathieu Dubois <[email protected]> wrote:


    Dear list,



    As I said on another thread about HTML_Template_IT, I haven't
    received an answer about this. Anybody?



    Thanks in advance,
    Mathieu



    Le 05/10/2024 à 03:13, Mathieu Dubois a écrit :



    Dear list,



    I took a bit of time to work on Image_Canvas (it was not
    without a bit of pain):



      * PR #6 (https://github.com/pear/Image_Canvas/pull/6)
        modernize the scripts and add GitHub actions for the
        current code.
      * Building on that, I was able to port to PHP 8. I will open
        the PR after #6 is merged.



    There are 3 caveats however:



      * PostScript output is not tested yet because I have some
        font issue and you need the PS extension
        (https://www.php.net/manual/en/book.ps.php). It should be
        doable.
      * PDF output is not tested because it uses the old PDFlib
        extension. This code needs to be re-done completely
        (probably based on FPDF).
      * As we require a version of Image_Color compatible with PHP
        8, I use a branch in my fork (see composer.json). Of
        course, I will update that.



    Mathieu



    Le 02/10/2024 à 02:14, Mathieu Dubois a écrit :

    Dear list,



    I need to (try to) port Image_Color and Image_Canvas (which
    require Image_Color) to PHP 8.



    For Image_Color this is not too hard. As I did for
    HTML_Template_IT, the goal is to keep compatibility from PHP
    5.6 to PHP 8. The main challenge is to have CI and be able
    run the test s for a large span of PHP version (as PHPUnit
    changed a lot in between). I opened a first PR
    (https://github.com/pear/Image_Color/pull/2) to convert the
    test suite to PHPUnitPolyFill which is very handy. for such
    cases



    I have 2 branches based on that to add GitHub actions (for
    CI) and to port the code to PHP 8 (I will open the PR after).



    I haven't looked much to Image_Canvas for now but as the
    tests don't use PHPUnit (it's simple scripts), it might be a
    bit simpler.



    As before, I would appreciate any idea on that.



    Thanks in advance,
    Mathieu



    --     Mathieu Dubois - IR - UMR 8030 équipe LABGeM
    CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
    Bureau B07
    +33 1 60 87 53 35

    --     Mathieu Dubois - IR - UMR 8030 équipe LABGeM
    CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France.
    Bureau B07
    +33 1 60 87 53 35
-- Mathieu Dubois - IR - UMR 8030 équipe LABGeM CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France. Bureau B07 +33 1 60 87 53 35 -- Mathieu Dubois - IR - UMR 8030 équipe LABGeM CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France. Bureau B07 +33 1 60 87 53 35 -- Mathieu Dubois - IR - UMR 8030 équipe LABGeM CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France. Bureau B07 +33 1 60 87 53 35 -- Mathieu Dubois - IR - UMR 8030 équipe LABGeM CEA - Genoscope. 2 rue Gaston Crémieux. 91057 Evry Cedex France. Bureau B07 +33 1 60 87 53 35

Thread (7 messages)

« previous php.pear.general (#32322) next »