I don’t understand which E_DEPRECATED you’re talking about. The E_DEPRECATED mechanism proposed
in the RFC is not implemented yet. But, yes, all these failures will raise E_DEPRECATED, as none of
them appears in PHP 5. In such a case, hiding E_DEPRECATED will remove every failure.
Regards
François
De : [email protected] [mailto:[email protected]] De la part de Yasuo Ohgaki
Envoyé : mardi 24 février 2015 05:32
À : francois
Cc : Pierre Joye; Zeev Suraski; Anthony Ferrara; PHP internals
Objet : Re: [PHP-DEV] Coercive Scalar Type Hints RFC - BC breaks
Hi Francois,
On Tue, Feb 24, 2015 at 1:17 PM, François Laupretre <[email protected]> wrote:
I ran the PHP core 'make test' on a basic configuration, still running a significant
number of 8785 tests.
Note: the restrictions on numeric string conversions (leading chars/zeroes, trailing chars) are not
simulated yet, but they shouldn't change the results very much.
The ruleset corresponding to the coercive RFC, as it is published today, globally broke 7.3% of
tests. From these 7.3%, 5.3% correspond to the disabled conversions from null to scalar types, which
will probably have to be reintroduced, as it was suspected. So, if we consider that these
conversions are re-enabled, the resulting coercive ruleset breaks 1.9% of the tests, which is rather
positive, IMO, because there is still room for improvements.
More details soon.
I'm guessing most failures are due to E_DEPRECATED.
I suggest to test without E_DEPRECATED, then it would
be fair figure for the patch. Could you run test without
E_DEPRECATED? We can use -c option for almost all
tests, I think.
Regards,
--
Yasuo Ohgaki
[email protected]