Re: new json, push generated file?
On Mon, Feb 9, 2015 at 1:55 PM, Pierre Joye <[email protected]> wrote:
> I still think it is better to have this file applied. It is not like they
> will change every 2nd day.
>
Hi,
I think that I might have solution for this and also for my another build
problem which is re2c version.
I have just created a PR where I tried to explain everything:
https://github.com/php/php-src/pull/1072
Basically ti adds all sources but allows to regenerate them only if the
options --enable-json-filegen is set (more details are in the description).
The config changes are just for Linux as I'm not sure how to do it on win
and if it's even needed (if someone will send any patches to json scanner
or parser and needs to generate them automatically).
I'll keep the PR open for a week or so and if there are no objection, I
would like merge it. I'm also open changing the name of the option and will
be glad for any config.m4 related comments and reviews.
Cheers
Jakub
Thread (24 messages)