On 01/22/2015 02:30 PM, Dan Ackroyd wrote:
> On 22 January 2015 at 21:07, Lester Caine <[email protected]> wrote:
>> imagick is now available?
>
> Not yet. I'll try to finish it off before the end of the weekend. Most
> of the work was done earlier, but I need to add the changes for the
> Native TLS.
>
> btw this request to update the PHPNG upgrading guide is still open:
>
>> Thanks. I think the TSRM changes need to be added, which could be copied from:
>> https://github.com/php/php-src/commit/dec8eb431adee340fb8dfb9ff33ed29d3279c35f
>> Providing a link to a commit that implemented the TSRM changes for an
>> extension, so that people could see the actual changes needed, would
>> be awesome.
For most extensions that just do something simple like imagick does:
#ifdef ZTS
# define IMAGICK_G(v) TSRMG(imagick_globals_id, zend_imagick_globals *, v)
#else
# define IMAGICK_G(v) (imagick_globals.v)
#endif
There is absolutely nothing to do. You can, just for your own amusement
and because it makes the code look prettier, go through and remove all
instances of TSRMLS_* macros in all your C files. But it isn't critical
since they are just defined to nothing in PHP7. Just leave that TSRMG
define in your .h file and it will do the right thing.
-Rasmus
Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc