Re: Re: [VOTE] Marking return values as important (#[\NoDiscard])

From: Date: Thu, 03 Apr 2025 10:26:29 +0000
Subject: Re: Re: [VOTE] Marking return values as important (#[\NoDiscard])
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
Hi

Am 2025-03-19 15:01, schrieb Volker Dusch:

Tim will take care of finalizing the implementation in the coming days.


The implementation was merged yesterday and the nightly tests of Symfony / PHPUnit / Composer exposed that the LOCK_UN case of flock() was not considered when applying the attribute to flock(). Issue #18235 was filed in PHP’s tracker, proposing to remove the attribute from flock() (keeping the attribute itself and keeping it on the DateTimeImmutable setters):

https://github.com/php/php-src/issues/18235

Unless someone objects with that and requests a follow-up vote, I'll send a PR to remove the attribute from flock() by “informal agreement” in the next days.

Best regards
Tim Düsterhus

Thread (3 messages)

« previous php.internals (#127031) next »