Re: Re: com php-src: Fixed bug #75113: AddedDatePeriod::getRecurrences() method.: NEWS ext/date/php_date.cext/date/php_date.h
ext/date/tests/DatePeriod_getter.phpt
On 18.03.2019 at 13:23, Kalle Sommer Nielsen wrote:
> Den man. 18. mar. 2019 kl. 07.56 skrev Sebastian Bergmann <sebastian@php..net>:
>
>> Am 17.03.2019 um 19:37 schrieb Derick Rethans:
>>
>>> Commit: 6eb83a63e1833f0991af4ccccc5533269c8af96c
>>> Author: Ignace Nyamagana Butera <nyamsprod@gmail.com> Tue, 26 Feb 2019
>>> 21:21:46 +0100
>>> Committer: Derick Rethans <github@derickrethans.nl> Sun, 17 Mar 2019
>>> 14:37:35 -0400
>>> Parents: f167b06d4c86c96291c21c027ba3cae22f5b5be8
>>> Branches: PHP-7.2 PHP-7.3 PHP-7.4 master
>>>
>>> Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=6eb83a63e1833f0991af4ccccc5533269c8af96c
>>>
>>> Log:
>>> Fixed bug #75113: Added DatePeriod::getRecurrences() method.
>>
>> Why is new functionality added to PHP 7.2 and PHP 7.3?
>
> Seconded, it should follow the same path as other functionality. We
> did not merge the crc32c below 7.4 because of these are release
> branches
While our release process allows for “small self contained features[sic]
additions” in revisions[1], it also emphasizes that these should be
“carefully considered on a case by case basis”. Not sure if the latter
has been done, but since concerns about this feature addition have been
raised, it appears to be appropriate to clarify the reasoning.
I believe it is because DatePeriod::$recurrences doesn't work for all
cases (and fixing the property would potentially break BC), but Derick
may have more to say about it. :)
[1] <https://wiki.php.net/rfc/releaseprocess#releases_cycle>
--
Christoph M. Becker
Thread (3 messages)