On Thu, Oct 16, 2025 at 01:29:01PM +0200, AngeloGioacchino Del Regno wrote: > Il 16/10/25 12:08, Sjoerd Simons ha scritto: > > Different SoCs have different numbers of Wireless Ethernet > > Dispatch (WED) units: > > - MT7981: Has 1 WED unit > > - MT7986: Has 2 WED units > > - MT7988: Has 2 WED units > > > > Update the binding to reflect these hardware differences. The MT7981 > > also uses infracfg for PHY switching, so allow that property. > > > > Signed-off-by: Sjoerd Simons <sjoerd@xxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/net/mediatek,net.yaml | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml > > index b45f67f92e80d..453e6bb34094a 100644 > > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > > @@ -112,7 +112,7 @@ properties: > > mediatek,wed: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > - minItems: 2 > > + minItems: 1 > > If minItems is 1 here > > > maxItems: 2 > > items: > > maxItems: 1 > > @@ -338,12 +338,14 @@ allOf: > > - const: netsys0 > > - const: netsys1 > > - mediatek,infracfg: false > > - > > mediatek,sgmiisys: > > minItems: 2 > > maxItems: 2 > > + mediatek,wed: > > + minItems: 1 > > You just need maxItems here. > > > + maxItems: 1 > > + > > - if: > > properties: > > compatible: > > @@ -385,6 +387,10 @@ allOf: > > minItems: 2 > > maxItems: 2 > > + mediatek,wed: > > + minItems: 2 > > + maxItems: 2 > > + > > - if: > > properties: > > compatible: > > @@ -429,6 +435,10 @@ allOf: > > - const: xgp2 > > - const: xgp3 > > + mediatek,wed: > > + minItems: 2 > > + maxItems: 2 > > Analogously, you should be needing just minItems here if I'm not wrong. Yeah, you don't need to duplicate constraints that are copies of the outermost one set in the definition. I dunno how it is actually done by the schema tools, but I like to think of it that every constraint that's possible is applied at the same time. pw-bot: changes-requested > > Cheers, > Angelo > > > + > > patternProperties: > > "^mac@[0-2]$": > > type: object > > > >
Attachment:
signature.asc
Description: PGP signature
