chenBright commented on code in PR #3297:
URL: https://github.com/apache/brpc/pull/3297#discussion_r3254345059


##########
registry/modules/libunwind/metadata.json:
##########
@@ -0,0 +1,19 @@
+{
+    "homepage": "https://www.nongnu.org/libunwind/";,
+    "maintainers": [
+        {
+            "email": "[email protected]",
+            "github": "vtsao-openai",
+            "github_user_id": 176426301,
+            "name": "Vincent Tsao"
+        }
+    ],
+    "repository": [
+        "github:libunwind/libunwind"
+    ],
+    "versions": [
+        "1.8.1.brpc-no-unwind",
+        "1.8.3.brpc-no-unwind"

Review Comment:
   These two versions refer to libunwind in the registry: 
registry/modules/libunwind/1.8.1.brpc-no-unwind and 
registry/modules/libunwind/1.8.3.brpc-no-unwind.
   
   Users can select a specific version in MOUDLE.bazel, for example:
   
   ```
   bazel_dep(name = 'libunwind', version = '1.8.3.brpc-no-unwind', repo_name = 
'com_github_libunwind_libunwind')
   ```
   
   I will modify the libunwind version in MOUDLE.bazel in a subsequent commit 
optimizing bazel unit tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to