@leemon thanks for reporting, we will look into that.
@leemon we added/fiex the required code snippets, we now should only have to wait for the translation files to get updated automatically.
Thread Starter
leemon
(@leemon)
I waited for plugin and the translation files to get updated, but I’m still seeing the block strings untranslated. See:
https://i.postimg.cc/LXNYv9Qd/guten.jpg
@leemon we are working on it. Can you please try setting your site to german for testing and see if the media description changes. For us it does.
https://postimg.cc/RJvm6q2P
Thread Starter
leemon
(@leemon)
I switched to de_DE and the translation works. It seems that you are picking the language MO files from the plugin’s /gutenslider/languages/
folder instead of the /wp-content/languages/plugins/
folder where language packs from translate.wordpress.org
are stored. In there I can find the following files:
gutenslider-es_ES-ad07a06c3a432a90a1dc7cb6ddce9bbc.json
gutenslider-es_ES.mo
gutenslider-es_ES.po
I think the issue here is that your plugin is using a text domain (eedee-gutenslider
) that is different than the plugin’s slug in the repo (gutenslider
). According to the official docs, both strings must match in order for the translations from translate.wordpress.org to work correctly.
https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/:
The text domain must match the slug of the plugin. If your plugin is a single file called my-plugin.php or it is contained in a folder called my-plugin the domain name must be my-plugin. If your plugin is hosted on wordpress.org it must be the slug portion of your plugin URL (wordpress.org/plugins/<slug>).
-
This reply was modified 3 years, 8 months ago by
leemon.
-
This reply was modified 3 years, 8 months ago by
leemon.
@leemon thanks for the information you gathered and provide. As Gutenslider is our first plugin (with a large user base) we never had translation questions coming up.
We will test with the changes you propose and answer here soon.
Thank you for your input again.
Niklas
@leemon we updated our code. Gutenslider now should automatically load translations from the WordPress translation directory for our plugin. Can you see if it works for you?
We also updated the .pot file and it contains more strings now that need to be translated.
Hope it works, and thank you again for the notice and help fixing the issue.
Thread Starter
leemon
(@leemon)
Now, it seems the plugin is picking the Spanish translation from translate.wordpress.org. But, for some reason some parts of the plugin are still in English (see linked attachments below). The Spanish translation in translate.wordpress.org is at 100%. I don’t see any new strings to translate.
https://i.postimg.cc/TYfGqG88/Screenshot1.jpg
https://i.postimg.cc/X7LWsh3r/Screenshot2.jpg
Thread Starter
leemon
(@leemon)
No, some strings are still untranslated