Plugin doesn’t work well with custom wp-admin path

  • Resolved andrei0x309

    (@andrei0x309)


    4 years ago

    I searched, to see if anybody reported this, and I think it hasn’t been reported.

    The problem is that the plugin uses hardcoded wp-admin instead of using get_admin_url(); this will cause problems with websites that have a custom admin path(control-panel, etc), and will cause the communication between jetpack and admin panel to not function(backup for example.)

    Thanks.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Contributor Jen H. (a11n)

    (@jenhooks)

    4 years ago

    Hey @andrei0x309,

    Thanks for this feedback. I’ve logged it as an enhancement issue on the Jetpack GitHub repository. You can find it here.

    If you would care to chime in on the issue and offer any additional feedback or specifics, that would be super welcome. 🙂

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    4 years ago

    Hi @andrei0x309!

    The problem is that the plugin uses hardcoded wp-admin instead of using get_admin_url();

    Do you happen to have a specific example of where things are broken? We do try to rely on get_admin_url() and similar options where possible, but if there is a use-case where we’ve missed things, we’d love to know!

    Thank you.

    Thread Starter andrei0x309

    (@andrei0x309)

    4 years ago

    Yeah, I guess is hardcoded here in JS: https://github.com/Automattic/jetpack/blob/ba2dd6c30be137baad96aafb2466d0aed7e182e5/projects/plugins/jetpack/extensions/shared/plan-upgrade-notification.js#L34-L36

    Also, on the page https://cloud.jetpack.com/pricing/BLOG_URL?site=BLOG_URL&source=jetpack-connect-plans where you will arrive after the plugin setup wp-admin it is hard-code on the free plan button, maybe it would be a good idea to transfer the admin URI too like https://cloud.jetpack.com/pricing/BLOG_URL?site=BLOG_URL&admin_url=custom-fragment&source=jetpack-connect-plans

    Anyway, that’s only a wrong redirect, and after some digging, I don’t think custom admin_url causes a problem with the jetpack connection.

    And I found why the connection with the jetpack doesn’t work in my case, it is because I used a WP instance with a custom port (8443) it seems the jetpack connection only works with non-custom ports.

    Maybe you should add on https://jetpack.com/support/getting-started-with-jetpack/fixing-jetpack-connection-issues/ that a custom port is not supported.

    I tested with a clean WP 5.7 instance only with the jetpack plugin and it seems if the instance has a custom port the jetpack connection won’t work.

    Thanks.

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    4 years ago

    Thanks for the extra details!

    I found why the connection with the jetpack doesn’t work in my case, it is because I used a WP instance with a custom port (8443) it seems the jetpack connection only works with non-custom ports.

    Custom ports can indeed cause some issues, depending on how your site is configured. It may be worth trying to add the following to your site’s wp-config.php file, and see if it helps:

    
define( 'JETPACK_SIGNATURE__HTTPS_PORT', 8443 );
define( 'JETPACK_SIGNATURE__HTTP_PORT', 8443 );

    Let me know how it goes.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Plugin doesn’t work well with custom wp-admin path’ is closed to new replies.