From c5fc1ce975ecdf1c6818714e47579c5d3531c4ca Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 6 Jun 2022 17:27:56 -0700 Subject: Emit special instruction for array literal + .(hash|min|max) This commit introduces a new instruction `opt_newarray_send` which is used when there is an array literal followed by either the `hash`, `min`, or `max` method. ``` [a, b, c].hash ``` Will emit an `opt_newarray_send` instruction. This instruction falls back to a method call if the "interested" method has been monkey patched. Here are some examples of the instructions generated: ``` $ ./miniruby --dump=insns -e '[@a, @b].max' == disasm: #@-e:1 (1,0)-(1,12)> (catch: FALSE) 0000 getinstancevariable :@a, ( 1)[Li] 0003 getinstancevariable :@b, 0006 opt_newarray_send 2, :max 0009 leave $ ./miniruby --dump=insns -e '[@a, @b].min' == disasm: #@-e:1 (1,0)-(1,12)> (catch: FALSE) 0000 getinstancevariable :@a, ( 1)[Li] 0003 getinstancevariable :@b, 0006 opt_newarray_send 2, :min 0009 leave $ ./miniruby --dump=insns -e '[@a, @b].hash' == disasm: #@-e:1 (1,0)-(1,13)> (catch: FALSE) 0000 getinstancevariable :@a, ( 1)[Li] 0003 getinstancevariable :@b, 0006 opt_newarray_send 2, :hash 0009 leave ``` [Feature #18897] [ruby-core:109147] Co-authored-by: John Hawthorn --- internal/array.h | 1 + 1 file changed, 1 insertion(+) (limited to 'internal/array.h') diff --git a/internal/array.h b/internal/array.h index 3aeb1be2dd..7e55b66a87 100644 --- a/internal/array.h +++ b/internal/array.h @@ -23,6 +23,7 @@ #define RARRAY_PTR_IN_USE_FLAG FL_USER14 /* array.c */ +VALUE rb_ary_hash_values(long len, const VALUE *elements); VALUE rb_ary_last(int, const VALUE *, VALUE); void rb_ary_set_len(VALUE, long); void rb_ary_delete_same(VALUE, VALUE); -- cgit v1.2.3