summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2025-03-14Invoke `inherited` callbacks before `const_added`Jean Boussier
[Misc #21143] Conceptually this makes sense and is more consistent with using the `Name = Class.new(Superclass)` alternative method. However the new class is still named before `inherited` is called. Notes: Merged: https://github.com/ruby/ruby/pull/12927
2025-03-12Restore to use rm_rf for failing exampleHiroshi SHIBATA
https://github.com/ruby/ruby/actions/runs/13804651931/job/38616664529?pr=12911
2025-03-12Use erb executable againHiroshi SHIBATA
Co-authored-by: David Rodríguez <[email protected]>
2025-03-12[rubygems/rubygems] Fix `ENAMETOOLONG` error when creating compact index cacheDavid Rodríguez
If a custom rubygems source URI is long enough, Bundler may end up raising an `ENAMETOOLONG` error and crash. This commit fixes the problem by trimming the cache slug size to fit usual OS requirements. https://github.com/rubygems/rubygems/commit/df40ff1e14 Co-authored-by: mbclu <[email protected]> Co-authored-by: martinemde <[email protected]>
2025-03-12[rubygems/rubygems] Path helper to build paths in compact index cacheDavid Rodríguez
https://github.com/rubygems/rubygems/commit/d28f9b8515
2025-03-12[rubygems/rubygems] Prefer `FileUtils.rm_r` to `FileUtils.rm_rf` for specsDavid Rodríguez
Because it does not swallow errors if it fails to remove the given folders, making issues easier to debug. https://github.com/rubygems/rubygems/commit/0db12d7afc
2025-03-12[rubygems/rubygems] Refactor specs to not try to remove folders that don't existDavid Rodríguez
This has the following benefits: * Avoid duplicated work in some specs that first build a repo, and then overwrite it with a completely different set of gems. * Reduce RSpec nesting and improve readability. * The change also made surfaces several specs that were incorrect since they were unintentionally not testing the right thing. https://github.com/rubygems/rubygems/commit/ed430883e0
2025-03-10[rubygems/rubygems] Adapt specs to extraction of irb from ruby-coreDavid Rodríguez
This gets our daily Bundler CI back to green. https://github.com/rubygems/rubygems/commit/1bb70f75d2 Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10[rubygems/rubygems] `bundle console` deprecation was canceledDavid Rodríguez
https://github.com/rubygems/rubygems/commit/1c237a4c3f Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10[rubygems/rubygems] Reduce duplicate of some spec gemfilesDavid Rodríguez
https://github.com/rubygems/rubygems/commit/bd42c840c6 Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10[rubygems/rubygems] Don't treat a git-sourced gem install as complete if ↵Tara Bass
only the '.git' directory is present. This recovers cases where a git-sourced install can be left in a partially installed state. https://github.com/rubygems/rubygems/commit/d132b7008d Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10[rubygems/rubygems] Switch inject to use shorthand hash syntaxSean Collins
https://github.com/rubygems/rubygems/commit/ba5a62fd04 Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10[rubygems/rubygems] Use shorthand hash syntax for bundle addSean Collins
https://github.com/rubygems/rubygems/commit/9691097036 Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10Revert "Omit irb related examples temporary"Hiroshi SHIBATA
This reverts commit 750e6195040ec3f9d0b172ac1a49a49d9b7d8ba0. Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-10Revert "Move irb detection to top-level before(:each) block"Hiroshi SHIBATA
This reverts commit 261f8023842b6f90007df68dfc3d88a01a9337a2. Notes: Merged: https://github.com/ruby/ruby/pull/12890
2025-03-07[Bug #21174] [Bug #21175] Update rubyspecNobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/12879
2025-03-04Move in-place interning spec to Ruby's testsJean Boussier
Fix: https://github.com/ruby/spec/issues/1249 JRuby and TruffleRuby can't implement this behavior. While quite a lot of code out there relies on it, if it's not implemented it will simply result in sligthly less efficient code, so not the end of the world. Notes: Merged: https://github.com/ruby/ruby/pull/12850
2025-02-28[rubygems/rubygems] Skip default gems executable example with Windows platformHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/b4a8bda811
2025-02-28[rubygems/rubygems] Update version for broken executables with default gemsHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/d2f90a81d9
2025-02-28[rubygems/rubygems] Retry gracefully on blank partial response in compact indexMartin Emde
https://github.com/rubygems/rubygems/commit/fafb9ae090
2025-02-27Use erb for simple executable exampleHiroshi SHIBATA
2025-02-27Use syntax_suggest instead of erb executable.Hiroshi SHIBATA
erb is only working with Ruby 3.5dev.
2025-02-27Move irb detection to top-level before(:each) blockHiroshi SHIBATA
2025-02-27Use erb executable instead of irbHiroshi SHIBATA
Notes: Merged: https://github.com/ruby/ruby/pull/12821
2025-02-27[rubygems/rubygems] Improve error message when on read-only filesystemsDavid Rodríguez
If we fail to write the lockfile, give a better error. https://github.com/rubygems/rubygems/commit/81a08d6eda
2025-02-26Check LoadError firstNobuyoshi Nakada
The message from dlerror is not our concern.
2025-02-26Added assertion strings with Xcode 16.3 betaHiroshi SHIBATA
2025-02-25[rubygems/rubygems] Improve log message about adding a new platformDavid Rodríguez
This message is printed when running `bundle lock --add-platform`. This command affects the lockfile, not the gemfile, and I think it's better to use "You are adding" rather than "You added", because the addition is happening during the current invocation (as opposed to other log messages that talk about a change made to the Gemfile prior to running the command). https://github.com/rubygems/rubygems/commit/aba1e55f5b Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[rubygems/rubygems] Improve log message when resolving due to local platform ↵David Rodríguez
not in lockfile Current it says "you added a new platform to your gemfile", but that's not actually the case here. https://github.com/rubygems/rubygems/commit/1e39527a38 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25[rubygems/rubygems] Modify `bundle doctor` to not report issue when files ↵Edouard CHIN
aren't writable: - ### Problem Running `bundle doctor` warn about files that aren't writable. This makes the output of `bundle doctor` very verbose for something I believe isn't really an issue. ### Context Rubygems keeps the files original permission at the time the gem is packaged. Many gem maintainers have decided that the permissions of the files in their bundled would be 0444, this includes amongst others: minitest, selenium, brakeman... Any git gems that had a 0444 permissions at some point in its git history would also be reported (as bundle doctor look in the `cache/bundler/git/<gem>/object` path). While it completely make sense to report when files aren't readable, maybe it's worth questioning the usefulness of reporting files that can't be written and what problem this causes to the user (if any). ### Solution Removed the check for unwritable file. ### Side note I also tweaked the "No issues ..." message logic as it was doing the opposite (reporting an issue when there is none and vice versa). This wasn't caught in tests because as a stub on `Bundler.ui.info` was missing. https://github.com/rubygems/rubygems/commit/9a426b9495 Notes: Merged: https://github.com/ruby/ruby/pull/12804
2025-02-25Prefer `0.000001` over `0.000001f` for timeout calculations. (#12803)Samuel Williams
Notes: Merged-By: ioquatix <[email protected]>
2025-02-21Use an exclusive range for `ruby_version_is`Nobuyoshi Nakada
Notes: Merged: https://github.com/ruby/ruby/pull/12790
2025-02-21[rubygems/rubygems] Allow noop `bundle install` to work on read-only or ↵David Rodríguez
protected folders As long as there's nothing new to install and gems are already there. If not, give a meaningful error about what happened. This was how things already worked until https://github.com/rubygems/rubygems/commit/345ec45f5a87, so this commit partially reverts that change. https://github.com/rubygems/rubygems/commit/794b0ecb39
2025-02-21[rubygems/rubygems] bin/rubocop -a --only Style/RedundantParenthesesHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/24d4281d86
2025-02-21[rubygems/rubygems] bin/rubocop -a --only Style/MultipleComparisonHiroshi SHIBATA
https://github.com/rubygems/rubygems/commit/677e17aa2e
2025-02-21[rubygems/rubygems] Fix resolver issue due to ill-defined version ranges ↵David Rodríguez
being created https://github.com/rubygems/rubygems/commit/f2f2ac9680
2025-02-19[rubygems/rubygems] Make sure empty gems are not reinstalled every timeDavid Rodríguez
Unfortunately this requires reverting a previous enhancement of reinstalling gems if they incorrectly ship with an empty installation dir. However, there's no way to distinguish this kind of bad state from a gem that's empty for real, for example, sorbet-static-and-runtime. This reverts commit https://github.com/rubygems/rubygems/commit/9720a9b980d2, and adds a spec to make sure empty gems are not reinstalled every time. https://github.com/rubygems/rubygems/commit/7c102394af
2025-02-19[rubygems/rubygems] Don't add gemspec to specification list of our test gemsDavid Rodríguez
Real gems hardly ever do this, so don't do it ourselves for testing either. https://github.com/rubygems/rubygems/commit/2c8960cfb4
2025-02-18reject numbered parameters from Binding#local_variablesYusuke Endoh
Also, Binding#local_variable_get and #local_variable_set rejects an access to numbered parameters. [Bug #20965] [Bug #21049] Notes: Merged: https://github.com/ruby/ruby/pull/12746
2025-02-18[rubygems/rubygems] Reduce confusion about domains used for testingMartin Emde
Sometimes security reports believe they have found a vulnerability because they find a domain we don't own being used in the rubygems repository. Though there is nothing vulnerable about using 'fake' domains in tests when they are never hit, it nonetheless reduces confusion for everyone if we constrain our test domains to domains we actually own and control. https://github.com/rubygems/rubygems/commit/e77ebbe2fc
2025-02-18[rubygems/rubygems] Fix Bundler incorrectly downgrading direct dependenciesDavid Rodríguez
There's no reason to call `converge_specs` when adding additional lower bound requirements to prevent downgrades, and it actually causes the extra requirements to be missed sometimes. Loop over the originally locked specs directly, adding the additional precaution of not adding the requirement if the Gemfile dependency has changed and it no longer matches the locked spec. https://github.com/rubygems/rubygems/commit/5154506912
2025-02-18[rubygems/rubygems] Add additional assertions to specDavid Rodríguez
To make it consistent with the spec above it. https://github.com/rubygems/rubygems/commit/9a00bf8db9
2025-02-18[rubygems/rubygems] Fix locked gems being upgraded when locked dependencies ↵David Rodríguez
are incorrect Resolver had internal logic to prioritize locked versions when sorting versions, however part of it was not being actually hit because of how unlocking worked in the resolver: a package was allow to be unlocked when that was explicit requested or when the list of unlocks was empty. That did not make a lot of sense and other cases were working because the explicit list of unlocks was getting "artificially filled". Now we consider a package unlocked when explicitly requested (`bundle update <package>`), or when everything is being unlocked (`bundle install` with no lockfile or `bundle update`). This makes things simpler and gets the edge case added as a test case working as expected. https://github.com/rubygems/rubygems/commit/b8e55087f0
2025-02-18[rubygems/rubygems] Add intermediate assertion to spec to help debuggingDavid Rodríguez
https://github.com/rubygems/rubygems/commit/ffabab65f2
2025-02-18[rubygems/rubygems] Extract a `TheBundle#locked_specs` test helperDavid Rodríguez
https://github.com/rubygems/rubygems/commit/8cbe6573b4
2025-02-17[rubygems/rubygems] Make Bundler never instantiate development dependenciesDavid Rodríguez
Bundler does not really have a concept of "development dependencies", like RubyGems has. Bundler has the more generic concept of "groups". Under the hood, the `gemspec` DSL will put gemspec development dependencies under a `:development` Gemfile group, but there's no reason to instantiate these as development dependencies, they are regular runtime dependencies, except that they belong in a group named :development. By never instantiating development dependencies at all, we avoid having to introduce hacks to "undo" the type Bundler does not know about, and I also think the error messages read better. https://github.com/rubygems/rubygems/commit/9a06fa5bda
2025-02-14[rubygems/rubygems] Raise error when lockfile is missing deps in frozen modeDavid Rodríguez
And avoid installing any gems. https://github.com/rubygems/rubygems/commit/c12700c7e4
2025-02-14[rubygems/rubygems] Deprecate legacy windows platforms (mswin, mingw) in the ↵johnnyshields
Bundler DSL, in favor of using `platform :windows` This commit is only deprecation and does not change/remove any actual functionality. https://github.com/rubygems/rubygems/commit/0ca6dc3984
2025-02-14[rubygems/rubygems] Use preferred `:windows` value for Windows exclusivelyDavid Rodríguez
https://github.com/rubygems/rubygems/commit/aee52d2874 Co-authored-by: johnnyshields <[email protected]>
2025-02-14[rubygems/rubygems] Let `:bundler` filter raise if not given major versionsDavid Rodríguez
Otherwise it doesn't work as expected and it may skip specs. https://github.com/rubygems/rubygems/commit/d6af077174
generated by cgit v1.2.3 (git 2.25.1) at 2025-06-18 05:21:50 +0000