Age | Commit message (Collapse) | Author |
|
https://github.com/rubygems/rubygems/commit/f40610b699
|
|
https://github.com/rubygems/rubygems/commit/44f3ae4bc8
|
|
https://github.com/rubygems/rubygems/commit/457b25df1a
|
|
In case it gives us some useful debugging output when it fails.
https://github.com/rubygems/rubygems/commit/d781416483
|
|
https://github.com/rubygems/rubygems/commit/b75319aa96
|
|
Signed-off-by: Samuel Giddins <[email protected]>
https://github.com/rubygems/rubygems/commit/1ef33fa0af
|
|
https://github.com/rubygems/rubygems/commit/472371ee1e
|
|
https://github.com/rubygems/rubygems/commit/7ba7073a35
|
|
https://github.com/rubygems/rubygems/commit/362c960497
|
|
https://github.com/rubygems/rubygems/commit/92dcf60fc1
|
|
https://github.com/rubygems/rubygems/commit/8f262f3a47
|
|
As long as we use a high enough test version, the default version of
Bundler should never get in the middle.
https://github.com/rubygems/rubygems/commit/d63f0818aa
|
|
I found it useful to be able to use `GEM_COMMAND` outside of a ruby-core
env, so I made the ruby-core env detection not depend on it.
https://github.com/rubygems/rubygems/commit/6cb389c290
|
|
unsupported Ruby version
https://github.com/rubygems/rubygems/commit/9d41c4088a
|
|
https://github.com/rubygems/rubygems/commit/d8cf4aa0cd
|
|
https://github.com/rubygems/rubygems/commit/0fc3feae19
|
|
truffleruby to cruby
https://github.com/rubygems/rubygems/commit/4f3d9fa3bf
|
|
We use pre-existence of `rake_path` to decide whether we need to
regenerate dummy test gems in `tmp`. When changing rubies, the previous
implementation will believe that the correct `rake_path` exists
and avoids regenerating dummy gems, given an error like the following
when specs are run:
```
(...)
Could not find rubygems-generate_index lib directory in /path/to/rubygems/bundler/tmp/1/gems/base/ruby/3.2.0
# ./spec/support/builders.rb:253:in `block in update_repo'
# ./spec/support/helpers.rb:337:in `block in with_gem_path_as'
# ./spec/support/helpers.rb:351:in `without_env_side_effects'
# ./spec/support/helpers.rb:332:in `with_gem_path_as'
# ./spec/support/builders.rb:251:in `update_repo'
# ./spec/support/builders.rb:228:in `build_repo'
# ./spec/support/builders.rb:197:in `build_repo4'
# ./spec/commands/lock_spec.rb:103:in `block (2 levels) in <top (required)>'
(...)
```
To fix this, fix the part of the path that depends on the implementation
and the Ruby version so that we don't give false positives.
https://github.com/rubygems/rubygems/commit/fafacfa210
|
|
And get specs passing.
https://github.com/rubygems/rubygems/commit/c23b5f5b84
|
|
https://github.com/rubygems/rubygems/commit/0f2db73619
|
|
https://github.com/rubygems/rubygems/commit/0658903e25
|
|
https://github.com/rubygems/rubygems/commit/83b417a166
|
|
Also limit caller ranges
https://github.com/rubygems/rubygems/commit/a274b1af78
|
|
https://github.com/rubygems/rubygems/commit/9f9493c77c
|
|
While working on something else I noticed:
* Usage of uppercased "RUBY" and "JAVA" as platforms, when those don't
really exist.
* Usage of some test gems with "1.0" as gemspec version and "1.0.0" as
actual version.
This commit fixes both inconsistencies to make things more expectable.
https://github.com/rubygems/rubygems/commit/e3ec32e247
|
|
|
|
Instead, build it during setup when in CI.
This should avoid some Windows specific test failures when Bundler
copies the same files from multiple processes and runs into EACESS
errors.
https://github.com/rubygems/rubygems/commit/c194a1d753
|
|
https://github.com/rubygems/rubygems/commit/9f08241d01
|
|
https://github.com/rubygems/rubygems/commit/5c2ad44c18
|
|
I don't understand what was the idea of "!=" here.
https://github.com/rubygems/rubygems/commit/06d5f1dcf1
|
|
When launching bundler subprocesses for end to end testing, all of them
will load the `spec/support/rubygems_version_manager.rb` file passed as
a ruby's `-r` flag.
Unfortunately this file depends on `pathname`, so unless we drop that
dependency, we can't really test support for including the `pathname`
gem in the `Gemfile`.
This commit implements some refactorings to avoid loading `pathname`
inside `bundler` test subprocesses.
https://github.com/rubygems/rubygems/commit/c1f948788c
|
|
https://github.com/rubygems/rubygems/commit/f7c7bae940
|
|
Not that I need it, but reads better.
https://github.com/rubygems/rubygems/commit/db3eca7b92
|
|
https://github.com/rubygems/rubygems/commit/77bc6f1ecc
|
|
https://github.com/rubygems/rubygems/commit/10f2ce1afb
|
|
https://github.com/rubygems/rubygems/commit/2d9eeadb62
|
|
take more than a minute
I expect to make occasional CI hangs easier to investigate.
Implementation was adapted from tty-command.
https://github.com/rubygems/rubygems/commit/39c92955bf
|
|
Upstream PR was merged and released.
https://github.com/rubygems/rubygems/commit/d6afbfd664
|
|
https://github.com/rubygems/rubygems/commit/f513ea49b5
|
|
Most of the commands run by these specs actually prompt for user input
but for some reason `Open3` outside of Windows ignores that and goes on
with no user input. Windows does not like this.
This commit refactors these specs so that:
* They don't prompt for user input when not necessary.
* They pass proper user input when necessary.
As long as no user input is needed, most specs pass, so it allows to
remove the `:readline` tag from most of them.
https://github.com/rubygems/rubygems/commit/3dfabcdae4
|
|
This gets in the middle if we ever start allowing to build as if using a
different RubyGems version than the one being run.
This could be useful to make `gem rebuild` a little more usable, and
it's already done by Bundler specs which already make this method a noop
when they need this.
I'm not sure forcefully setting this, even if user explicitly specified
something else is helpful.
Since this could potentially prevent gems explicitly setting a constant
RubyGems version from building, I changed the error of incorrect
RubyGems version from a hard error to a warning, since it will start
happening in those cases if we stop overwriting the version.
https://github.com/rubygems/rubygems/commit/45676af80d
|
|
|
|
Fixes the following error:
````
$ ruby /home/deivid/code/rubygems/rubygems/bundler/spec/support/bundle.rb clean --force
--- ERROR REPORT TEMPLATE -------------------------------------------------------
```
TypeError: no implicit conversion of Pathname into String
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/runtime.rb:167:in `match'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/runtime.rb:167:in `block in clean'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/runtime.rb:164:in `each'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/runtime.rb:164:in `clean'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/cli/clean.rb:13:in `run'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/cli.rb:590:in `clean'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/cli.rb:34:in `dispatch'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/cli.rb:28:in `start'
/home/deivid/code/rubygems/rubygems/bundler/exe/bundle:28:in `block in <top (required)>'
/home/deivid/code/rubygems/rubygems/bundler/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
/home/deivid/code/rubygems/rubygems/bundler/exe/bundle:20:in `<top (required)>'
/home/deivid/code/rubygems/rubygems/bundler/spec/support/bundle.rb:5:in `load'
/home/deivid/code/rubygems/rubygems/bundler/spec/support/bundle.rb:5:in `<main>'
```
(...)
````
https://github.com/rubygems/rubygems/commit/ff7ce7eb6d
|
|
|
|
The `RUBY_CODESIGN` environment variable is used by mkmf-generated
Makefile to sign extension bundles on macOS. The variable specifies a
key identifier to use for signing given by the user. However, the key
is usually stored in `$HOME/Library/Keychains` directory, and the test
suite creates a fake `$HOME` directory. This causes the test suite to
try to find the specified key from the fake home directory, which
results in a failure.
https://github.com/rubygems/rubygems/commit/ddcfc65bf7
|
|
https://github.com/rubygems/rubygems/commit/af806b8dff
|
|
|
|
Specs that use extension gems were failing in the new job but I noticed
that they were using very non standard `extconf.rb` files.
The hack being removed here was added just to make specs pass when run
in ruby-core but it seems the underlying issue has been fixed now, and
it's causing issues with Ruby 3.3 and Windows, so necessary so I'm
removing it and moving on.
https://github.com/rubygems/rubygems/commit/5b78275f0e
|
|
This seems worse to detect performance regressions, but at least should
not have many false positives.
https://github.com/rubygems/rubygems/commit/0b28e55415
|
|
Some specs assert empty output, but sometimes they print warnings about
redefinition warnings. Ignore those until they are fixed upstream.
https://github.com/rubygems/rubygems/commit/0cd3b6dbae
|