how to reverse an image?

i want to know how can i reverse image when it reaches to the end of JFrame.
here is my code....
import javax.swing.*; import java.awt.*; import java.awt.event.*; import java.util.Random; class Test { public static void main(String args[]) { JFrame frame = new JFrame(); Cpoint point = new Cpoint(); Cdynamic d = new Cdynamic(point); Cair ca= new Cair(); d.panel.setBackground(Color.ORANGE); point.setBackground(new Color(0,0,255)); JSplitPane sp = new JSplitPane(JSplitPane.VERTICAL_SPLIT, d.panel, point); Container c = frame.getContentPane(); c.add(sp, BorderLayout.CENTER); ca.setPreferredSize(new Dimension(200,0)); c.add(ca, BorderLayout.EAST); frame.setVisible(true); frame.setSize(1280,750); frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); } } class Dynamic extends JPanel { JPanel panel; JButton button; JLabel label; Cpoint cp; Dynamic(Cpoint c) { cp = c; System.out.println("Inside Dynamic class"); panel = new JPanel(); panel.setBackground(Color.yellow); button = new JButton("Fish Die"); label = new JLabel("Label to test"); panel.add(button); panel.add(label); button.addActionListener(new ActionListener(){ public void actionPerformed(ActionEvent ae){ cp.fishAlive = false; if(cp.timer != null && cp.timer.isRunning()) { cp.timer.stop(); cp.repaint(); } } }); } } class Cpoint extends JPanel implements ActionListener{ Cfish1 ball,ball2,ball3,ball4,ball5,ball6; Cbubble1 bull,bull2,bull3,bull4,bull5,bull6,bull7,bull8,bull9,bull10; int newx, newy, midx,midy,getradius, newwidth, newheight; Timer timer; int count; boolean fishAlive = true; int counter = 0; Cpoint() { timer = new Timer(26, this); timer.start(); ball = new Cfish1(500,100, new ImageIcon("g:\\fish\\fish1.jpg").getImage()); bull = new Cbubble1(20,400); } public void paintComponent(Graphics g) { super.paintComponent(g); if(fishAlive) { ball.DisplayFish(g); bull.DisplayBubble(g); } } public void actionPerformed(ActionEvent e) { ball.movementFish(this); bull.movement_bubble(this); try { repaint(); } catch (Exception ex) { ex.printStackTrace(); } System.out.println("timer "+(counter++)); } } class Cfish1 { int x = 2; int y = 5; int dx = 2; int dy = 1; int radius = 9; Image fishImg; public Cfish1() {} public Cfish1(int x, int y,Image img) { fishImg = img; this.x = x; this.y = y; radius = fishImg.getWidth(null)/2; } public int getRadius() { return radius; } public void movementFish(Cpoint sp) { if(x+dx>sp.getWidth()-radius-4) { x = sp.getWidth()-radius-2; dx = -dx; } else if(x+dx<0+radius) { x = 0+radius; dx = -dx; } else{ x+= dx; } if(y+dy>sp.getHeight()-radius-4) { y = sp.getHeight()-radius-4; dy = -dy; } else if(y+dy<0+radius) { y = 0+radius; dy = -dy; } else{ y+= dy; } y+= dy; } public void DisplayFish(Graphics g) { g.drawImage(fishImg,x,y,null); } } class Cbubble1 { private int bulx=0; private int buly=0; private int buldx=0; private int buldy=-2; private int bulradius = 2; String bName; public Cbubble1(int i, int j) { bulx=i; buly=j; } public void movement_bubble(Cpoint sp) { if(buly+buldy>sp.getHeight()-bulradius-4) { buly = sp.getHeight()-bulradius-4; bulradius++; if(bulradius==6) bulradius=1; } else if(buly+buldy<bulradius) { buly=sp.getHeight(); } else{ buly+= buldy; } } public void DisplayBubble(Graphics g) { g.setColor(Color.white); g.drawOval(bulx-bulradius, buly-bulradius, bulradius*4,bulradius*4); } } class Cdynamic extends JPanel { JPanel panel; JButton buttonDead, buttonAlive; Cpoint cp; Cdynamic(Cpoint c) { cp = c; System.out.println("Inside Dynamic class"); panel = new JPanel(); panel.setBackground(Color.yellow); buttonDead = new JButton("Remove Oxygen"); buttonAlive = new JButton("Add Oxygen"); panel.add(buttonDead); panel.add(buttonAlive); buttonDead.addActionListener(new ActionListener(){ public void actionPerformed(ActionEvent ae){ cp.fishAlive = false; if(cp.timer != null && cp.timer.isRunning()) { cp.timer.stop(); cp.repaint(); } } }); buttonAlive.addActionListener(new ActionListener() { @Override public void actionPerformed(ActionEvent arg0) { cp.fishAlive = true; cp.timer.start(); cp.repaint(); } }); } } class Cair extends JPanel { public void paintComponent(Graphics g) { super.paintComponent(g); g.drawString("Here i will add some air effects", 20, 20); } }

you want the fish to turn around and swim the other way?

grab any image and see if this does what you want.

import java.awt.*; import javax.swing.*; import java.awt.event.*; class Testing { public void buildGUI() { JFrame f = new JFrame(); f.getContentPane().add(new ReverseImage()); f.pack(); f.setLocationRelativeTo(null); f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); f.setVisible(true); } public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable(){ public void run(){ new Testing().buildGUI(); } }); } } class ReverseImage extends JPanel { Image img = new ImageIcon("Test.gif").getImage(); int w = img.getWidth(null); int h = img.getHeight(null); public ReverseImage() { setPreferredSize(new Dimension(w,h)); } public void paintComponent(Graphics g) { super.paintComponent(g); g.drawImage (img,w, 0, 0, h, 0, 0, w, h,this); } }

Not sure what the code does- 220 lines is too much to try to read and understand without any indication of what it does-, so what do you mean by "reverse an image"?

yes this is what i was asking...
but can you tell me where do i implement this in my code, because my Cfish is not a container so i cannot use

setPreferredSize(new Dimension(w,h));

in my Cfish..?

In my reply I said that I neither know what all that code does, nor do I know what it means to "reverse an image". So I'm not in a position to tell you where in the code that I do not understand you should be doing the thing I do not understand.

Maybe you can try to explain a) what the code does, or is supposed to be doing in case it doesn't yet do what you would like it to do, and b) how you would like to alter it, including telling us what "reversing an image" means.

okay. reverse an image i mean is i have a frame in which images is moving and when the image reached to the frame size, it get back.
i mean an image is moving in the frame, but right now when it reaches at the end of frame, it get back in the same position it is, but i want to reverse/change the position when it coming back..
the sample code which michale gave is what i m saying.

That's called a horizontal flip.

> because my Cfish is not a container so i cannot use
> setPreferredSize(new Dimension(w,h));

that was only required for the example, as explained a couple of times previous,
without components, the panel will be set at (0,0) size, unless it is set in the program.

> but can you tell me where do i implement this in my code,

you already have the fish image moving one way, (e.g.) left-to-right, and when it
reaches the edge of the tank/panel, it reverses and goes right-to-left.

you already have the DisplayFish code for moving (e.g.) left-to-right, so now
you need to add there the 'reverseImage' painting code, so you'll end up with
if(going left-to-right) drawNormal
else drawReverse

easiest way to check is to include a class variable
int direction = 1;

so the code becomes
if(direction == 1) drawNormal
else drawReverse

and when the edge of the tank/panel is reached, you include in that code
direction *= -1;
so that direction will always be only 1 or -1

okay i did this as you said, but not working, here is what is did....

Cfish.java

import java.awt.Graphics; import java.awt.Image; import java.awt.image.ImageObserver; class Cfish { int x = 2; int y = 5; int dx = 2; int dy = 1; int radius = 9; Image fishImg; int w,h; int direction = 1; //-------------------->added public Cfish() {} public Cfish(int x, int y,Image img) { fishImg = img; this.x = x; this.y = y; radius = fishImg.getWidth(null)/2; w = fishImg.getWidth(null); h = fishImg.getHeight(null); } public int getRadius() { return radius; } public void movementFish(Cpoint sp) { if(x+dx>sp.getWidth()-radius-24) { x = sp.getWidth()-radius-22; dx = -dx; direction =-1; //---------------------> initialize to -1 when reached to the end of panel (width) } else if(x+dx<0+radius) { x = 0+radius; dx = -dx; } else{ x+= dx; } if(y+dy>sp.getHeight()-radius-24) { y = sp.getHeight()-radius-24; dy = -dy; direction=-1; //---------------------> initialize to -1 when reached to the end of panel (height) } else if(y+dy<0+radius) { y = 0+radius; dy = -dy; } else{ y+= dy; } y+= dy; } public void DisplayFish(Graphics g) { g.drawImage(fishImg,x,y,null); } public void ReverseFish(Graphics g) //-------------------> Reverse Method { g.drawImage (fishImg,w, 0, 0, h, 0, 0, w, h,null); } }

Cpoint.java

import javax.swing.*; import java.awt.*; import java.awt.event.ActionEvent; import java.awt.event.ActionListener; import java.util.Random; public class Cpoint extends JPanel implements ActionListener{ String imageFile = "g:\\fish\\fish1.jpg"; Cfish fish1,fish2,fish3,fish4,fish5,fish6,fish7,fish8,fish9,fish10; Cbubble bull,bull2,bull3,bull4,bull5,bull6,bull7,bull8,bull9,bull10,bull11,bull12,bull13,bull14,bull15; int newx, newy, midx,midy,getradius, newwidth, newheight; Timer timer; int count; boolean fishAlive = true; int counter = 0; Graphics g; public Cpoint() { timer = new Timer(140, this); timer.start(); fish1 = new Cfish(500,100, new ImageIcon("g:\\fish\\fish1.jpg").getImage()); fish2 = new Cfish(100,300, new ImageIcon("g:\\fish\\fish2.jpg").getImage()); fish3 = new Cfish(800,150, new ImageIcon("g:\\fish\\fish3.jpg").getImage()); fish4 = new Cfish(950,200, new ImageIcon("g:\\fish\\fish4.jpg").getImage()); fish5 = new Cfish(400,400, new ImageIcon("g:\\fish\\fish5.jpg").getImage()); fish6 = new Cfish(300,600, new ImageIcon("g:\\fish\\fish6.jpg").getImage()); fish7 = new Cfish(20,710, new ImageIcon("g:\\fish\\fish7.jpg").getImage()); fish8 = new Cfish(1000,790, new ImageIcon("g:\\fish\\fish8.jpg").getImage()); fish9 = new Cfish(900,275, new ImageIcon("g:\\fish\\fish5.jpg").getImage()); fish10 = new Cfish(90,50, new ImageIcon("g:\\fish\\fish2.jpg").getImage()); Random r= new Random(); //bubbles bull = new Cbubble(20,400); bull2 = new Cbubble(150,450); bull3 = new Cbubble(250,500); bull4 = new Cbubble(400,550); bull5 = new Cbubble(100, 650); bull6 = new Cbubble(600,90); bull7 = new Cbubble(50,700); bull8 = new Cbubble(200,400); bull9 = new Cbubble(100,610); bull10 = new Cbubble(475,300); bull11 = new Cbubble(520,575); bull12 = new Cbubble(590,680); bull13 = new Cbubble(90,750); bull14 = new Cbubble(680,820); bull15 = new Cbubble(800,700); } public void paintComponent(Graphics g) { if(fishAlive) { super.paintComponent(g); //----------------->checking if(fish1.direction==1) fish1.DisplayFish(g); else if(fish1.direction==-1) fish1.ReverseFish(g); if(fish2.direction==1) fish2.DisplayFish(g); else if(fish2.direction==-1) fish2.ReverseFish(g); if(fish3.direction==1) fish3.DisplayFish(g); else if(fish3.direction==-1) fish3.ReverseFish(g); if(fish4.direction==1) fish4.DisplayFish(g); else if(fish4.direction==-1) fish4.ReverseFish(g); if(fish5.direction==1) fish5.DisplayFish(g); else if(fish5.direction==-1) fish5.ReverseFish(g); if(fish6.direction==1) fish6.DisplayFish(g); else if(fish6.direction==-1) fish6.ReverseFish(g); if(fish7.direction==1) fish7.DisplayFish(g); else if(fish7.direction==-1) fish7.ReverseFish(g); if(fish8.direction==1) fish8.DisplayFish(g); else if(fish8.direction==-1) fish8.ReverseFish(g); if(fish9.direction==1) fish9.DisplayFish(g); else if(fish9.direction==-1) fish9.ReverseFish(g); bull.DisplayBubble(g); bull2.DisplayBubble(g); bull3.DisplayBubble(g); bull4.DisplayBubble(g); bull5.DisplayBubble(g); bull6.DisplayBubble(g); bull7.DisplayBubble(g); bull8.DisplayBubble(g); bull9.DisplayBubble(g); bull10.DisplayBubble(g); bull11.DisplayBubble(g); bull12.DisplayBubble(g); bull13.DisplayBubble(g); bull14.DisplayBubble(g); bull15.DisplayBubble(g); new Ctrees().trees(g); } } public void actionPerformed(ActionEvent e) { fish1.movementFish(this); fish2.movementFish(this); fish3.movementFish(this); fish4.movementFish(this); fish5.movementFish(this); fish6.movementFish(this); fish7.movementFish(this); fish8.movementFish(this); fish9.movementFish(this); fish10.movementFish(this); bull.movement_bubble(this); bull2.movement_bubble(this); bull3.movement_bubble(this); bull4.movement_bubble(this); bull5.movement_bubble(this); bull6.movement_bubble(this); bull7.movement_bubble(this); bull8.movement_bubble(this); bull9.movement_bubble(this); bull10.movement_bubble(this); bull11.movement_bubble(this); bull12.movement_bubble(this); bull13.movement_bubble(this); bull14.movement_bubble(this); bull15.movement_bubble(this); try { repaint(); } catch (Exception ex) { ex.printStackTrace(); } } }

it's going to be a lot easier using a component (e.g. JLabel) for your fish.

try this (also try dragging the frame a little wider of thinner)

the fish image I'm using is pointing/swimming to the right - use a similar pointing/swimming one
import javax.swing.*; import java.awt.*; import java.awt.event.*; class FishTank { public FishTank() { Tank tank = new Tank(); Fish fish1 = new Fish(new ImageIcon("Fish1.jpg").getImage(), tank); tank.add(fish1); JFrame f = new JFrame(); f.getContentPane().add(tank); f.pack(); f.setLocationRelativeTo(null); f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); f.setVisible(true); fish1.swim(); } public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable(){ public void run(){ new FishTank(); } }); } } class Tank extends JPanel { public Tank() { setLayout(null); setBackground(Color.BLUE); setPreferredSize(new Dimension(800,600)); } } class Fish extends JLabel { Tank fishTank; Image fishImg; int direction = 1; int w; int h; int startX; int endX; int y = 100; int swimDistance = 5; Timer timer; public Fish(Image f, Tank ft) { fishImg = f; fishTank = ft; startX = 0; endX = fishTank.getPreferredSize().width; w = fishImg.getWidth(null); h = fishImg.getHeight(null); setSize(w,h); setLocation(startX,y); } public void swim() { timer = new Timer(140, new ActionListener(){ public void actionPerformed(ActionEvent ae){ endX = fishTank.getWidth(); int newX = startX + (swimDistance*direction); if(newX < 0) { newX = 0; direction *= -1; } else if(newX + w > endX) { newX = endX - w; direction *= -1; } startX = newX; setLocation(startX,y); } }); timer.start(); } public void paintComponent(Graphics g) { super.paintComponent(g); if(direction == 1) g.drawImage (fishImg,0,0,getWidth(),getHeight(),this); else g.drawImage (fishImg,w, 0, 0, h, 0, 0, w, h,this); } }

okay, Thank you...

i apologies for restarting this thread again, but i am facing some problem, as michael dunn, i implement the code for reversing the image in my project, code is working, but there is some problem in the code,
when the fishes reaches at the end they reverse but after reversing when the come back to 0th position of x, the flow in left to right direction, top to bottom movement is not happening.
i also started a separate thread for this, but i think that thread has only a part of code, so it's harder to read there, and i apologies for this.
can you please check out what i am doing wrong, here is my Cfish.java

import java.awt.Color; import java.awt.Graphics; import java.awt.Image; import java.awt.image.ImageObserver; class Cfish{ int x = 0; int y = 0; int dx = 2; int dy = 1; Image fishImg; int direction =1; public Cfish() {} public Cfish(int x, int y, Image img) { fishImg = img; this.x = x; this.y = y; } public void movementFish(Cpoint sp) { if(x+dx>sp.getWidth()) { x = sp.getWidth(); dx = -dx; direction *= -1; } else if(x+dx<0) { x = 0; dx = -dx; direction *= -1; } else{ x+= dx; System.out.println("\nX is: "+x); } if(y+dy>sp.getHeight()) { y = sp.getHeight(); dy = -dy; } else if(y+dy<0) { y = 0; dy = -dy; } else{ y+= dy; } y+= dy; } public void DisplayFish(Graphics g) { if(direction==1) g.drawImage (fishImg,x,y,null); else g.drawImage (fishImg,x, 0, 0, y, 0, 0, x, y,null); } }

Thank you.

one more problem is also here: sometimes fishes gets disappear and then again come..
i think it's a flickering problem.
how do i solve both of these issues.

> but after reversing when the come back to 0th position of x

that's why I mentioned in my earler reply it's much easier using a component,
does the code I posted work OK in reversing from the edge of the tank/panel?

yes the code which you posted earlier to reverse image works fine, but not able to implement in my project..;-(

i am doing exactly in the same way, but don't know why the problem is there.
the problem is when fishes are coming back after reaching the last point, the are not changing their y position.

> the are not changing their y position.

just tried your code, no images, just drawing a 10x10 rectangle (no reversing),
and there was no problem with the y position changing, but to be honest with you,
this is basic debugging - to test the calculations are working, you should/must be
able to work this basic stuff out for yourself.

your problem is probably here
else g.drawImage (fishImg,x, 0, 0, y, 0, 0, x, y,null);

this is the method signature
public abstract boolean drawImage(Image img,int dx1,int dy1,int dx2,int dy2,int sx1,int sy1,int sx2,int sy2,ImageObserver observer)
and the explanation, from the docs:
img - the specified image to be drawn. This method does nothing if img is null.
dx1 - the x coordinate of the first corner of the destination rectangle.
dy1 - the y coordinate of the first corner of the destination rectangle.
dx2 - the x coordinate of the second corner of the destination rectangle.
dy2 - the y coordinate of the second corner of the destination rectangle.
sx1 - the x coordinate of the first corner of the source rectangle.
sy1 - the y coordinate of the first corner of the source rectangle.
sx2 - the x coordinate of the second corner of the source rectangle.
sy2 - the y coordinate of the second corner of the source rectangle.
observer - object to be notified as more of the image is scaled and converted.

the ..1's are the top left corner, the ..2's are the bottom right corner,
so you should be able to work out the correct code for drawImage(..)

okay, so you mean i need to change the x coordinates, but that i am already doing.
g.drawImage (fishImg,x, 0, 0, y, 0, 0, x, y,null);

Sorry but not getting what exactly needs to do.

you should be able to work it out from this
(needs an image, no bigger than 240,172 otherwise adjust startX/XX and startY/YY, or they'll overlap)

import javax.swing.*; import java.awt.*; import java.awt.event.*; class FishTank { public FishTank() { JFrame f = new JFrame(); f.getContentPane().add(new Tank()); f.pack(); f.setLocationRelativeTo(null); f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); f.setVisible(true); } public static void main(String[] args) { SwingUtilities.invokeLater(new Runnable(){ public void run(){ new FishTank(); } }); } } class Tank extends JPanel { Image fishImg = new ImageIcon("Fish2.jpg").getImage(); int w = fishImg.getWidth(null); int h = fishImg.getHeight(null); int startX = 100; int startY = 400; int startXX = 440; int startYY = 100; public Tank() { setLayout(null); setBackground(Color.BLUE); setPreferredSize(new Dimension(800,600)); System.out.println(w +" " + h); } public void paintComponent(Graphics g) { super.paintComponent(g); g.drawImage (fishImg,100,100,w,h,this);//normal g.drawImage (fishImg,w+startXX, startYY, startXX, h+startYY, 0, 0, w, h,this);//reversed, alongside g.drawImage (fishImg,w+startX, startY, startX, h+startY, 0, 0, w, h,this);//reversed, underneath } }

to make more sense, break up this line
g.drawImage (fishImg,w+startXX, startYY, startXX, h+startYY, 0, 0, w, h,this);//reversed, alongside
to
0, 0, w, h//this is the image from top-left corner (0,0) to bottom-right corner (w,h). note: this doesn't change
w+startXX, startYY, startXX, h+startYY//this is the reversing, from top-right corner to bottom-left corner

I still condider it easier to put the image in a JLabel, the reversing code doesn't change, you just set the location of the label.

it works finally....;-)
well, sorry for asking lot of things, but i also wants to solve the collision problem can you please tell me where can i start and what i needs to do??
or should i start new thread for this?

Thank you very much Michael Dunn.

> or should i start new thread for this?

yes, a new thread will get more attention.

before doing that, search this forum, then google, for
collision detection

there's lots of sample code already posted, but don't immediately
try to apply it to your Cfish/Ctank/Cpoint project - start a new .java file
just a frame, timer for animation and a panel for drawing. in the panel's
paintComponent just draw a couple of rectangles and try to incorporate
your collision detection between the moving rectangles.

if you can't get it to work, post that code not the Cfish/Ctank/Cpoint stuff.

okay....
thank you very much......