Unity

Merge lp:~rodrigo-moya/unity/correct-gsettings-path into lp:unity

  1. correct-gsettings-path
  2. Merge into trunk
Proposed by Rodrigo Moya
Status: Rejected
Rejected by: Rodrigo Moya
Proposed branch: lp:~rodrigo-moya/unity/correct-gsettings-path
Merge into: lp:unity
Diff against target: 17 lines (+2/-2)
1 file modified
com.canonical.Unity.gschema.xml (+2/-2)
To merge this branch: bzr merge lp:~rodrigo-moya/unity/correct-gsettings-path
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Disapprove
Alex Launi (community) Needs Fixing
Review via email: [email protected]

Description of the change

Use /com/canonical path for GSettings schemas

This is the preferred form for the path, rather than using the old GConf paths

To post a comment you must log in.
Revision history for this message
Alex Launi (alexlauni) wrote :

Problem is that this doesn't migrate people's current settings. Some code should probably be added to the migration script to make sure that people's launchers stay the same.

review: Needs Fixing
Revision history for this message
Neil J. Patel (njpatel) wrote :

Hey Rodrigo, /desktop/unity is right for Unity and has been discussed, we won't be moving to /com/canonical, especially now we've got migration scripts etc have been written.

review: Disapprove
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

AFAIK, the policy in GSettings is to use the same path as the key names. So, given that, I guess, Unity will have to move sooner or later to comply with the policy, isn't it better to do it now than when 1000s of users have the old path?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'com.canonical.Unity.gschema.xml'
2--- com.canonical.Unity.gschema.xml 2010-11-30 14:19:02 +0000
3+++ com.canonical.Unity.gschema.xml 2010-12-22 16:17:05 +0000
4@@ -1,5 +1,5 @@
5 <schemalist>
6- <schema path="/desktop/unity/launcher/" id="com.canonical.Unity.Launcher" gettext-domain="unity">
7+ <schema path="/com/canonical/unity/launcher/" id="com.canonical.Unity.Launcher" gettext-domain="unity">
8 <key type="as" name="favorites">
9 <default>[ 'ubiquity-gtkui.desktop', 'nautilus.desktop', 'firefox.desktop', 'ubuntuone-control-panel-gtk.desktop', 'tomboy.desktop' ]</default>
10 <summary>List of desktop file ids for favorites on the launcher.</summary>
11@@ -10,5 +10,5 @@
12 <summary>Version of last migration done</summary>
13 <description>This is a detection key for the favorite migration script to know whether the needed migration is done or not.</description>
14 </key>
15- </schema>
16+ </schema>
17 </schemalist>