Ubuntu Autopilot Tests

Merge lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu into lp:ubuntu-autopilot-tests/ubuntu-experience-tests

motu
Merge into ubuntu-experience-tests

Proposed by Leonardo Arias Fonseca on 2014-08-07

Status:	Merged
Approved by:	Leonardo Arias Fonseca on 2014-08-11
Approved revision:	30
Merged at revision:	26
Proposed branch:	lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu
Merge into:	lp:ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target:	47 lines (+13/-8) 3 files modified debian/changelog (+5/-5) debian/control (+2/-1) debian/rules (+6/-2)
To merge this branch:	bzr merge lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2014-08-12
Martin Pitt (community)			Approve on 2014-08-08
Barry Warsaw (community)			Approve on 2014-08-07
Ubuntu Testcase Admins		2014-08-07	Pending
Review via email: [email protected]

Commit message

Initial commit of Debian packaging.

lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu updated on 2014-08-07

26. By Leonardo Arias Fonseca on 2014-08-07: Set the release.

Revision history for this message

Martin Pitt (pitti) wrote on 2014-08-07:

I reviewed the packaging. It's by and large fine, just two nitpicks:

* debian/rules: --fail-missing isn't a general option for all debhelper programs. This should be done in an override_dh_install and passed to dh_install only. It happens to work like that, but looks both confusing and also not robust.

* Note that flake8 is not a good tool for Python 3 code due to https://bugs.debian.org/748838 . So if you ever use Python 3 specific code in the tests this will blow up.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-07:

PASSED: Continuous integration, rev:26
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/32/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3155
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3184
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4400
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4400/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11140

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/32/rebuild

review: Approve (continuous-integration)

lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu updated on 2014-08-07

27. By Leonardo Arias Fonseca on 2014-08-07: Move the --fail-missing to override_dh_install.
28. By Leonardo Arias Fonseca on 2014-08-07: Do not use flake8 because of https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748838

Revision history for this message

Leonardo Arias Fonseca (elopio) wrote on 2014-08-07:

Thanks for the review Martin. I addressed your comments, but I'm not sure if I did it right. In particular, I'm not sure if I can call the python3 binary from debian/rules.
Please, take a look again.

lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu updated on 2014-08-07

29. By Leonardo Arias Fonseca on 2014-08-07: Specify the dir.

Revision history for this message

Barry Warsaw (barry) wrote on 2014-08-07:

Yep, as long as you have the right build-deps, calling `python3 -m foo` should be perfectly fine. Of course, it will only test the default Python 3, which for now is -- and only -- Python 3.4.

There are several alternatives if you want to make it more general. I'm assuming you don't care about Python 2 (yay! :). You could set PYBUILD_TEST_ARGS as described in the pybuild manpage. Or you could set up tox to run your tests against all supported Python version. Both are probably overkill for now.

LGTM.

review: Approve

Revision history for this message

Leonardo Arias Fonseca (elopio) wrote on 2014-08-07:

yes, I'm perfectly fine checking the static errors only with the default python. Thanks for the review barry.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/33/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Martin Pitt (pitti) wrote on 2014-08-08:

I think you can drop the now unused python3-flake8 build dep. Otherwise, LGTM!

review: Approve

lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu updated on 2014-08-08

30. By Leonardo Arias Fonseca on 2014-08-08: Removed the flake8 dependency.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-08:

PASSED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/34/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3220
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3211
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4465
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4465/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11177

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/34/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-08:

PASSED: Continuous integration, rev:29
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3222
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3215
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4467
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4467/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11184

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/35/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-08:

FAILED: Continuous integration, rev:30
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/36/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3236/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/36
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/36
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4481/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/36/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) on 2014-08-11:

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-12:

PASSED: Continuous integration, rev:30
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3342
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4588
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4588/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11273

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/37/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Canonical Platform QA Team

Leonardo Arias Fonseca

Ubuntu Testcase Admins

 === modified file 'debian/changelog'
 --- debian/changelog	2014-03-10 12:55:24 +0000
 +++ debian/changelog	2014-08-08 06:53:50 +0000
@@ -1,5 +1,5 @@
--ubuntu-experience-tests (0.1-0ubuntu1) UNRELEASED; urgency=medium
--
--  * Initial release.
--
-- -- Omer Akram <[email protected]>  Fri, 07 Feb 2014 00:11:53 +0500
++ubuntu-experience-tests (0.1-0ubuntu1) utopic; urgency=medium
++
++  * Initial release. (Closes: #1353842)
++
++ -- Leonardo Arias Fonseca <[email protected]>  Thu, 07 Aug 2014 00:36:42 -0600
 === modified file 'debian/control'
 --- debian/control	2014-07-03 05:13:26 +0000
 +++ debian/control	2014-08-08 06:53:50 +0000
@@ -4,8 +4,9 @@
  Maintainer: Ubuntu Quality Team <[email protected]>
  Build-Depends: debhelper (>= 9.0.0),
                 dh-python,
++               pyflakes,
                 python3-all,
--               python3-flake8,
++               python3-pep8,
                 python3-setuptools,
  Standards-Version: 3.9.5
  Homepage: https://launchpad.net/ubuntu-autopilot-tests/
 === modified file 'debian/rules'
 --- debian/rules	2014-07-03 05:13:26 +0000
 +++ debian/rules	2014-08-08 06:53:50 +0000
@@ -6,7 +6,11 @@
  export PYBUILD_NAME=ubuntu_experience_tests
  %:
--	dh $@ --fail-missing --with python3 --buildsystem pybuild
++	dh $@ --with python3 --buildsystem pybuild
  override_dh_auto_test:
--	flake8 ubuntu_experience_tests/
++	python3 -m pep8 ubuntu_experience_tests/
++	pyflakes3 ubuntu_experience_tests/
++
++override_dh_install:
++	dh_install --fail-missing

Ubuntu Autopilot Tests

Merge lp:~canonical-platform-qa/ubuntu-autopilot-tests/motu into lp:ubuntu-autopilot-tests/ubuntu-experience-tests

Commit message

Description of the change

Preview Diff

Subscribers