Ubuntu Autopilot Tests

Merge lp:~brendan-donegan/ubuntu-autopilot-tests/fix_skiptest into lp:ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Brendan Donegan on 2014-05-29

Status:	Merged
Approved by:	Leonardo Arias Fonseca on 2014-05-29
Approved revision:	20
Merged at revision:	20
Proposed branch:	lp:~brendan-donegan/ubuntu-autopilot-tests/fix_skiptest
Merge into:	lp:ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target:	11 lines (+1/-1) 1 file modified ubuntu_experience_tests/tests/test_osd_dialer_integration.py (+1/-1)
To merge this branch:	bzr merge lp:~brendan-donegan/ubuntu-autopilot-tests/fix_skiptest
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Leonardo Arias Fonseca (community)	code review, ran the test.	2014-05-29	Approve on 2014-05-29
Review via email: [email protected]

setUp in test_osd_dialer_integration.py calls skiptest at one point. This is not a method of anything. The correct spelling is skipTest.

Revision history for this message

Leonardo Arias Fonseca (elopio) wrote on 2014-05-29:

Thanks for fixing this.

review: Approve (code review, ran the test.)

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'ubuntu_experience_tests/tests/test_osd_dialer_integration.py'
2	--- ubuntu_experience_tests/tests/test_osd_dialer_integration.py 2014-05-26 16:04:56 +0000
3	+++ ubuntu_experience_tests/tests/test_osd_dialer_integration.py 2014-05-29 09:30:53 +0000
4	@@ -30,7 +30,7 @@
5
6	def setUp(self):
7	if platform.model() == 'Desktop':
8	- self.skiptest('The tests is not running on a phone.')
9	+ self.skipTest('The tests is not running on a phone.')
10	if not dialer_helpers.is_phonesim_running():
11	self.skipTest('ofono-phonesim is not running.')
12