rdevlin.cronin | be2898eb | 2016-07-13 01:20:36 | [diff] [blame] | 1 | # Clang Tidy |
| 2 | |
| 3 | [TOC] |
| 4 | |
| 5 | ## Danger, Will Robinson! |
| 6 | |
| 7 | Support for `clang-tidy` in Chromium is very experimental, and is somewhat |
| 8 | painful to use. We are exploring making it easier and integrating with existing |
| 9 | tools, but aren't there yet. If you don't want to wait and enjoy tinkering, |
| 10 | forge ahead. Otherwise, feel free to turn back now. |
| 11 | |
| 12 | ## Introduction |
| 13 | |
| 14 | [clang-tidy](http://clang.llvm.org/extra/clang-tidy/) is a clang-based C++ |
| 15 | “linter” tool. Its purpose is to provide an extensible framework for diagnosing |
| 16 | and fixing typical programming errors, like style violations, interface misuse, |
| 17 | or bugs that can be deduced via static analysis. |
| 18 | |
| 19 | ## Setting Up |
| 20 | |
| 21 | In addition to a full Chromium checkout, you need the clang-tidy binary. We |
| 22 | recommend checking llvm's clang source and building the clang-tidy binary |
| 23 | directly. Instructions for getting started with clang are available from |
| 24 | [llvm](http://clang.llvm.org/get_started.html). You'll need to get llvm, |
| 25 | clang, and the extra clang tools (you won't need Compiler-RT or libcxx). |
| 26 | If you don't have it, you'll also need to install cmake as a part of this |
| 27 | process. |
| 28 | |
| 29 | Instead of building with `"Unix Makefiles"`, generate build files for Ninja with |
| 30 | ``` |
Chris Watkins | e4ffe1e2 | 2017-11-24 00:48:48 | [diff] [blame] | 31 | cmake -GNinja -DCMAKE_BUILD_TYPE=Release ../llvm |
rdevlin.cronin | be2898eb | 2016-07-13 01:20:36 | [diff] [blame] | 32 | ``` |
| 33 | |
| 34 | Then, instead of using `make`, use ninja to build the clang-tidy binary with |
| 35 | ``` |
| 36 | ninja clang-tidy |
| 37 | ``` |
| 38 | |
| 39 | This binary will be at (build)/bin/clang-tidy. |
| 40 | |
| 41 | If you intend to use the `fix` feature of clang-tidy, you'll also need to build |
| 42 | the `clang-apply-replacements` binary. |
| 43 | ``` |
| 44 | ninja clang-apply-replacements |
| 45 | ``` |
| 46 | |
| 47 | ## Running clang-tidy |
| 48 | |
| 49 | Running clang-tidy is (hopefully) simple. |
| 50 | 1. Build chrome normally.\* |
| 51 | ``` |
| 52 | ninja -C out/Release chrome |
| 53 | ``` |
| 54 | 2. Generate the compilation database |
| 55 | ``` |
Daniel Cheng | 51c5530 | 2017-05-04 00:39:16 | [diff] [blame] | 56 | tools/clang/scripts/generate_compdb.py -p out/Release > compile_commands.json |
rdevlin.cronin | be2898eb | 2016-07-13 01:20:36 | [diff] [blame] | 57 | ``` |
| 58 | 3. Enter the build directory. |
| 59 | ``` |
| 60 | cd out/Release |
| 61 | ``` |
| 62 | 4. Run clang-tidy. |
| 63 | ``` |
treib | 52d7e48 | 2016-09-26 21:46:35 | [diff] [
|